-
-
Notifications
You must be signed in to change notification settings - Fork 7.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
“Smart” punctuation + quotes #9397
Comments
bep
added a commit
to bep/hugo
that referenced
this issue
Feb 18, 2022
bep
added a commit
that referenced
this issue
Feb 19, 2022
Hugo 0.93.0 with goldmark 1.4.7 definitely fixed all issues I’d previously reported; see the newly updated version of my test site. Outstanding! |
language... :D |
This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
While @brycewray and I suspect it’s Goldmark-caused rather than Hugo-caused, the Goldmark developer seems to require Goldmark issues that are observed in Hugo to be proposed as Hugo issues before he will have anything to do with them. The relevant Goldmark bug is here: yuin/goldmark#180
This issue occurs with the Typographer extension in Hugo — including the most recent release, 0.92.0 — if goldmark is the selected parser. It doesn’t occur if Blackfriday is the selected parser and “smart” punctuation is activated. (Sadly, Blackfriday is deprecated and the last commit in its repo is from Oct 26, 2020.)
Consider the following text in a Markdown file:
Expected result: Each apostrophe should be a “smart”/curly apostrophe (
’
), given the default behavior of goldmark’s Typographer extension.Actual result: Only the singular possessive (
John's dog
) has the “smart”/curly apostrophe, while the plural possessive (Smiths' dog
) has the “dumb”/straight apostrophe ('
).There are many other examples where the "smart" quotes fail to operate correctly, as shown on these two demo pages:
This issue has been mentioned in the Hugo forums multiple times:
While the bug may be upstream, the upstream maintainer does not speak English fluently and does not feel comfortable dealing with this issue, while many Hugo users speak English and may be able to fix it.
Please remove the "stale bot" equivalent that closed the previous Hugo issue so that we don't have to keep making meaningless updates to keep the still valid issue alive.
Thanks in advance for any help or consideration this issue may receive.
What version of Hugo are you using (
hugo version
)?Does this issue reproduce with the latest release?
Yes.
The text was updated successfully, but these errors were encountered: