resources: Replace error handling in GetRemote with try (note) #13217
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmooring
reviewed
Jan 5, 2025
bep
force-pushed
the
err-getremote-13216
branch
10 times, most recently
from
f128ded to
6fbf0cf
Compare
bep
force-pushed
the
err-getremote-13216
branch
from
6fbf0cf to
49d8a15
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some things I need to think about re. this:
.Erryou get intryis a composite error with file paths etc. I have added.Causeto get the underlying error, so it's possible to get the.Dataattribute that's set on theResourceError... This is a little clumsy, but so be it. Possilby better to do.Err.Cause, not sure.trywe add file/position information, that would also be nice ... but sounds tricky.I have added
.Causeto the error, the second bullet above needs to wait.Closes #13216