Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add slice syntax to permalinks config #8371

Merged
merged 4 commits into from
Mar 30, 2021

Conversation

bep
Copy link
Member

@bep bep commented Mar 28, 2021

Fixes #8363

@bep bep requested a review from moorereason March 28, 2021 16:17
@bep
Copy link
Member Author

bep commented Mar 28, 2021

@moorereason I will update the docs, but thought I should chime in with you before I "waste" more time; I/we kind of need this, and I assume others also do ... What do you think?

Copy link
Contributor

@moorereason moorereason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requesting minor changes. Looks solid though.

resources/page/permalinks.go Show resolved Hide resolved
resources/page/permalinks.go Show resolved Hide resolved
resources/page/permalinks.go Show resolved Hide resolved
@bep bep requested a review from moorereason March 29, 2021 16:05
Copy link
Contributor

@moorereason moorereason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@bep bep merged commit 2dc222c into gohugoio:master Mar 30, 2021
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 31, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow :sections[1:] etc. in permalinks config
2 participants