Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: Update go org to v1.5.0 (and disable a broken feature) #8410

Merged
merged 2 commits into from
Apr 12, 2021
Merged

deps: Update go org to v1.5.0 (and disable a broken feature) #8410

merged 2 commits into from
Apr 12, 2021

Conversation

niklasfasching
Copy link
Contributor

No description provided.

go-org PrettyRelativeLinks rewrites relative org links by
- adding `../` in front
- removing any `.org` suffix

This was meant to play well with hugo pretty urls (which pretty much renders
posts in a subdirectory without the file suffix) and allow use of normal org
file links to reference other posts.

There's a lot of edge cases I didn't consider and multiple bug reports in
go-org [1] later I don't think the complexity of handling those edge cases is
worth it - so let's disable it.

[1]
- niklasfasching/go-org#53
- niklasfasching/go-org@5dadf8c (comment)
- niklasfasching/go-org#51
@niklasfasching niklasfasching changed the title deps: Update go org to v1.5.0 deps: Update go org to v1.5.0 (and disable a broken feature) Apr 11, 2021
@bep bep merged commit fa432b1 into gohugoio:master Apr 12, 2021
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 13, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants