Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(queue): don't prepare request data before worker done. #63

Merged
merged 3 commits into from
Apr 20, 2022
Merged

Conversation

appleboy
Copy link
Member

Signed-off-by: Bo-Yi Wu [email protected]

@appleboy appleboy added the enhancement New feature or request label Apr 20, 2022
@codecov-commenter
Copy link

codecov-commenter commented Apr 20, 2022

Codecov Report

Merging #63 (338ee25) into master (ed24fa1) will decrease coverage by 0.38%.
The diff coverage is 77.77%.

@@            Coverage Diff             @@
##           master      #63      +/-   ##
==========================================
- Coverage   88.96%   88.57%   -0.39%     
==========================================
  Files           9        9              
  Lines         426      429       +3     
==========================================
+ Hits          379      380       +1     
- Misses         42       44       +2     
  Partials        5        5              
Flag Coverage Δ
go-1.13 88.57% <77.77%> (-0.39%) ⬇️
go-1.14 88.57% <77.77%> (-0.39%) ⬇️
go-1.15 87.64% <77.77%> (-1.33%) ⬇️
go-1.16 87.64% <77.77%> (-1.33%) ⬇️
go-1.17 87.64% <77.77%> (-1.33%) ⬇️
go-1.18 88.57% <77.77%> (-0.39%) ⬇️
ubuntu-latest 88.57% <77.77%> (-0.39%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
queue.go 94.21% <77.77%> (-1.08%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ed24fa1...338ee25. Read the comment docs.

Signed-off-by: Bo-Yi Wu <[email protected]>
Signed-off-by: Bo-Yi Wu <[email protected]>
@appleboy appleboy merged commit 03d90b7 into master Apr 20, 2022
@appleboy appleboy deleted the patch branch April 20, 2022 02:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants