Skip to content

Commit

Permalink
cmd/coordinator: display LUCI build results on build dashboards (part 2)
Browse files Browse the repository at this point in the history
This makes the new view on by default. As before, it remains
possible to opt-out via a 'legacyonly=1' URL query parameter.

For golang/go#65913.

Change-Id: I52b0a7e206a1d8bdf4645d4e1f91cadebb446c0e
Reviewed-on: https://go-review.googlesource.com/c/build/+/568195
Reviewed-by: Michael Knyszek <[email protected]>
Reviewed-by: Dmitri Shuralyov <[email protected]>
LUCI-TryBot-Result: Go LUCI <[email protected]>
Auto-Submit: Dmitri Shuralyov <[email protected]>
  • Loading branch information
dmitshur authored and gopherbot committed Feb 29, 2024
1 parent 8eaaf2a commit 253aa5b
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion cmd/coordinator/internal/dashboard/handler.go
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@ type Handler struct {
}

func (d *Handler) ServeHTTP(w http.ResponseWriter, req *http.Request) {
showLUCI, _ := strconv.ParseBool(req.URL.Query().Get("showluci"))
var showLUCI = true
if legacyOnly, _ := strconv.ParseBool(req.URL.Query().Get("legacyonly")); legacyOnly {
showLUCI = false
}
Expand Down
2 changes: 1 addition & 1 deletion cmd/coordinator/internal/legacydash/ui.go
Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,7 @@ func viewForRequest(r *http.Request) (dashboardView, error) {
case "json":
return jsonView{}, nil
case "":
showLUCI, _ := strconv.ParseBool(r.URL.Query().Get("showluci"))
var showLUCI = true
if legacyOnly, _ := strconv.ParseBool(r.URL.Query().Get("legacyonly")); legacyOnly {
showLUCI = false
}
Expand Down

0 comments on commit 253aa5b

Please sign in to comment.