Skip to content
This repository has been archived by the owner on Sep 9, 2020. It is now read-only.

gps: simplify x = x <op> y to x <op>= y #2117

Merged
merged 1 commit into from
Mar 9, 2019
Merged

gps: simplify x = x <op> y to x <op>= y #2117

merged 1 commit into from
Mar 9, 2019

Conversation

kevinburke
Copy link
Collaborator

Simplify x += 1 further to x++.

Already open as #2028 but the fork doesn't exist anymore and I can't push changes to it.

Originally submitted by @quasilyte

@kevinburke kevinburke requested a review from sdboyer as a code owner March 4, 2019 17:40
@googlebot
Copy link
Collaborator

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of all the commit author(s), set the cla label to yes (if enabled on your project), and then merge this pull request when appropriate.

ℹ️ Googlers: Go here for more info.

@kevinburke
Copy link
Collaborator Author

Ah, right, we're not going to be able to merge this until #2114 is fixed.

@googlebot
Copy link
Collaborator

☹️ Sorry, but only Googlers may change the label cla: yes.

@kevinburke
Copy link
Collaborator Author

Appreciate the vote of confidence @jmank88 but the Google CLA bot won't let us merge this PR despite the fact that both contributors have signed the CLA.

@googlebot
Copy link
Collaborator

A Googler has manually verified that the CLAs look good.

(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)

ℹ️ Googlers: Go here for more info.

1 similar comment
@googlebot
Copy link
Collaborator

A Googler has manually verified that the CLAs look good.

(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)

ℹ️ Googlers: Go here for more info.

@googlebot
Copy link
Collaborator

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of all the commit author(s), set the cla label to yes (if enabled on your project), and then merge this pull request when appropriate.

ℹ️ Googlers: Go here for more info.

@googlebot googlebot removed the cla: yes label Mar 9, 2019
@googlebot
Copy link
Collaborator

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of all the commit author(s), set the cla label to yes (if enabled on your project), and then merge this pull request when appropriate.

ℹ️ Googlers: Go here for more info.

Simplify `x += 1` further to `x++`.

This was originally submitted by Iskander Sharipov, who's signed the
CLA, but the CLA bot is not letting me submit on his behalf, so I'm
submitting it.

Signed-off-by: Iskander Sharipov <[email protected]>
@googlebot
Copy link
Collaborator

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

1 similar comment
@googlebot
Copy link
Collaborator

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added cla: yes and removed cla: no labels Mar 9, 2019
@kevinburke kevinburke merged commit 5fc4cc8 into master Mar 9, 2019
@mvdan mvdan deleted the assign-op branch September 4, 2020 15:17
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants