Skip to content

Commit

Permalink
go/types: remove TODOs from API that cannot be changed (cleanup)
Browse files Browse the repository at this point in the history
Change-Id: I4e357a250b2f9cfbf780b05c5f54805682b19a62
Reviewed-on: https://go-review.googlesource.com/83935
Reviewed-by: Matthew Dempsky <[email protected]>
  • Loading branch information
griesemer committed Dec 14, 2017
1 parent 774ae54 commit d0b2467
Showing 1 changed file with 0 additions and 2 deletions.
2 changes: 0 additions & 2 deletions src/go/types/type.go
Original file line number Diff line number Diff line change
Expand Up @@ -418,7 +418,6 @@ func (t *Named) NumMethods() int { return len(t.methods) }
func (t *Named) Method(i int) *Func { return t.methods[i] }

// SetUnderlying sets the underlying type and marks t as complete.
// TODO(gri) determine if there's a better solution rather than providing this function
func (t *Named) SetUnderlying(underlying Type) {
if underlying == nil {
panic("types.Named.SetUnderlying: underlying type must not be nil")
Expand All @@ -430,7 +429,6 @@ func (t *Named) SetUnderlying(underlying Type) {
}

// AddMethod adds method m unless it is already in the method list.
// TODO(gri) find a better solution instead of providing this function
func (t *Named) AddMethod(m *Func) {
if i, _ := lookupMethod(t.methods, m.pkg, m.name); i < 0 {
t.methods = append(t.methods, m)
Expand Down

0 comments on commit d0b2467

Please sign in to comment.