Skip to content

Commit

Permalink
syscall: update comments for x/sys migration
Browse files Browse the repository at this point in the history
The comments in this package state that users should be
migrating code that uses the syscall package to its
corresponding package in x/sys. However, the syscall.Signal
and syscall.Errno types and the syscall.SysProcAttr struct is
not defined in the x/sys package and still need to be referenced
from within syscall.  This adds a change to the comments to
clarify that the migration will need to continue to use some
references to syscall for now.

Fixes #19560

Change-Id: I8abb96b93bea90070ce461da16dc7bcf7b4b29c1
Reviewed-on: https://go-review.googlesource.com/39450
Reviewed-by: Rob Pike <[email protected]>
  • Loading branch information
laboger authored and bradfitz committed Apr 5, 2017
1 parent a7b51cf commit ed2f913
Showing 1 changed file with 4 additions and 1 deletion.
5 changes: 4 additions & 1 deletion src/syscall/syscall.go
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,10 @@
// Go repository should be migrated to use the corresponding
// package in the golang.org/x/sys repository. That is also where updates
// required by new systems or versions should be applied.
// See https://golang.org/s/go1.4-syscall for more information.
// Signal, Errno and SysProcAttr are not yet available in
// golang.org/x/sys and must still be referenced from the
// syscall package. See https://golang.org/s/go1.4-syscall
// for more information.
//
package syscall

Expand Down

0 comments on commit ed2f913

Please sign in to comment.