Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: allow test-only changes in security point releases #18163

Closed
bradfitz opened this issue Dec 2, 2016 · 7 comments
Closed

doc: allow test-only changes in security point releases #18163

bradfitz opened this issue Dec 2, 2016 · 7 comments
Labels
Documentation Issues describing a change to documentation. FrozenDueToAge Proposal-Accepted
Milestone
Unreleased

Comments

@bradfitz
Copy link
Contributor

bradfitz commented Dec 2, 2016

I propose we modify the minor point release policy for security point releases to explicitly allow non-security changes, if the change is only in a test file.

That would have permitted us to bundle a fix to #17276 (see #17276 (comment)) in the latest Go 1.6.4 and Go 1.74 releases. As a result of that bug, many people can't run all.bash because their machines have updated tzdata files, and the time package now fails to pass.
@bradfitz bradfitz added this to the Proposal milestone Dec 2, 2016
@bradfitz bradfitz mentioned this issue Dec 2, 2016
Closed
@minux
Copy link
Member

minux commented Dec 3, 2016 via email

@bradfitz
Copy link
Contributor Author

bradfitz commented Dec 3, 2016

@minux, that would not reduce all the duplicate bug reports we've received, because users would need to know the magic incantation to skip tests, and which to skip.

@bradfitz
Copy link
Contributor Author

bradfitz commented Dec 3, 2016

Duplicate noise so far:

#17276, #17519, #17545, #17808, #17864, #18064, #18188 and counting. (https://github.com/golang/go/issues?utf8=%E2%9C%93&q=is%3Aissue%20TestLoadFixed)

@rsc
Copy link
Contributor

rsc commented Dec 5, 2016

The point of the restrictions is to reduce the risk of introducing a bug. There is no risk of introducing a production bug by editing a *_test.go file. There is some risk of breaking all.bash that might have worked before, but adding a t.Skip will not do that. Seems fine.

Does anyone object to relaxing this to allow updating *_test.go files to fix/skip tests in point releases?

mbland added a commit to mbland/gvm that referenced this issue Dec 12, 2016
@mbland
Add patches for TestLoadFixed issue for 1.4-1.7
d76c5ec 
See: golang/go#17276

Granted, gvm doesn't normally run the tests, but I like to run them to
ensure a build is healthy:

  $ gvm install <some-version>
  $ gvm use <some-version>
  $ go tool dist test -no-rebuild

(Hey, maybe this test step could become a future `gvm install` option?)

Also per golang/go#18163, test fixes may
eventually be permitted for security point releases, at which point
patches like these can possibly go away (since the fix would then be to
use a later point release on affected platforms).
@rsc
Copy link
Contributor

rsc commented Dec 12, 2016

No one seems to object.

@bradfitz bradfitz self-assigned this Dec 12, 2016
@bradfitz bradfitz added the Documentation Issues describing a change to documentation. label Dec 12, 2016
@rsc rsc added Proposal-Accepted and removed Documentation Issues describing a change to documentation. Proposal labels Dec 12, 2016
@bradfitz bradfitz added the Documentation Issues describing a change to documentation. label Dec 12, 2016
@bradfitz bradfitz modified the milestones: Unreleased, Proposal Dec 12, 2016
@rsc
Copy link
Contributor

rsc commented Dec 12, 2016

Leaving to Brad to figure out what the right new prefix (not "proposal:") is.

@bradfitz bradfitz changed the title proposal: allow test-only changes in security point releases doc: allow test-only changes in security point releases Dec 12, 2016
@ALTree ALTree mentioned this issue Jan 2, 2017
Closed
@bradfitz
Copy link
Contributor Author

Updated https://github.com/golang/go/wiki/Go-Release-Cycle#release-maintenance

Closing.

@golang golang locked and limited conversation to collaborators Apr 24, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Documentation Issues describing a change to documentation. FrozenDueToAge Proposal-Accepted
Projects
None yet
Milestone
Unreleased
Development

No branches or pull requests
4 participants
@bradfitz @rsc @minux @gopherbot