-
Notifications
You must be signed in to change notification settings - Fork 17.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cmd/vet: go vet failing in directory with cgo and no tests #24193
Labels
Milestone
Comments
This was introduced in CL cebc706, https://go-review.googlesource.com/87636 |
Change https://golang.org/cl/99175 mentions this issue: |
Reopening for 1.10.1. |
CL 99175 OK for Go 1.10.1 |
Change https://golang.org/cl/102785 mentions this issue: |
gopherbot
pushed a commit
that referenced
this issue
Mar 29, 2018
CgoFiles is not included in GoFiles, so we need to check both. Fixes #24193 Change-Id: I6a67bd912e3d9a4be0eae8fa8db6fa8a07fb5df3 Reviewed-on: https://go-review.googlesource.com/99175 Run-TryBot: Ian Lance Taylor <[email protected]> TryBot-Result: Gobot Gobot <[email protected]> Reviewed-by: Brad Fitzpatrick <[email protected]> Reviewed-on: https://go-review.googlesource.com/102785 Run-TryBot: Andrew Bonventre <[email protected]> Reviewed-by: Ian Lance Taylor <[email protected]>
ajeddeloh
pushed a commit
to ajeddeloh/ignition
that referenced
this issue
Aug 29, 2018
Bump from 1.8, 1.9 to 1.10.4, 1.11. Pin to specifically 1.10.4 since otherwise it implies 1.10.0 which has a go-vet bug which causes failures (see golang/go#24193). Pinning to 1.11.0 doesn't seem to work so leave that as just 1.11.
ajeddeloh
pushed a commit
to ajeddeloh/ignition
that referenced
this issue
Aug 31, 2018
Bump from 1.8, 1.9 to 1.10.4, 1.11. Pin to specifically 1.10.4 since otherwise it implies 1.10.0 which has a go-vet bug which causes failures (see golang/go#24193). Pinning to 1.11.0 doesn't seem to work so leave that as just 1.11.
ajeddeloh
pushed a commit
to ajeddeloh/ignition
that referenced
this issue
Aug 31, 2018
Bump from 1.8, 1.9 to 1.10.4, 1.11. Pin to specifically 1.10.4 since otherwise it implies 1.10.0 which has a go-vet bug which causes failures (see golang/go#24193). Pinning to 1.11.0 doesn't seem to work so leave that as just 1.11.
ajeddeloh
pushed a commit
to ajeddeloh/ignition
that referenced
this issue
Aug 31, 2018
Bump from 1.8, 1.9 to 1.10.4, 1.11. Pin to specifically 1.10.4 since otherwise it implies 1.10.0 which has a go-vet bug which causes failures (see golang/go#24193). Pinning to 1.11.0 doesn't seem to work so leave that as just 1.11.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
Please answer these questions before submitting your issue. Thanks!
What version of Go are you using (
go version
)?go version go1.10 darwin/amd64 on macOS 10.13.3.
Does this issue reproduce with the latest release?
This issue does not happen with 1.9.4, only 1.10.
What operating system and processor architecture are you using (
go env
)?What did you do?
I created a package that uses cgo. In that package, I call a function defined in a
.h
file. Then, I rango vet
on that package.I've created an isolated example at this repo: https://github.com/variadico/vetbug
What did you expect to see?
go vet
should have analyzed the Go source files and reported no errors.What did you see instead?
go vet
failed to run, saying there are no Go source files.The text was updated successfully, but these errors were encountered: