-
Notifications
You must be signed in to change notification settings - Fork 17.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
x/vgo: cannot vgo get golang.org/x/image #25618
Comments
|
What @AlexRouSg said. Closing here, since it doesn't look like a bug. |
Fair enough. I followed instructions in https://github.com/golang/image/blob/master/README.md, which then need updating. |
Change https://golang.org/cl/115675 mentions this issue: |
Thanks for pointing that out @shogsbro - I've filed https://go-review.googlesource.com/#/c/image/+/115675 to address the README problem. |
Further info: $ mkdir vgotest
$ cd vgotest/
$ touch go.mod
$ vi vgotest.go
$ vgo get golang.org/x/image/tiff
vgo get golang.org/x/image/tiff: module root is "golang.org/x/image"
$ vgo get golang.org/x/image
vgo: finding golang.org/x/image v0.0.0-20180403161127-f315e4403028
vgo: downloading golang.org/x/image v0.0.0-20180403161127-f315e4403028
vgo: import "golang.org/x/image" [~/go/src/v/golang.org/x/[email protected]]: no Go source files I can work around this by importing from the Github mirror, but points to adoption issues with |
@shogsbro Instead you can simply rely on
Gives:
|
Eureka, this worked! However, this at least to me is a non-obvious way of doing it. |
@myitcv There's a more specific issue on having no go files on the root dir. #24008 @shogsbro That's the normal vgo workflow actually, so once vgo is stable I expect there to be more docs and instructions on how to do things. Right now you'll have to depend on https://research.swtch.com/vgo and asking around. |
@shogsbro undoubtedly there's more documentation required for vgo (it will follow), particularly in areas where concepts change from the old |
@AlexRouSg - sorry, our messages overlapped there. Yes, there are a number of open issues around |
Thanks to you both for your quick responses & solutions. To clarify, I am using |
@shogsbro I suggest you to post in one of the places listed in https://github.com/golang/go/wiki/Questions if you need more help on vgo. As not only is this a closed issue, the bug tracker is not normally used for discussions. |
The Slack channel But in the absence of good documentation, a stable version of vgo etc, I suspect Russ' original instruction to post issues here (https://research.swtch.com/vgo-tour) remains. Because questions might in fact be issues at this stage. |
Currently the instructions tell the user to: go get -u golang.org/x/image However, this is not valid because golang.org/x/image contains no Go files. Instead it should read: go get -u golang.org/x/image/... Fixes golang/go#25618. Change-Id: I465fac26afdca52878518e4c01d46cf9d12930b9 Reviewed-on: https://go-review.googlesource.com/115675 Reviewed-by: Brad Fitzpatrick <[email protected]>
Currently the instructions tell the user to: go get -u golang.org/x/image However, this is not valid because golang.org/x/image contains no Go files. Instead it should read: go get -u golang.org/x/image/... Fixes golang/go#25618. Change-Id: I465fac26afdca52878518e4c01d46cf9d12930b9 Reviewed-on: https://go-review.googlesource.com/115675 Reviewed-by: Brad Fitzpatrick <[email protected]>
Currently the instructions tell the user to: go get -u golang.org/x/image However, this is not valid because golang.org/x/image contains no Go files. Instead it should read: go get -u golang.org/x/image/... Fixes golang/go#25618. Change-Id: I465fac26afdca52878518e4c01d46cf9d12930b9 Reviewed-on: https://go-review.googlesource.com/115675 Reviewed-by: Brad Fitzpatrick <[email protected]>
Currently the instructions tell the user to: go get -u golang.org/x/image However, this is not valid because golang.org/x/image contains no Go files. Instead it should read: go get -u golang.org/x/image/... Fixes golang/go#25618. Change-Id: I465fac26afdca52878518e4c01d46cf9d12930b9 Reviewed-on: https://go-review.googlesource.com/115675 Reviewed-by: Brad Fitzpatrick <[email protected]>
Currently the instructions tell the user to: go get -u golang.org/x/image However, this is not valid because golang.org/x/image contains no Go files. Instead it should read: go get -u golang.org/x/image/... Fixes golang/go#25618. Change-Id: I465fac26afdca52878518e4c01d46cf9d12930b9 Reviewed-on: https://go-review.googlesource.com/115675 Reviewed-by: Brad Fitzpatrick <[email protected]>
Currently the instructions tell the user to: go get -u golang.org/x/image However, this is not valid because golang.org/x/image contains no Go files. Instead it should read: go get -u golang.org/x/image/... Fixes golang/go#25618. Change-Id: I465fac26afdca52878518e4c01d46cf9d12930b9 Reviewed-on: https://go-review.googlesource.com/115675 Reviewed-by: Brad Fitzpatrick <[email protected]>
Currently the instructions tell the user to: go get -u golang.org/x/image However, this is not valid because golang.org/x/image contains no Go files. Instead it should read: go get -u golang.org/x/image/... Fixes golang/go#25618. Change-Id: I465fac26afdca52878518e4c01d46cf9d12930b9 Reviewed-on: https://go-review.googlesource.com/115675 Reviewed-by: Brad Fitzpatrick <[email protected]>
Currently the instructions tell the user to: go get -u golang.org/x/image However, this is not valid because golang.org/x/image contains no Go files. Instead it should read: go get -u golang.org/x/image/... Fixes golang/go#25618. Change-Id: I465fac26afdca52878518e4c01d46cf9d12930b9 Reviewed-on: https://go-review.googlesource.com/115675 Reviewed-by: Brad Fitzpatrick <[email protected]>
Currently the instructions tell the user to: go get -u golang.org/x/image However, this is not valid because golang.org/x/image contains no Go files. Instead it should read: go get -u golang.org/x/image/... Fixes golang/go#25618. Change-Id: I465fac26afdca52878518e4c01d46cf9d12930b9 Reviewed-on: https://go-review.googlesource.com/115675 Reviewed-by: Brad Fitzpatrick <[email protected]>
Currently the instructions tell the user to: go get -u golang.org/x/image However, this is not valid because golang.org/x/image contains no Go files. Instead it should read: go get -u golang.org/x/image/... Fixes golang/go#25618. Change-Id: I465fac26afdca52878518e4c01d46cf9d12930b9 Reviewed-on: https://go-review.googlesource.com/115675 Reviewed-by: Brad Fitzpatrick <[email protected]>
Please answer these questions before submitting your issue. Thanks!
What version of Go are you using (
go version
)?go version go1.10.2 darwin/amd64
Does this issue reproduce with the latest release?
Yes
What operating system and processor architecture are you using (
go env
)?GOARCH="amd64"
GOBIN="/Users/sigurd/go/bin"
GOCACHE="/Users/sigurd/Library/Caches/go-build"
GOEXE=""
GOHOSTARCH="amd64"
GOHOSTOS="darwin"
GOOS="darwin"
GOPATH="/Users/sigurd/go"
GORACE=""
GOROOT="/usr/local/Cellar/go/1.10.2/libexec"
GOTMPDIR=""
GOTOOLDIR="/usr/local/Cellar/go/1.10.2/libexec/pkg/tool/darwin_amd64"
GCCGO="gccgo"
CC="clang"
CXX="clang++"
CGO_ENABLED="1"
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -m64 -pthread -fno-caret-diagnostics -Qunused-arguments -fmessage-length=0 -fdebug-prefix-map=/var/folders/b7/lntxvqq15dvgfmlhptx_8y_m0000gp/T/go-build399896100=/tmp/go-build -gno-record-gcc-switches -fno-common"
What did you do?
vgo get golang.org/x/image
What did you expect to see?
vgo: finding golang.org/x/image v0.0.0-20180403161127-f315e4403028
vgo: downloading golang.org/x/image v0.0.0-20180403161127-f315e4403028
What did you see instead?
vgo: extracting golang.org/x/image v0.0.0-20180403161127-f315e4403028
vgo: import "golang.org/x/image" [/Users/sigurd/go/src/v/golang.org/x/[email protected]]: no Go source files
The text was updated successfully, but these errors were encountered: