x/crypto/sha3: add Keccak 512 support #29533
Labels
Milestone
Comments
|
Change https://golang.org/cl/156199 mentions this issue: |
|
I already opened a CL 7 months ago https://go-review.googlesource.com/c/crypto/+/125795 |
|
Change https://golang.org/cl/125795 mentions this issue: |
c-expert-zigbee
pushed a commit
to c-expert-zigbee/crypto_go
that referenced
this issue
Mar 28, 2022
Keccak uses a different domain separation byte as the NIST- standardized SHA-3 hashing function. A previous commit to this package added support for Keccak-256, but did not do so for Keccak-512. The reasoning was to support use cases like Ethereum, however Ethereum also uses Keccak-512 for the Ethash PoW, so this second method is also needed. Prev CL: https://go-review.googlesource.com/c/crypto/+/106462 Fixes golang/go#29533 Change-Id: I9d92b1f121657f631c157e5e309771db1cd91c82 Reviewed-on: https://go-review.googlesource.com/c/125795 Reviewed-by: Brad Fitzpatrick <[email protected]>
c-expert-zigbee
pushed a commit
to c-expert-zigbee/crypto_go
that referenced
this issue
Mar 29, 2022
Keccak uses a different domain separation byte as the NIST- standardized SHA-3 hashing function. A previous commit to this package added support for Keccak-256, but did not do so for Keccak-512. The reasoning was to support use cases like Ethereum, however Ethereum also uses Keccak-512 for the Ethash PoW, so this second method is also needed. Prev CL: https://go-review.googlesource.com/c/crypto/+/106462 Fixes golang/go#29533 Change-Id: I9d92b1f121657f631c157e5e309771db1cd91c82 Reviewed-on: https://go-review.googlesource.com/c/125795 Reviewed-by: Brad Fitzpatrick <[email protected]>
c-expert-zigbee
pushed a commit
to c-expert-zigbee/crypto_go
that referenced
this issue
Mar 29, 2022
Keccak uses a different domain separation byte as the NIST- standardized SHA-3 hashing function. A previous commit to this package added support for Keccak-256, but did not do so for Keccak-512. The reasoning was to support use cases like Ethereum, however Ethereum also uses Keccak-512 for the Ethash PoW, so this second method is also needed. Prev CL: https://go-review.googlesource.com/c/crypto/+/106462 Fixes golang/go#29533 Change-Id: I9d92b1f121657f631c157e5e309771db1cd91c82 Reviewed-on: https://go-review.googlesource.com/c/125795 Reviewed-by: Brad Fitzpatrick <[email protected]>
LewiGoddard
pushed a commit
to LewiGoddard/crypto
that referenced
this issue
Feb 16, 2023
Keccak uses a different domain separation byte as the NIST- standardized SHA-3 hashing function. A previous commit to this package added support for Keccak-256, but did not do so for Keccak-512. The reasoning was to support use cases like Ethereum, however Ethereum also uses Keccak-512 for the Ethash PoW, so this second method is also needed. Prev CL: https://go-review.googlesource.com/c/crypto/+/106462 Fixes golang/go#29533 Change-Id: I9d92b1f121657f631c157e5e309771db1cd91c82 Reviewed-on: https://go-review.googlesource.com/c/125795 Reviewed-by: Brad Fitzpatrick <[email protected]>
BiiChris
pushed a commit
to BiiChris/crypto
that referenced
this issue
Sep 15, 2023
Keccak uses a different domain separation byte as the NIST- standardized SHA-3 hashing function. A previous commit to this package added support for Keccak-256, but did not do so for Keccak-512. The reasoning was to support use cases like Ethereum, however Ethereum also uses Keccak-512 for the Ethash PoW, so this second method is also needed. Prev CL: https://go-review.googlesource.com/c/crypto/+/106462 Fixes golang/go#29533 Change-Id: I9d92b1f121657f631c157e5e309771db1cd91c82 Reviewed-on: https://go-review.googlesource.com/c/125795 Reviewed-by: Brad Fitzpatrick <[email protected]>
desdeel2d0m
added a commit
to desdeel2d0m/crypto
that referenced
this issue
Jul 1, 2024
Keccak uses a different domain separation byte as the NIST- standardized SHA-3 hashing function. A previous commit to this package added support for Keccak-256, but did not do so for Keccak-512. The reasoning was to support use cases like Ethereum, however Ethereum also uses Keccak-512 for the Ethash PoW, so this second method is also needed. Prev CL: https://go-review.googlesource.com/c/crypto/+/106462 Fixes golang/go#29533 Change-Id: I9d92b1f121657f631c157e5e309771db1cd91c82 Reviewed-on: https://go-review.googlesource.com/c/125795 Reviewed-by: Brad Fitzpatrick <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
This is an extension of previously accepted proposal #19709 which suggested adding legacy Keccak 256 support.
As mentioned by @karalabe, the 512 variant is also used by Ethereum. I propose adding a new function (
NewLegacyKeccak512) to support it.The text was updated successfully, but these errors were encountered: