-
Notifications
You must be signed in to change notification settings - Fork 17.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
x/mobile/cmd/gobind: doesn't work if vendored because the .java files are not vendored #43736
Comments
It seems the problem is that the java files in Which in turn seems to be a very upvoted issue but closed as wontfix: #26366 I guess vendoring |
This still happens with Go 1.17.6. Is it possible to embed the files with https://pkg.go.dev/embed ? Or are you expecting the behavior of go mod vendor to change in the future? |
I don't think the root cause is #26366 (related but not the direct cause). Can you please show us how github.com/DataDog/datadog-agent specifies dependency on golang.org/x/mobile currently? |
Change https://golang.org/cl/377754 mentions this issue: |
I sent a cl that spells out the implicit dependencies in the tools' source code (cl/377754), but the current best practice (especially for |
cmd/gomobile depends on cmd/gobind. Code generated by cmd/gobind depends on packages under golang.org/x/mobile/bind. Explicitly list those (with build tags) so the go command can take into account these implicit dependencies (e.g. go mod tidy or go mod vendor). We use tag `mobile_implicit`. Updates golang/go#43736 Change-Id: I09c519556ffe8e8c4db0754571c5173b1613c210 Reviewed-on: https://go-review.googlesource.com/c/mobile/+/377754 Trust: Hyang-Ah Hana Kim <[email protected]> Run-TryBot: Hyang-Ah Hana Kim <[email protected]> TryBot-Result: Gopher Robot <[email protected]> Reviewed-by: Bryan Mills <[email protected]>
This should be fixed at
|
What version of Go are you using (
go version
)?Also happens with 1.14
Does this issue reproduce with the latest release?
Yes.
What operating system and processor architecture are you using (
go env
)?go env
OutputWhat did you do?
gobind
is the last version: v0.0.0-20201217150744-e6ae53a27f4f. Also fails if I usego run golang.org/x/mobile/cmd/gobind
instead of using the installed version.The text was updated successfully, but these errors were encountered: