x/tools/gopls/internal/regtest: Test_Issue38211 is flaky #44098
Assignees
Labels
FrozenDueToAge
gopls
Issues related to the Go language server, gopls.
NeedsInvestigation
Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Tools
This label describes issues relating to any tools in the x/tools repository.
Milestone
Comments
gopherbot
added
Tools
findleyr
changed the title
|
Thank you for the research @bcmills! |
|
Change https://golang.org/cl/291232 mentions this issue: |
|
Change https://golang.org/cl/363614 mentions this issue: |
bcmills
added
the
NeedsInvestigation
gopherbot
pushed a commit
to golang/tools
that referenced
this issue
Nov 12, 2021
This test has a high failure rate on the builders. Adding a skip until it is fixed so that we will more easily notice other regressions. For golang/go#44098 Change-Id: I8dcd6b205a5a7876d2a16c54f3c19c1bb0397843 Reviewed-on: https://go-review.googlesource.com/c/tools/+/363614 Trust: Bryan C. Mills <[email protected]> Run-TryBot: Bryan C. Mills <[email protected]> gopls-CI: kokoro <[email protected]> Reviewed-by: Robert Findley <[email protected]> TryBot-Result: Go Bot <[email protected]>
8 tasks
|
Change https://go.dev/cl/418898 mentions this issue: |
gopherbot
pushed a commit
to golang/tools
that referenced
this issue
Jul 25, 2022
This test was originally skipped due to deadline exceeded errors. In the time since, we've made performance improvements, fixed races, and altered the regtests to remove arbitrary deadlines. Unskip it to see if it still flakes. For golang/go#44098 For golang/go#53878 Change-Id: I06530f2bc9c6883f415dc9147cfcbf260abb2a00 Reviewed-on: https://go-review.googlesource.com/c/tools/+/418898 Run-TryBot: Robert Findley <[email protected]> gopls-CI: kokoro <[email protected]> TryBot-Result: Gopher Robot <[email protected]> Reviewed-by: Bryan Mills <[email protected]>
|
Aha! The new flake is not the same as the old flake. I had just made a dear-diary TODO about this! |
|
Change https://go.dev/cl/419502 mentions this issue: |
gopherbot
pushed a commit
to golang/tools
that referenced
this issue
Jul 29, 2022
Fix a tricky race in gopls/internal/regtest/diagnostics.Test_Issue38211: When reloading the workspace, we can encounter context cancellation if the snapshot is cancelled, and can write this cancellation as a critical error *before* the context is cloned, leading to a state where there is a critical error that won't go away. This should resolve test flakes reported in golang/go#44098. For golang/go#44098 Change-Id: I41c0f49b2fe999131f4c31166e69b2cde85470b7 Reviewed-on: https://go-review.googlesource.com/c/tools/+/419502 gopls-CI: kokoro <[email protected]> TryBot-Result: Gopher Robot <[email protected]> Run-TryBot: Robert Findley <[email protected]> Reviewed-by: Bryan Mills <[email protected]>
|
I'm optimistic that CL 419502 fixes. If no flakes in one week, let's close. |
No failures since that CL, so I'll close now. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Recent example:
freebsd-amd64-12_0: https://build.golang.org/log/3b09d544e27e063edc32baadd6008e204ec1d5e5
...which looks like a race. This may be a recent flake, or at least it started flaking more often recently. #44035 might provide a fix, but filing this issue to track the de-flaking of this test.
CC @heschik @stamblerre
The text was updated successfully, but these errors were encountered: