Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/go: "malformed import path" in Go 1.16 for packages with path elements containing a leading dot [1.16 backport] #44647

Closed
gopherbot opened this issue Feb 26, 2021 · 4 comments
Closed

cmd/go: "malformed import path" in Go 1.16 for packages with path elements containing a leading dot [1.16 backport] #44647

gopherbot opened this issue Feb 26, 2021 · 4 comments
Labels
CherryPickApproved Used during the release process for point releases FrozenDueToAge release-blocker
Milestone
Go1.16.2

Comments

@gopherbot
Copy link
Contributor

@jayconrod requested issue #43985 to be considered for backport to the next 1.16 minor release.

@gopherbot Please backport to 1.16.
@gopherbot gopherbot added the CherryPickCandidate Used during the release process for point releases label Feb 26, 2021
@gopherbot gopherbot mentioned this issue Feb 26, 2021
Closed
@gopherbot gopherbot added this to the Go1.16.1 milestone Feb 26, 2021
@dmitshur
Copy link
Contributor

dmitshur commented Mar 1, 2021

Approving as a serious issue without a workaround. Only Go 1.16 needs this backport.

@dmitshur dmitshur added CherryPickApproved Used during the release process for point releases and removed CherryPickCandidate Used during the release process for point releases labels Mar 1, 2021
@gopherbot
Copy link
Contributor Author

Change https://golang.org/cl/297912 mentions this issue: [release-branch.go1.16] cmd: upgrade golang.org/x/mod to relax import path check

@gopherbot
Copy link
Contributor Author

Change https://golang.org/cl/298009 mentions this issue: [internal-branch.go1.16-vendor] module: allow leading dots in import path elements

gopherbot pushed a commit to golang/mod that referenced this issue Mar 2, 2021
@dmitshur
[internal-branch.go1.16-vendor] module: allow leading dots in import …
d515b24 
…path elements

These were always disallowed, but the restriction wasn't enforced in
most cases until Go 1.16. That's broken more projects than we hoped.

This change allows leading dots in import path elements. Leading dots
are still not allowed in module path elements. Leading dots were
always allowed in file path elements. Trailing dots are still
forbidden in all cases.

For golang/go#44647

Change-Id: Id9cf728a341931565ab9e81f600b2341aa178683
Reviewed-on: https://go-review.googlesource.com/c/mod/+/297089
Trust: Jay Conrod <[email protected]>
Run-TryBot: Jay Conrod <[email protected]>
TryBot-Result: Go Bot <[email protected]>
Reviewed-by: Bryan C. Mills <[email protected]>
(cherry picked from commit c8bb1bd)
Reviewed-on: https://go-review.googlesource.com/c/mod/+/298009
Reviewed-by: Dmitri Shuralyov <[email protected]>
gopherbot pushed a commit that referenced this issue Mar 3, 2021
@dmitshur
[release-branch.go1.16] cmd: upgrade golang.org/x/mod to relax import…
3068d55 
… path check

This incorporates CL 298009, which allows leading dots in import path
elements but not module path elements. Also added a test.

Fixes #44647
Updates #34992

Change-Id: I2d5faabd8f7b23a7943d3f3ccb6707ab5dc2ce3c
Reviewed-on: https://go-review.googlesource.com/c/go/+/297530
Trust: Jay Conrod <[email protected]>
Run-TryBot: Jay Conrod <[email protected]>
TryBot-Result: Go Bot <[email protected]>
Reviewed-by: Bryan C. Mills <[email protected]>
(cherry picked from commit 97bdac0)
Reviewed-on: https://go-review.googlesource.com/c/go/+/297912
Reviewed-by: Dmitri Shuralyov <[email protected]>
@gopherbot
Copy link
Contributor Author

Closed by merging 3068d55 to release-branch.go1.16.

@toothrot toothrot modified the milestones: Go1.16.1, Go1.16.2 Mar 10, 2021
@golang golang locked and limited conversation to collaborators Mar 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
CherryPickApproved Used during the release process for point releases FrozenDueToAge release-blocker
Projects
None yet
Milestone
Go1.16.2
Development

No branches or pull requests
3 participants
@toothrot @dmitshur @gopherbot