Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/tools: remove usage of golang.org/x/xerrors (cleanup) #52442

Closed
findleyr opened this issue Apr 19, 2022 · 5 comments
Closed

x/tools: remove usage of golang.org/x/xerrors (cleanup) #52442

findleyr opened this issue Apr 19, 2022 · 5 comments
Labels
FrozenDueToAge Tools This label describes issues relating to any tools in the x/tools repository.
Milestone
Unreleased

Comments

@findleyr
Copy link
Member

findleyr commented Apr 19, 2022 •
edited
Loading

As of #50827, we no longer support building gopls at Go 1.12.

We should remove usage of golang.org/x/xerrors from x/tools.

CC @golang/tools-team
@gopherbot gopherbot added the Tools This label describes issues relating to any tools in the x/tools repository. label Apr 19, 2022
@gopherbot gopherbot added this to the Unreleased milestone Apr 19, 2022
@findleyr findleyr changed the title x/tools: remove usage of xerrors (cleanup) x/tools: remove usage of golang.org/x/xerrors (cleanup) Apr 19, 2022
@gopherbot
Copy link
Contributor

Change https://go.dev/cl/401097 mentions this issue: gopls: remove usage of xerrors from the gopls codebase

@gopherbot
Copy link
Contributor

Change https://go.dev/cl/401155 mentions this issue: internal/jsonrpc2*: remove usage of golang.org/x/xerrors

@gopherbot
Copy link
Contributor

Change https://go.dev/cl/401099 mentions this issue: x/tools: remove dependency on golang.org/x/xerrors

@gopherbot
Copy link
Contributor

Change https://go.dev/cl/401154 mentions this issue: go/packages: remove usage of golang.org/x/xerrors

@gopherbot
Copy link
Contributor

Change https://go.dev/cl/401098 mentions this issue: cmd/godoc: remove usage of golang.org/x/xerrors

gopherbot pushed a commit to golang/tools that referenced this issue Apr 20, 2022
@findleyr
gopls: remove usage of golang.org/x/xerrors
37590b3 
As of golang/go#50827, gopls no longer supports building at 1.12, and so
usage of golang.org/x/xerrors can be replaced with the native support for
error wrapping introduced in Go 1.13.

Remove this usage as a step toward eliminating the xerrors dependency
from x/tools.

For golang/go#52442

Change-Id: Ibf459cc72402a30a6c2735dc620f76ed8a5e2525
Reviewed-on: https://go-review.googlesource.com/c/tools/+/401097
Run-TryBot: Robert Findley <[email protected]>
gopls-CI: kokoro <[email protected]>
TryBot-Result: Gopher Robot <[email protected]>
Reviewed-by: Ian Lance Taylor <[email protected]>
gopherbot pushed a commit to golang/tools that referenced this issue Apr 20, 2022
@findleyr
go/packages: remove usage of golang.org/x/xerrors
bcfc38f 
As of golang/go#50827, gopls no longer needs to build at Go 1.12. I
believe this was the only reason to continue using xerrors in
go/packages.

Remove this usage as a step toward eliminating the xerrors dependency
from x/tools.

For golang/go#52442

Change-Id: I8f7396491be58606be6a648ebbf2180bdbc907b5
Reviewed-on: https://go-review.googlesource.com/c/tools/+/401154
Run-TryBot: Robert Findley <[email protected]>
gopls-CI: kokoro <[email protected]>
TryBot-Result: Gopher Robot <[email protected]>
Reviewed-by: Ian Lance Taylor <[email protected]>
Reviewed-by: Ian Lance Taylor <[email protected]>
gopherbot pushed a commit to golang/tools that referenced this issue Apr 20, 2022
@findleyr
internal/jsonrpc2*: remove usage of golang.org/x/xerrors
b22f048 
As of golang/go#50827, gopls no longer needs to build at Go 1.12. This
was the only reason to continue using xerrors in the jsonrpc2 libraries.

Remove this usage as a step toward eliminating the xerrors dependency
from x/tools.

For golang/go#52442

Change-Id: I1a0a1bbf57e6606c66b99b27439adf6f65c26a60
Reviewed-on: https://go-review.googlesource.com/c/tools/+/401155
Run-TryBot: Robert Findley <[email protected]>
gopls-CI: kokoro <[email protected]>
TryBot-Result: Gopher Robot <[email protected]>
Reviewed-by: Ian Lance Taylor <[email protected]>
Reviewed-by: Bryan Mills <[email protected]>
gopherbot pushed a commit to golang/tools that referenced this issue Apr 20, 2022
@findleyr
cmd/godoc: remove usage of golang.org/x/xerrors
235b13d 
Go 1.12 has not been supported for a while, so it seems safe to replace
usage of xerrors with the native support for wrapped errors in the
standard library introduced in Go 1.13. Remove this usage as a step
toward eliminating the xerrors dependency from x/tools.

If there is any reason to continue to use xerrors, please let me know.

For golang/go#52442

Change-Id: Ic1e5c14f4074b4685a926e884649b9032aaa0f53
Reviewed-on: https://go-review.googlesource.com/c/tools/+/401098
Run-TryBot: Robert Findley <[email protected]>
gopls-CI: kokoro <[email protected]>
TryBot-Result: Gopher Robot <[email protected]>
Reviewed-by: Ian Lance Taylor <[email protected]>
@golang golang locked and limited conversation to collaborators Apr 20, 2023
apstndb pushed a commit to apstndb/gotoolsdiff that referenced this issue Jan 11, 2025
@findleyr
x/tools: remove dependency on golang.org/x/xerrors
8ab77e6 
Now that golang.org/x/xerrors is no longer used, we can eliminate it as
a dependency. Also update x/mod to eliminate an indirect dependency on
x/xerrors.

Fixes golang/go#52442

Change-Id: Ia3087a64e70f132f2813aa28d28d8397e5ecfded
Reviewed-on: https://go-review.googlesource.com/c/tools/+/401099
Run-TryBot: Robert Findley <[email protected]>
Reviewed-by: Ian Lance Taylor <[email protected]>
gopls-CI: kokoro <[email protected]>
TryBot-Result: Gopher Robot <[email protected]>
Reviewed-by: Bryan Mills <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge Tools This label describes issues relating to any tools in the x/tools repository.
Projects
None yet
Milestone
Unreleased
Development

No branches or pull requests
2 participants
@gopherbot @findleyr