Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/build: android-.*-emu builder failures with adb: error: connect failed: closed #52724

Open
bcmills opened this issue May 5, 2022 · 4 comments
Open

x/build: android-.*-emu builder failures with adb: error: connect failed: closed #52724

bcmills opened this issue May 5, 2022 · 4 comments
Labels
Builders x/build issues (builders, bots, dashboards) NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. OS-Android
Milestone
Backlog

Comments

@bcmills
Copy link
Contributor

bcmills commented May 5, 2022 •
edited
Loading 

#!watchflakes
post <- builder ~ `android-.*` && log ~ `adb: error: connect failed: closed`

adb push /workdir/tmp/go_android_exec-cmd-go-3350234747 /data/local/tmp/go_android_exec/goroot/bin/go
adb: error: connect failed: closed
go_android_exec: exit status 1
FAIL	golang.org/x/benchmarks/cmd/bent	27.763s

greplogs -l -e 'adb: error: connect failed: closed'
2022-05-04T20:30:17-39d8c21-e1e056f/android-amd64-emu
2022-03-18T06:03:39-0e9765c-3d19e8d/android-386-emu
2021-10-18T21:21:54-ffe10e5-6c0daa7/android-amd64-emu
2021-03-26T06:03:03-6b15177-9c7463c/android-amd64-emu

(attn @golang/android)
@gopherbot gopherbot added the Builders x/build issues (builders, bots, dashboards) label May 5, 2022
@gopherbot gopherbot added this to the Unreleased milestone May 5, 2022
@bcmills bcmills modified the milestones: Unreleased, Backlog May 5, 2022
@heschi heschi added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label May 9, 2022
@bcmills bcmills mentioned this issue Jun 14, 2022
Closed
@bcmills
Copy link
Contributor Author

bcmills commented Jun 14, 2022

Since this only affects the -emu builders, I wonder if this is a defect in the emulator itself.

Perhaps the builder image should be updated with a more recent emulator, or the bug should be escalated to the Android emulator developers?

@bcmills
Copy link
Contributor Author

bcmills commented Jun 14, 2022

FWIW, it looks like our go_android_exec wrapper explicitly waits for the emulator to boot:
https://cs.opensource.google/go/go/+/master:misc/android/go_android_exec.go;l=94-99;drc=98f3d7fecbb8a9074f5f4ffc50bb016e194940b7

@gopherbot
Copy link
Contributor

Change https://go.dev/cl/412174 mentions this issue: dashboard: add known issues for android-*-emu

gopherbot pushed a commit to golang/build that referenced this issue Jun 14, 2022
dashboard: add known issues for android-*-emu
a8033b3 
Issue golang/go#42212 manifests as test timeouts, and is by far the most
frequent of these known issues.

Issue golang/go#51001 causes failures with "systemstack called from unexpected
goroutine". It seems to have been introduced sometime last year, but
it isn't clear to me whether it is a regression or an older (latent)
bug unearthed by some other change.

Issue golang/go#52724 appears to be a bug or race in the Android emulator
itself. It might require a builder image update and/or escalation to
the maintainers of the emulator proper.

Updates golang/go#53377.

Change-Id: I677915b1ff02dd02e0f14c63b0d25caf11e27a72
Reviewed-on: https://go-review.googlesource.com/c/build/+/412174
Reviewed-by: David Chase <[email protected]>
TryBot-Result: Gopher Robot <[email protected]>
Run-TryBot: Bryan Mills <[email protected]>
@gopherbot
Copy link
Contributor

Change https://go.dev/cl/465156 mentions this issue: dashboard: unmark known-issues with low failure rates

gopherbot pushed a commit to golang/build that referenced this issue Feb 4, 2023
@gopherbot
dashboard: unmark known-issues with low failure rates
20ebdbd 
I had initially added known issues fairly aggressively in order to use
them to reduce noise in 'greplogs -triage'. Now that we are using
'watchflakes' for triage, that noise reduction is no longer important
(the failures are already clustered to their respective known issues),
and having greyed-out cells on the dashboard makes new regressions too
easy to miss.

Concretely:

- golang/go#42212 is mostly specific to x/net at this point (as
  golang/go#57841)

- There have been no failures matching golang/go#51001 since October.

- golang/go#52724 has been so rare lately that we hadn't yet added a
  'watchflakes' pattern for it.

- There have been no failures matching golang/go#51443 since May.

- There have been no failures matching golang/go#53116 or
  golang/go#53093 since I enabled 'watchflakes' for the builder in
  December.

- The linux-amd64-perf builder seems to be passing consistently for
  x/benchmarks and x/tools, so there is no need to refer to
  golang/go#53538 to explain failures on it.

Change-Id: Ia16db2a23e5fa037a299f1f56fb26f1cf84521e1
Reviewed-on: https://go-review.googlesource.com/c/build/+/465156
Reviewed-by: Dmitri Shuralyov <[email protected]>
Reviewed-by: Dmitri Shuralyov <[email protected]>
Run-TryBot: Bryan Mills <[email protected]>
Auto-Submit: Bryan Mills <[email protected]>
TryBot-Result: Gopher Robot <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Builders x/build issues (builders, bots, dashboards) NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. OS-Android
Projects
Test Flakes
Status: No status
Milestone
Backlog
Development

No branches or pull requests
3 participants
@bcmills @gopherbot @heschi