Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: all.bash missing bootstrap message: Set $GOROOT_BOOTSTRAP to a working Go tree >= Go 1.4 instead of Go 1.17. #54301

Closed
laboger opened this issue Aug 5, 2022 · 2 comments
Closed

build: all.bash missing bootstrap message: Set $GOROOT_BOOTSTRAP to a working Go tree >= Go 1.4 instead of Go 1.17. #54301

laboger opened this issue Aug 5, 2022 · 2 comments
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Milestone
Go1.20

Comments

@laboger
Copy link
Contributor

laboger commented Aug 5, 2022

If I'm on a system without Go installed and I forget to set GOROOT_BOOTSTRAP before ./make.bash or ./all.bash, I see this:

./all.bash
ERROR: Cannot find /home/boger/go1.4/bin/go.
Set $GOROOT_BOOTSTRAP to a working Go tree >= Go 1.4.

With the recent changes to require Go 1.17 for the bootstrap, this error message should be updated.
@seankhliao seankhliao changed the title cmd/go: missing bootstrap compiler message says: Set $GOROOT_BOOTSTRAP to a working Go tree >= Go 1.4 instead of Go 1.17. build: all.bash missing bootstrap message: Set $GOROOT_BOOTSTRAP to a working Go tree >= Go 1.4 instead of Go 1.17. Aug 5, 2022
@seankhliao seankhliao added the NeedsFix The path to resolution is known, but the work has not been done. label Aug 5, 2022
cuiweixie added a commit to cuiweixie/go that referenced this issue Aug 6, 2022
@cuiweixie
build: GOROOT_BOOTSTRAP from 1.4 to 1.17
87b4dc1 
Fixes golang#54301
@cuiweixie cuiweixie mentioned this issue Aug 6, 2022
Closed
@gopherbot
Copy link
Contributor

Change https://go.dev/cl/421834 mentions this issue: build: GOROOT_BOOTSTRAP from 1.4 to 1.17

@dmitshur dmitshur added this to the Go1.20 milestone Aug 6, 2022
cuiweixie added a commit to cuiweixie/go that referenced this issue Aug 11, 2022
@cuiweixie
build: default GOROOT_BOOTSTRAP in make.{bash,bat} error msg from 1.4…
3d91c31 
… to 1.17

Fixes golang#54301
cuiweixie added a commit to cuiweixie/go that referenced this issue Aug 11, 2022
@cuiweixie
build: default GOROOT_BOOTSTRAP in make.{bash,bat} error msg from 1.4…
fcc48f5 
… to 1.17

Fixes golang#54301
cuiweixie added a commit to cuiweixie/go that referenced this issue Aug 11, 2022
@cuiweixie
build: default GOROOT_BOOTSTRAP in make.{bash,bat} error msg from 1.4…
eff1a38 
… to 1.17

Fixes golang#54301
cuiweixie added a commit to cuiweixie/go that referenced this issue Aug 11, 2022
@cuiweixie
build: default GOROOT_BOOTSTRAP in make.{bash,bat} error msg from 1.4…
cd2bc60 
… to 1.17

Fixes golang#54301
@gopherbot
Copy link
Contributor

Change https://go.dev/cl/423354 mentions this issue: build: update comments about Go 1.4 in make.bash, make.bat, make.rc

@golang golang locked and limited conversation to collaborators Aug 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Projects
None yet
Milestone
Go1.20
Development

Successfully merging a pull request may close this issue.

build: default GOROOT_BOOTSTRAP in make.{bash,bat} error msg from 1.4 to 1.17 cuiweixie/go
4 participants
@dmitshur @gopherbot @laboger @seankhliao