Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/tools/gopls: release version v0.9.5 #54842

Closed
8 of 9 tasks
findleyr opened this issue Sep 2, 2022 · 5 comments
Closed
8 of 9 tasks

x/tools/gopls: release version v0.9.5 #54842

findleyr opened this issue Sep 2, 2022 · 5 comments
Labels
FrozenDueToAge gopls Issues related to the Go language server, gopls. Tools This label describes issues relating to any tools in the x/tools repository.
Milestone
gopls/v0.9.5

Comments

@findleyr
Copy link
Member

findleyr commented Sep 2, 2022 •
edited
Loading

This issue tracks progress toward releasing [email protected]

  • cherry-pick into gopls-release-branch.0.9
  • update hard-coded version
  • update go.mod/go.sum (remove x/tools replace, update x/tools version)
  • tag gopls/v0.9.5-pre.1
  • update Github milestone
  • write release notes
  • smoke test features
  • tag gopls/v0.9.5
  • update dependencies in master for the next release
@findleyr findleyr added this to the gopls/v0.9.5 milestone Sep 2, 2022
@gopherbot gopherbot added Tools This label describes issues relating to any tools in the x/tools repository. gopls Issues related to the Go language server, gopls. labels Sep 2, 2022
@gopherbot
Copy link
Contributor

Change https://go.dev/cl/427904 mentions this issue: gopls: add back x/tools replace directive

gopherbot pushed a commit to golang/tools that referenced this issue Sep 6, 2022
@findleyr @mdempsky @adonovan
[gopls-release-branch.0.9] gopls: squash CLs to fix broken tests
cad55b2 
This CL squashes the following commits from master, to fix broken lsp
tests due to error message and parser recovery changes for 1.20.

In order of submission:
 - CL 425362 (mdempsky): call Interface.Complete in unified importer
 - CL 425497 (gri): disable a test so we can change the parser error
 - CL 425956 (adonovan): support regular expressions in Diagnostics
   tests
 - CL 425594 (gri): re-enable a test with adjusted error message
 - CL 427654 (gri): disable some tests for std lib changes
 - CL 427736 (gri): handle new error message
 - CL 428054 (gri): disable some tests for std lib changes
 - CL 428055 (gri): use regexp to match wanted result

Also: add back the x/tools replace directive to gopls/go.mod, so that
tests will pass. It will be removed in a subsequent CL.

For golang/go#54842

Co-authored-by: Matthew Dempsky <[email protected]>
Co-authored-by: Robert Griesemer <[email protected]>
Co-authored-by: Alan Donovan <[email protected]>
Change-Id: I125b9c3fe23de8eb2e130f32b1b7b65b2885e0e2
Reviewed-on: https://go-review.googlesource.com/c/tools/+/427904
Reviewed-by: Hyang-Ah Hana Kim <[email protected]>
TryBot-Result: Gopher Robot <[email protected]>
Run-TryBot: Robert Findley <[email protected]>
@gopherbot
Copy link
Contributor

Change https://go.dev/cl/428596 mentions this issue: [gopls-release-branch.0.9] internal/lsp/cache: clear shouldLoad IDs on load

gopherbot pushed a commit to golang/tools that referenced this issue Sep 6, 2022
@findleyr
[gopls-release-branch.0.9] internal/lsp/cache: clear shouldLoad IDs o…
9321060 
…n load

CL 417576 externalized shouldLoad tracking into a map, which was used to
trigger a reload and cleared once reload completes. Unfortunately, it
overlooked the fact that we may also reload the entire workspace (via
reinitialization). In this case, we should clear newly loaded IDs from
the shouldLoad map, so that they are not subsequently loaded again.

For golang/go#54842
Updates golang/go#54473

Change-Id: I26f49552cae502644142dc4a4e946294db37f6f7
Reviewed-on: https://go-review.googlesource.com/c/tools/+/424074
Run-TryBot: Robert Findley <[email protected]>
TryBot-Result: Gopher Robot <[email protected]>
Reviewed-by: Alan Donovan <[email protected]>
gopls-CI: kokoro <[email protected]>
(cherry picked from commit e55fb40)
Reviewed-on: https://go-review.googlesource.com/c/tools/+/428596
Reviewed-by: Hyang-Ah Hana Kim <[email protected]>
@gopherbot
Copy link
Contributor

Change https://go.dev/cl/428597 mentions this issue: internal/lsp/debug: update hard-coded version for v0.9.5

gopherbot pushed a commit to golang/tools that referenced this issue Sep 6, 2022
@findleyr
internal/lsp/debug: update hard-coded version for v0.9.5
093c8a7 
For golang/go#54842

Change-Id: I7382b86d1dce34a57631a6276335fded2f42cf1a
Reviewed-on: https://go-review.googlesource.com/c/tools/+/428597
Run-TryBot: Robert Findley <[email protected]>
Reviewed-by: Hyang-Ah Hana Kim <[email protected]>
Reviewed-by: Nooras Saba‎ <[email protected]>
gopls-CI: kokoro <[email protected]>
TryBot-Result: Gopher Robot <[email protected]>
@gopherbot
Copy link
Contributor

Change https://go.dev/cl/428598 mentions this issue: gopls: update go.mod for v0.9.5

gopherbot pushed a commit to golang/tools that referenced this issue Sep 6, 2022
@findleyr @hyangah
gopls: update go.mod for v0.9.5
58b9e2e 
Remove the replace directive and update x/tools.

For golang/go#54842

Change-Id: Ie68524bd64e8065702c75a3125c4239310f446c5
Reviewed-on: https://go-review.googlesource.com/c/tools/+/428598
gopls-CI: kokoro <[email protected]>
Reviewed-by: Nooras Saba‎ <[email protected]>
Run-TryBot: Robert Findley <[email protected]>
TryBot-Result: Gopher Robot <[email protected]>
@gopherbot
Copy link
Contributor

Change https://go.dev/cl/429516 mentions this issue: [gopls-release-branch.0.9] gopls: use golang.org/x/tools@ce397412b6a4

gopherbot pushed a commit to golang/tools that referenced this issue Sep 8, 2022
@hyangah
[gopls-release-branch.0.9] gopls: use golang.org/x/tools@ce397412b6a4
8a9de1b 
That includes the fix reviewed in https://go.dev/cl/429515

Remove the replace statement again for release.

For golang/go#54842

Change-Id: I80e9f98eadff82eee7d6d82b8a6a4c30ee108ac7
Reviewed-on: https://go-review.googlesource.com/c/tools/+/429516
Run-TryBot: Hyang-Ah Hana Kim <[email protected]>
TryBot-Result: Gopher Robot <[email protected]>
Reviewed-by: Robert Findley <[email protected]>
gopls-CI: kokoro <[email protected]>
@findleyr findleyr closed this as completed Sep 8, 2022
@golang golang locked and limited conversation to collaborators Sep 8, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge gopls Issues related to the Go language server, gopls. Tools This label describes issues relating to any tools in the x/tools repository.
Projects
None yet
Milestone
gopls/v0.9.5
Development

No branches or pull requests
2 participants
@gopherbot @findleyr