Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/tools/gopls/internal/regtest/marker: TestMarkers failing on android builders at Go 1.20 and above #58396

Closed
gopherbot opened this issue Feb 7, 2023 · 9 comments
Closed

x/tools/gopls/internal/regtest/marker: TestMarkers failing on android builders at Go 1.20 and above #58396

gopherbot opened this issue Feb 7, 2023 · 9 comments
Labels
FrozenDueToAge gopls Issues related to the Go language server, gopls. mobile Android, iOS, and x/mobile NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. Testing An issue that has been verified to require only test changes, not just a test failure. Tools This label describes issues relating to any tools in the x/tools repository.
Milestone
gopls/v0.12.0

Comments

@gopherbot
Copy link
Contributor

gopherbot commented Feb 7, 2023 •
edited by bcmills
Loading 

#!watchflakes
post <- pkg == "golang.org/x/tools/gopls/internal/regtest/marker" && test == "TestMarkers" && goos == "android" && date < "2023-05-01"

Issue created automatically to collect these failures.

Example (log):

--- FAIL: TestMarkers (4.32s)
    --- FAIL: TestMarkers/definition/embed.txt (0.74s)
        marker.go:884: b/b.go:13:4-6 (definition/embed.txt:51:4-6): definition location does not match:
            	got: <missing location>
            	want a/a.go:5:12-14 (definition/embed.txt:11:12-14)
        marker.go:895: b/b.go:13:4-6 (definition/embed.txt:51:4-6): hover location does not match:
            	got: <missing location>
            	want b/b.go:13:4-6 (definition/embed.txt:51:4-6))
        marker.go:911: b/b.go:13:4-6 (definition/embed.txt:51:4-6): hover markdown mismatch (-want +got):
            --- want
...
    --- FAIL: TestMarkers/definition/import.txt (0.37s)
        marker.go:911: bar/dotimport.go:7:6-7 (definition/import.txt:28:6-7): hover markdown mismatch (-want +got):
            --- want
            +++ got
            @@ -1,5 +1,5 @@
             ```go
            -var _ Foo
            +var _ invalid type
             ```

...
            -
            -
            -[`(types.TypeName).Name` on pkg.go.dev](https://pkg.go.dev/go/types#TypeName.Name)
            +

        marker.go:328: go.mod:1:1-15 (hover/std.txt:14:1-15): unexpected diagnostic: "packages.Load error: err: exit status 2: stderr: go: no such tool \"compile\""
        marker.go:328: std.go:4:2-7 (hover/std.txt:21:2-7): unexpected diagnostic: "could not import fmt (missing metadata for import of \"fmt\")"
        marker.go:328: std.go:5:2-12 (hover/std.txt:22:2-12): unexpected diagnostic: "could not import go/types (missing metadata for import of \"go/types\")"
        marker.go:328: std.go:6:2-8 (hover/std.txt:23:2-8): unexpected diagnostic: "could not import sync (missing metadata for import of \"sync\")"
exitcode=1

— watchflakes
@gopherbot gopherbot added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Feb 7, 2023
@gopherbot
Copy link
Contributor Author

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "golang.org/x/tools/gopls/internal/regtest/marker" && test == "TestMarkers"
2023-02-07 20:55 android-386-emu tools@ebad375b go@9565d990 x/tools/gopls/internal/regtest/marker.TestMarkers (log) 
--- FAIL: TestMarkers (4.32s)
    --- FAIL: TestMarkers/definition/embed.txt (0.74s)
        marker.go:884: b/b.go:13:4-6 (definition/embed.txt:51:4-6): definition location does not match:
            	got: <missing location>
            	want a/a.go:5:12-14 (definition/embed.txt:11:12-14)
        marker.go:895: b/b.go:13:4-6 (definition/embed.txt:51:4-6): hover location does not match:
            	got: <missing location>
            	want b/b.go:13:4-6 (definition/embed.txt:51:4-6))
        marker.go:911: b/b.go:13:4-6 (definition/embed.txt:51:4-6): hover markdown mismatch (-want +got):
            --- want
...
    --- FAIL: TestMarkers/definition/import.txt (0.37s)
        marker.go:911: bar/dotimport.go:7:6-7 (definition/import.txt:28:6-7): hover markdown mismatch (-want +got):
            --- want
            +++ got
            @@ -1,5 +1,5 @@
             ```go
            -var _ Foo
            +var _ invalid type
             ```

...
            -
            -
            -[`(types.TypeName).Name` on pkg.go.dev](https://pkg.go.dev/go/types#TypeName.Name)
            +

        marker.go:328: go.mod:1:1-15 (hover/std.txt:14:1-15): unexpected diagnostic: "packages.Load error: err: exit status 2: stderr: go: no such tool \"compile\""
        marker.go:328: std.go:4:2-7 (hover/std.txt:21:2-7): unexpected diagnostic: "could not import fmt (missing metadata for import of \"fmt\")"
        marker.go:328: std.go:5:2-12 (hover/std.txt:22:2-12): unexpected diagnostic: "could not import go/types (missing metadata for import of \"go/types\")"
        marker.go:328: std.go:6:2-8 (hover/std.txt:23:2-8): unexpected diagnostic: "could not import sync (missing metadata for import of \"sync\")"
exitcode=1
2023-02-07 20:55 android-386-emu tools@ebad375b go@1bd0405b x/tools/gopls/internal/regtest/marker.TestMarkers (log) 
--- FAIL: TestMarkers (4.56s)
    --- FAIL: TestMarkers/definition/embed.txt (0.53s)
        marker.go:884: b/b.go:13:4-6 (definition/embed.txt:51:4-6): definition location does not match:
            	got: <missing location>
            	want a/a.go:5:12-14 (definition/embed.txt:11:12-14)
        marker.go:895: b/b.go:13:4-6 (definition/embed.txt:51:4-6): hover location does not match:
            	got: <missing location>
            	want b/b.go:13:4-6 (definition/embed.txt:51:4-6))
        marker.go:911: b/b.go:13:4-6 (definition/embed.txt:51:4-6): hover markdown mismatch (-want +got):
            --- want
...
    --- FAIL: TestMarkers/definition/import.txt (0.46s)
        marker.go:911: bar/dotimport.go:7:6-7 (definition/import.txt:28:6-7): hover markdown mismatch (-want +got):
            --- want
            +++ got
            @@ -1,5 +1,5 @@
             ```go
            -var _ Foo
            +var _ invalid type
             ```

...
            -
            -
            -[`(types.TypeName).Name` on pkg.go.dev](https://pkg.go.dev/go/types#TypeName.Name)
            +

        marker.go:328: go.mod:1:1-15 (hover/std.txt:14:1-15): unexpected diagnostic: "packages.Load error: err: exit status 2: stderr: go: no such tool \"compile\""
        marker.go:328: std.go:4:2-7 (hover/std.txt:21:2-7): unexpected diagnostic: "could not import fmt (missing metadata for import of \"fmt\")"
        marker.go:328: std.go:5:2-12 (hover/std.txt:22:2-12): unexpected diagnostic: "could not import go/types (missing metadata for import of \"go/types\")"
        marker.go:328: std.go:6:2-8 (hover/std.txt:23:2-8): unexpected diagnostic: "could not import sync (missing metadata for import of \"sync\")"
exitcode=1
2023-02-07 20:55 android-amd64-emu tools@ebad375b go@9565d990 x/tools/gopls/internal/regtest/marker.TestMarkers (log) 
--- FAIL: TestMarkers (4.55s)
    --- FAIL: TestMarkers/definition/embed.txt (0.60s)
        marker.go:884: b/b.go:13:4-6 (definition/embed.txt:51:4-6): definition location does not match:
            	got: <missing location>
            	want a/a.go:5:12-14 (definition/embed.txt:11:12-14)
        marker.go:895: b/b.go:13:4-6 (definition/embed.txt:51:4-6): hover location does not match:
            	got: <missing location>
            	want b/b.go:13:4-6 (definition/embed.txt:51:4-6))
        marker.go:911: b/b.go:13:4-6 (definition/embed.txt:51:4-6): hover markdown mismatch (-want +got):
            --- want
...
    --- FAIL: TestMarkers/definition/import.txt (0.44s)
        marker.go:911: bar/dotimport.go:7:6-7 (definition/import.txt:28:6-7): hover markdown mismatch (-want +got):
            --- want
            +++ got
            @@ -1,5 +1,5 @@
             ```go
            -var _ Foo
            +var _ invalid type
             ```

...
            -
            -
            -[`(types.TypeName).Name` on pkg.go.dev](https://pkg.go.dev/go/types#TypeName.Name)
            +

        marker.go:328: go.mod:1:1-15 (hover/std.txt:14:1-15): unexpected diagnostic: "packages.Load error: err: exit status 2: stderr: go: no such tool \"compile\""
        marker.go:328: std.go:4:2-7 (hover/std.txt:21:2-7): unexpected diagnostic: "could not import fmt (missing metadata for import of \"fmt\")"
        marker.go:328: std.go:5:2-12 (hover/std.txt:22:2-12): unexpected diagnostic: "could not import go/types (missing metadata for import of \"go/types\")"
        marker.go:328: std.go:6:2-8 (hover/std.txt:23:2-8): unexpected diagnostic: "could not import sync (missing metadata for import of \"sync\")"
exitcode=1
2023-02-07 20:55 android-amd64-emu tools@ebad375b go@1bd0405b x/tools/gopls/internal/regtest/marker.TestMarkers (log) 
--- FAIL: TestMarkers (4.16s)
    --- FAIL: TestMarkers/definition/embed.txt (0.57s)
        marker.go:884: b/b.go:13:4-6 (definition/embed.txt:51:4-6): definition location does not match:
            	got: <missing location>
            	want a/a.go:5:12-14 (definition/embed.txt:11:12-14)
        marker.go:895: b/b.go:13:4-6 (definition/embed.txt:51:4-6): hover location does not match:
            	got: <missing location>
            	want b/b.go:13:4-6 (definition/embed.txt:51:4-6))
        marker.go:911: b/b.go:13:4-6 (definition/embed.txt:51:4-6): hover markdown mismatch (-want +got):
            --- want
...
    --- FAIL: TestMarkers/definition/import.txt (0.37s)
        marker.go:911: bar/dotimport.go:7:6-7 (definition/import.txt:28:6-7): hover markdown mismatch (-want +got):
            --- want
            +++ got
            @@ -1,5 +1,5 @@
             ```go
            -var _ Foo
            +var _ invalid type
             ```

...
            -
            -
            -[`(types.TypeName).Name` on pkg.go.dev](https://pkg.go.dev/go/types#TypeName.Name)
            +

        marker.go:328: go.mod:1:1-15 (hover/std.txt:14:1-15): unexpected diagnostic: "packages.Load error: err: exit status 2: stderr: go: no such tool \"compile\""
        marker.go:328: std.go:4:2-7 (hover/std.txt:21:2-7): unexpected diagnostic: "could not import fmt (missing metadata for import of \"fmt\")"
        marker.go:328: std.go:5:2-12 (hover/std.txt:22:2-12): unexpected diagnostic: "could not import go/types (missing metadata for import of \"go/types\")"
        marker.go:328: std.go:6:2-8 (hover/std.txt:23:2-8): unexpected diagnostic: "could not import sync (missing metadata for import of \"sync\")"
exitcode=1
2023-02-07 23:22 android-386-emu tools@1ace7dbc go@9565d990 x/tools/gopls/internal/regtest/marker.TestMarkers (log) 
--- FAIL: TestMarkers (4.68s)
    --- FAIL: TestMarkers/definition/embed.txt (0.73s)
        marker.go:884: b/b.go:13:4-6 (definition/embed.txt:51:4-6): definition location does not match:
            	got: <missing location>
            	want a/a.go:5:12-14 (definition/embed.txt:11:12-14)
        marker.go:895: b/b.go:13:4-6 (definition/embed.txt:51:4-6): hover location does not match:
            	got: <missing location>
            	want b/b.go:13:4-6 (definition/embed.txt:51:4-6))
        marker.go:911: b/b.go:13:4-6 (definition/embed.txt:51:4-6): hover markdown mismatch (-want +got):
            --- want
...
    --- FAIL: TestMarkers/definition/import.txt (0.39s)
        marker.go:911: bar/dotimport.go:7:6-7 (definition/import.txt:28:6-7): hover markdown mismatch (-want +got):
            --- want
            +++ got
            @@ -1,5 +1,5 @@
             ```go
            -var _ Foo
            +var _ invalid type
             ```

...
            -
            -
            -[`(types.TypeName).Name` on pkg.go.dev](https://pkg.go.dev/go/types#TypeName.Name)
            +

        marker.go:328: std.go:4:2-7 (hover/std.txt:21:2-7): unexpected diagnostic: "could not import fmt (missing metadata for import of \"fmt\")"
        marker.go:328: std.go:5:2-12 (hover/std.txt:22:2-12): unexpected diagnostic: "could not import go/types (missing metadata for import of \"go/types\")"
        marker.go:328: std.go:6:2-8 (hover/std.txt:23:2-8): unexpected diagnostic: "could not import sync (missing metadata for import of \"sync\")"
        marker.go:328: go.mod:1:1-15 (hover/std.txt:14:1-15): unexpected diagnostic: "packages.Load error: err: exit status 2: stderr: go: no such tool \"compile\""
exitcode=1
2023-02-07 23:22 android-amd64-emu tools@1ace7dbc go@9565d990 x/tools/gopls/internal/regtest/marker.TestMarkers (log) 
--- FAIL: TestMarkers (4.04s)
    --- FAIL: TestMarkers/definition/embed.txt (0.44s)
        marker.go:884: b/b.go:13:4-6 (definition/embed.txt:51:4-6): definition location does not match:
            	got: <missing location>
            	want a/a.go:5:12-14 (definition/embed.txt:11:12-14)
        marker.go:895: b/b.go:13:4-6 (definition/embed.txt:51:4-6): hover location does not match:
            	got: <missing location>
            	want b/b.go:13:4-6 (definition/embed.txt:51:4-6))
        marker.go:911: b/b.go:13:4-6 (definition/embed.txt:51:4-6): hover markdown mismatch (-want +got):
            --- want
...
    --- FAIL: TestMarkers/definition/import.txt (0.43s)
        marker.go:911: bar/dotimport.go:7:6-7 (definition/import.txt:28:6-7): hover markdown mismatch (-want +got):
            --- want
            +++ got
            @@ -1,5 +1,5 @@
             ```go
            -var _ Foo
            +var _ invalid type
             ```

...
            -
            -
            -[`(types.TypeName).Name` on pkg.go.dev](https://pkg.go.dev/go/types#TypeName.Name)
            +

        marker.go:328: std.go:4:2-7 (hover/std.txt:21:2-7): unexpected diagnostic: "could not import fmt (missing metadata for import of \"fmt\")"
        marker.go:328: std.go:5:2-12 (hover/std.txt:22:2-12): unexpected diagnostic: "could not import go/types (missing metadata for import of \"go/types\")"
        marker.go:328: std.go:6:2-8 (hover/std.txt:23:2-8): unexpected diagnostic: "could not import sync (missing metadata for import of \"sync\")"
        marker.go:328: go.mod:1:1-15 (hover/std.txt:14:1-15): unexpected diagnostic: "packages.Load error: err: exit status 2: stderr: go: no such tool \"compile\""
exitcode=1

— watchflakes

@gopherbot gopherbot added Tools This label describes issues relating to any tools in the x/tools repository. gopls Issues related to the Go language server, gopls. labels Feb 7, 2023
@gopherbot gopherbot added this to the Unreleased milestone Feb 7, 2023
@suzmue suzmue modified the milestones: Unreleased, gopls/v0.12.0 Feb 8, 2023
@bcmills bcmills changed the title x/tools/gopls/internal/regtest/marker: TestMarkers failures x/tools/gopls/internal/regtest/marker: TestMarkers failing on android builders at Go 1.20 and above Feb 8, 2023
@bcmills bcmills added Testing An issue that has been verified to require only test changes, not just a test failure. mobile Android, iOS, and x/mobile labels Feb 8, 2023
@bcmills
Copy link
Contributor

bcmills commented Feb 8, 2023

These started at CL 465255 (attn @findleyr @adonovan).

Probably the test is missing a testenv.NeedsGoBuild somewhere, although it's not obvious to me where that call belongs. 🤔

@findleyr
Copy link
Member

findleyr commented Feb 8, 2023

Thank you! These are new tests that use testdata, so must have testenv.NeedsGoBuild. I will fix.

(these tests address all our problems with the old marker tests!)

@gopherbot
Copy link
Contributor Author

Change https://go.dev/cl/466715 mentions this issue: gopls/internal/regtest/marker: require go/packages

@gopherbot
Copy link
Contributor Author

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "golang.org/x/tools/gopls/internal/regtest/marker" && test == "TestMarkers"
2023-02-07 20:32 android-386-emu tools@2b149ce9 go@de4748c4 x/tools/gopls/internal/regtest/marker.TestMarkers (log) 
--- FAIL: TestMarkers (1.04s)
    --- FAIL: TestMarkers/hover/generics.txt (0.37s)
        marker.go:675: {file:///data/local/tmp/go_android_exec/marker.test-23170/TestMarkershovergenerics.txt3419338145/001/work/generics.go 9:1-9:2}: hover markdown mismatch (-want +got):
            --- want
            +++ got
            @@ -5,5 +5,5 @@
             @hover("Q", "Q", ValueQ)


            -[`(generics.Value).Q` on pkg.go.dev](https://pkg.go.dev/mod.com#Value.Q)
            +[`(generics.Value).Q` on pkg.go.dev](https://pkg.go.dev//data/local/tmp/go_android_exec/marker.test-23170/TestMarkershovergenerics.txt3419338145/001/work/generics.go:file=/data/local/tmp/go_android_exec/marker.test-23170/TestMarkershovergenerics.txt3419338145/001/work/generics.go#Value.Q)

exitcode=1
2023-02-07 20:32 android-386-emu tools@2b149ce9 go@d939b371 x/tools/gopls/internal/regtest/marker.TestMarkers (log) 
--- FAIL: TestMarkers (1.17s)
    --- FAIL: TestMarkers/hover/generics.txt (0.32s)
        marker.go:675: {file:///data/local/tmp/go_android_exec/marker.test-23736/TestMarkershovergenerics.txt503923789/001/work/generics.go 9:1-9:2}: hover markdown mismatch (-want +got):
            --- want
            +++ got
            @@ -5,5 +5,5 @@
             @hover("Q", "Q", ValueQ)


            -[`(generics.Value).Q` on pkg.go.dev](https://pkg.go.dev/mod.com#Value.Q)
            +[`(generics.Value).Q` on pkg.go.dev](https://pkg.go.dev//data/local/tmp/go_android_exec/marker.test-23736/TestMarkershovergenerics.txt503923789/001/work/generics.go:file=/data/local/tmp/go_android_exec/marker.test-23736/TestMarkershovergenerics.txt503923789/001/work/generics.go#Value.Q)

exitcode=1
2023-02-07 20:32 android-amd64-emu tools@2b149ce9 go@de4748c4 x/tools/gopls/internal/regtest/marker.TestMarkers (log) 
--- FAIL: TestMarkers (1.07s)
    --- FAIL: TestMarkers/hover/generics.txt (0.29s)
        marker.go:675: {file:///data/local/tmp/go_android_exec/marker.test-23320/TestMarkershovergenerics.txt350922281/001/work/generics.go 9:1-9:2}: hover markdown mismatch (-want +got):
            --- want
            +++ got
            @@ -5,5 +5,5 @@
             @hover("Q", "Q", ValueQ)


            -[`(generics.Value).Q` on pkg.go.dev](https://pkg.go.dev/mod.com#Value.Q)
            +[`(generics.Value).Q` on pkg.go.dev](https://pkg.go.dev//data/local/tmp/go_android_exec/marker.test-23320/TestMarkershovergenerics.txt350922281/001/work/generics.go:file=/data/local/tmp/go_android_exec/marker.test-23320/TestMarkershovergenerics.txt350922281/001/work/generics.go#Value.Q)

exitcode=1
2023-02-07 20:32 android-amd64-emu tools@2b149ce9 go@d939b371 x/tools/gopls/internal/regtest/marker.TestMarkers (log) 
--- FAIL: TestMarkers (1.08s)
    --- FAIL: TestMarkers/hover/generics.txt (0.31s)
        marker.go:675: {file:///data/local/tmp/go_android_exec/marker.test-24193/TestMarkershovergenerics.txt3818633877/001/work/generics.go 9:1-9:2}: hover markdown mismatch (-want +got):
            --- want
            +++ got
            @@ -5,5 +5,5 @@
             @hover("Q", "Q", ValueQ)


            -[`(generics.Value).Q` on pkg.go.dev](https://pkg.go.dev/mod.com#Value.Q)
            +[`(generics.Value).Q` on pkg.go.dev](https://pkg.go.dev//data/local/tmp/go_android_exec/marker.test-24193/TestMarkershovergenerics.txt3818633877/001/work/generics.go:file=/data/local/tmp/go_android_exec/marker.test-24193/TestMarkershovergenerics.txt3818633877/001/work/generics.go#Value.Q)

exitcode=1
2023-02-07 20:33 android-386-emu tools@24a13c6f go@d939b371 x/tools/gopls/internal/regtest/marker.TestMarkers (log) 
--- FAIL: TestMarkers (4.00s)
    --- FAIL: TestMarkers/definition/embed.txt (0.64s)
        marker.go:822: b/b.go:13:4-6 (definition/embed.txt:51:4-6): definition location does not match:
            	got: <missing location>
            	want a/a.go:5:12-14 (definition/embed.txt:11:12-14)
        marker.go:833: b/b.go:13:4-6 (definition/embed.txt:51:4-6): hover location does not match:
            	got: <missing location>
            	want b/b.go:13:4-6 (definition/embed.txt:51:4-6))
        marker.go:849: b/b.go:13:4-6 (definition/embed.txt:51:4-6): hover markdown mismatch (-want +got):
            --- want
...
    --- FAIL: TestMarkers/definition/import.txt (0.43s)
        marker.go:849: bar/dotimport.go:7:6-7 (definition/import.txt:28:6-7): hover markdown mismatch (-want +got):
            --- want
            +++ got
            @@ -1,5 +1,5 @@
             ```go
            -var _ Foo
            +var _ invalid type
             ```

...
            -
            -
            -[`(types.TypeName).Name` on pkg.go.dev](https://pkg.go.dev/go/types#TypeName.Name)
            +

        marker.go:314: go.mod:1:1-15 (hover/std.txt:14:1-15): unexpected diagnostic: "packages.Load error: err: exit status 2: stderr: go: no such tool \"compile\""
        marker.go:314: std.go:4:2-7 (hover/std.txt:21:2-7): unexpected diagnostic: "could not import fmt (missing metadata for import of \"fmt\")"
        marker.go:314: std.go:5:2-12 (hover/std.txt:22:2-12): unexpected diagnostic: "could not import go/types (missing metadata for import of \"go/types\")"
        marker.go:314: std.go:6:2-8 (hover/std.txt:23:2-8): unexpected diagnostic: "could not import sync (missing metadata for import of \"sync\")"
exitcode=1
2023-02-07 20:33 android-386-emu tools@24a13c6f go@de4748c4 x/tools/gopls/internal/regtest/marker.TestMarkers (log) 
--- FAIL: TestMarkers (3.87s)
    --- FAIL: TestMarkers/definition/embed.txt (0.63s)
        marker.go:822: b/b.go:13:4-6 (definition/embed.txt:51:4-6): definition location does not match:
            	got: <missing location>
            	want a/a.go:5:12-14 (definition/embed.txt:11:12-14)
        marker.go:833: b/b.go:13:4-6 (definition/embed.txt:51:4-6): hover location does not match:
            	got: <missing location>
            	want b/b.go:13:4-6 (definition/embed.txt:51:4-6))
        marker.go:849: b/b.go:13:4-6 (definition/embed.txt:51:4-6): hover markdown mismatch (-want +got):
            --- want
...
    --- FAIL: TestMarkers/definition/import.txt (0.39s)
        marker.go:849: bar/dotimport.go:7:6-7 (definition/import.txt:28:6-7): hover markdown mismatch (-want +got):
            --- want
            +++ got
            @@ -1,5 +1,5 @@
             ```go
            -var _ Foo
            +var _ invalid type
             ```

...
            -
            -
            -[`(types.TypeName).Name` on pkg.go.dev](https://pkg.go.dev/go/types#TypeName.Name)
            +

        marker.go:314: go.mod:1:1-15 (hover/std.txt:14:1-15): unexpected diagnostic: "packages.Load error: err: exit status 2: stderr: go: no such tool \"compile\""
        marker.go:314: std.go:4:2-7 (hover/std.txt:21:2-7): unexpected diagnostic: "could not import fmt (missing metadata for import of \"fmt\")"
        marker.go:314: std.go:5:2-12 (hover/std.txt:22:2-12): unexpected diagnostic: "could not import go/types (missing metadata for import of \"go/types\")"
        marker.go:314: std.go:6:2-8 (hover/std.txt:23:2-8): unexpected diagnostic: "could not import sync (missing metadata for import of \"sync\")"
exitcode=1
2023-02-07 20:33 android-amd64-emu tools@24a13c6f go@d939b371 x/tools/gopls/internal/regtest/marker.TestMarkers (log) 
--- FAIL: TestMarkers (3.78s)
    --- FAIL: TestMarkers/definition/embed.txt (0.64s)
        marker.go:822: b/b.go:13:4-6 (definition/embed.txt:51:4-6): definition location does not match:
            	got: <missing location>
            	want a/a.go:5:12-14 (definition/embed.txt:11:12-14)
        marker.go:833: b/b.go:13:4-6 (definition/embed.txt:51:4-6): hover location does not match:
            	got: <missing location>
            	want b/b.go:13:4-6 (definition/embed.txt:51:4-6))
        marker.go:849: b/b.go:13:4-6 (definition/embed.txt:51:4-6): hover markdown mismatch (-want +got):
            --- want
...
    --- FAIL: TestMarkers/definition/import.txt (0.41s)
        marker.go:849: bar/dotimport.go:7:6-7 (definition/import.txt:28:6-7): hover markdown mismatch (-want +got):
            --- want
            +++ got
            @@ -1,5 +1,5 @@
             ```go
            -var _ Foo
            +var _ invalid type
             ```

...
            -
            -
            -[`(types.TypeName).Name` on pkg.go.dev](https://pkg.go.dev/go/types#TypeName.Name)
            +

        marker.go:314: std.go:4:2-7 (hover/std.txt:21:2-7): unexpected diagnostic: "could not import fmt (missing metadata for import of \"fmt\")"
        marker.go:314: std.go:5:2-12 (hover/std.txt:22:2-12): unexpected diagnostic: "could not import go/types (missing metadata for import of \"go/types\")"
        marker.go:314: std.go:6:2-8 (hover/std.txt:23:2-8): unexpected diagnostic: "could not import sync (missing metadata for import of \"sync\")"
        marker.go:314: go.mod:1:1-15 (hover/std.txt:14:1-15): unexpected diagnostic: "packages.Load error: err: exit status 2: stderr: go: no such tool \"compile\""
exitcode=1
2023-02-07 20:33 android-amd64-emu tools@24a13c6f go@de4748c4 x/tools/gopls/internal/regtest/marker.TestMarkers (log) 
--- FAIL: TestMarkers (3.85s)
    --- FAIL: TestMarkers/definition/embed.txt (0.60s)
        marker.go:822: b/b.go:13:4-6 (definition/embed.txt:51:4-6): definition location does not match:
            	got: <missing location>
            	want a/a.go:5:12-14 (definition/embed.txt:11:12-14)
        marker.go:833: b/b.go:13:4-6 (definition/embed.txt:51:4-6): hover location does not match:
            	got: <missing location>
            	want b/b.go:13:4-6 (definition/embed.txt:51:4-6))
        marker.go:849: b/b.go:13:4-6 (definition/embed.txt:51:4-6): hover markdown mismatch (-want +got):
            --- want
...
    --- FAIL: TestMarkers/definition/import.txt (0.37s)
        marker.go:849: bar/dotimport.go:7:6-7 (definition/import.txt:28:6-7): hover markdown mismatch (-want +got):
            --- want
            +++ got
            @@ -1,5 +1,5 @@
             ```go
            -var _ Foo
            +var _ invalid type
             ```

...
            -
            -
            -[`(types.TypeName).Name` on pkg.go.dev](https://pkg.go.dev/go/types#TypeName.Name)
            +

        marker.go:314: go.mod:1:1-15 (hover/std.txt:14:1-15): unexpected diagnostic: "packages.Load error: err: exit status 2: stderr: go: no such tool \"compile\""
        marker.go:314: std.go:4:2-7 (hover/std.txt:21:2-7): unexpected diagnostic: "could not import fmt (missing metadata for import of \"fmt\")"
        marker.go:314: std.go:5:2-12 (hover/std.txt:22:2-12): unexpected diagnostic: "could not import go/types (missing metadata for import of \"go/types\")"
        marker.go:314: std.go:6:2-8 (hover/std.txt:23:2-8): unexpected diagnostic: "could not import sync (missing metadata for import of \"sync\")"
exitcode=1
2023-02-07 20:33 android-386-emu tools@69920f2e go@d939b371 x/tools/gopls/internal/regtest/marker.TestMarkers (log) 
--- FAIL: TestMarkers (4.56s)
    --- FAIL: TestMarkers/definition/embed.txt (0.68s)
        marker.go:847: b/b.go:13:4-6 (definition/embed.txt:51:4-6): definition location does not match:
            	got: <missing location>
            	want a/a.go:5:12-14 (definition/embed.txt:11:12-14)
        marker.go:858: b/b.go:13:4-6 (definition/embed.txt:51:4-6): hover location does not match:
            	got: <missing location>
            	want b/b.go:13:4-6 (definition/embed.txt:51:4-6))
        marker.go:874: b/b.go:13:4-6 (definition/embed.txt:51:4-6): hover markdown mismatch (-want +got):
            --- want
...
    --- FAIL: TestMarkers/definition/import.txt (0.39s)
        marker.go:874: bar/dotimport.go:7:6-7 (definition/import.txt:28:6-7): hover markdown mismatch (-want +got):
            --- want
            +++ got
            @@ -1,5 +1,5 @@
             ```go
            -var _ Foo
            +var _ invalid type
             ```

...
            -
            -
            -[`(types.TypeName).Name` on pkg.go.dev](https://pkg.go.dev/go/types#TypeName.Name)
            +

        marker.go:319: go.mod:1:1-15 (hover/std.txt:14:1-15): unexpected diagnostic: "packages.Load error: err: exit status 2: stderr: go: no such tool \"compile\""
        marker.go:319: std.go:4:2-7 (hover/std.txt:21:2-7): unexpected diagnostic: "could not import fmt (missing metadata for import of \"fmt\")"
        marker.go:319: std.go:5:2-12 (hover/std.txt:22:2-12): unexpected diagnostic: "could not import go/types (missing metadata for import of \"go/types\")"
        marker.go:319: std.go:6:2-8 (hover/std.txt:23:2-8): unexpected diagnostic: "could not import sync (missing metadata for import of \"sync\")"
exitcode=1
2023-02-07 20:33 android-386-emu tools@69920f2e go@de4748c4 x/tools/gopls/internal/regtest/marker.TestMarkers (log) 
--- FAIL: TestMarkers (5.00s)
    --- FAIL: TestMarkers/definition/embed.txt (0.69s)
        marker.go:847: b/b.go:13:4-6 (definition/embed.txt:51:4-6): definition location does not match:
            	got: <missing location>
            	want a/a.go:5:12-14 (definition/embed.txt:11:12-14)
        marker.go:858: b/b.go:13:4-6 (definition/embed.txt:51:4-6): hover location does not match:
            	got: <missing location>
            	want b/b.go:13:4-6 (definition/embed.txt:51:4-6))
        marker.go:874: b/b.go:13:4-6 (definition/embed.txt:51:4-6): hover markdown mismatch (-want +got):
            --- want
...
    --- FAIL: TestMarkers/definition/import.txt (0.43s)
        marker.go:874: bar/dotimport.go:7:6-7 (definition/import.txt:28:6-7): hover markdown mismatch (-want +got):
            --- want
            +++ got
            @@ -1,5 +1,5 @@
             ```go
            -var _ Foo
            +var _ invalid type
             ```

...
            -```
            -
            -Name returns the object's (package-local, unqualified) name.
            -
            -
            -[`(types.TypeName).Name` on pkg.go.dev](https://pkg.go.dev/go/types#TypeName.Name)
            +

        marker.go:319: go.mod:1:1-15 (hover/std.txt:14:1-15): unexpected diagnostic: "packages.Load error: err: exit status 2: stderr: go: no such tool \"compile\""
exitcode=1
2023-02-07 20:33 android-amd64-emu tools@69920f2e go@d939b371 x/tools/gopls/internal/regtest/marker.TestMarkers (log) 
--- FAIL: TestMarkers (4.36s)
    --- FAIL: TestMarkers/definition/embed.txt (0.54s)
        marker.go:847: b/b.go:13:4-6 (definition/embed.txt:51:4-6): definition location does not match:
            	got: <missing location>
            	want a/a.go:5:12-14 (definition/embed.txt:11:12-14)
        marker.go:858: b/b.go:13:4-6 (definition/embed.txt:51:4-6): hover location does not match:
            	got: <missing location>
            	want b/b.go:13:4-6 (definition/embed.txt:51:4-6))
        marker.go:874: b/b.go:13:4-6 (definition/embed.txt:51:4-6): hover markdown mismatch (-want +got):
            --- want
...
    --- FAIL: TestMarkers/definition/import.txt (0.36s)
        marker.go:874: bar/dotimport.go:7:6-7 (definition/import.txt:28:6-7): hover markdown mismatch (-want +got):
            --- want
            +++ got
            @@ -1,5 +1,5 @@
             ```go
            -var _ Foo
            +var _ invalid type
             ```

...
            -
            -
            -[`(types.TypeName).Name` on pkg.go.dev](https://pkg.go.dev/go/types#TypeName.Name)
            +

        marker.go:319: std.go:6:2-8 (hover/std.txt:23:2-8): unexpected diagnostic: "could not import sync (missing metadata for import of \"sync\")"
        marker.go:319: go.mod:1:1-15 (hover/std.txt:14:1-15): unexpected diagnostic: "packages.Load error: err: exit status 2: stderr: go: no such tool \"compile\""
        marker.go:319: std.go:4:2-7 (hover/std.txt:21:2-7): unexpected diagnostic: "could not import fmt (missing metadata for import of \"fmt\")"
        marker.go:319: std.go:5:2-12 (hover/std.txt:22:2-12): unexpected diagnostic: "could not import go/types (missing metadata for import of \"go/types\")"
exitcode=1
2023-02-07 20:33 android-amd64-emu tools@69920f2e go@de4748c4 x/tools/gopls/internal/regtest/marker.TestMarkers (log) 
--- FAIL: TestMarkers (4.37s)
    --- FAIL: TestMarkers/definition/embed.txt (0.67s)
        marker.go:847: b/b.go:13:4-6 (definition/embed.txt:51:4-6): definition location does not match:
            	got: <missing location>
            	want a/a.go:5:12-14 (definition/embed.txt:11:12-14)
        marker.go:858: b/b.go:13:4-6 (definition/embed.txt:51:4-6): hover location does not match:
            	got: <missing location>
            	want b/b.go:13:4-6 (definition/embed.txt:51:4-6))
        marker.go:874: b/b.go:13:4-6 (definition/embed.txt:51:4-6): hover markdown mismatch (-want +got):
            --- want
...
    --- FAIL: TestMarkers/definition/import.txt (0.34s)
        marker.go:874: bar/dotimport.go:7:6-7 (definition/import.txt:28:6-7): hover markdown mismatch (-want +got):
            --- want
            +++ got
            @@ -1,5 +1,5 @@
             ```go
            -var _ Foo
            +var _ invalid type
             ```

...
            -
            -
            -[`(types.TypeName).Name` on pkg.go.dev](https://pkg.go.dev/go/types#TypeName.Name)
            +

        marker.go:319: std.go:5:2-12 (hover/std.txt:22:2-12): unexpected diagnostic: "could not import go/types (missing metadata for import of \"go/types\")"
        marker.go:319: std.go:6:2-8 (hover/std.txt:23:2-8): unexpected diagnostic: "could not import sync (missing metadata for import of \"sync\")"
        marker.go:319: go.mod:1:1-15 (hover/std.txt:14:1-15): unexpected diagnostic: "packages.Load error: err: exit status 2: stderr: go: no such tool \"compile\"\ngo: no such tool \"compile\""
        marker.go:319: std.go:4:2-7 (hover/std.txt:21:2-7): unexpected diagnostic: "could not import fmt (missing metadata for import of \"fmt\")"
exitcode=1
2023-02-07 20:50 android-386-emu tools@10a39ef3 go@de4748c4 x/tools/gopls/internal/regtest/marker.TestMarkers (log) 
--- FAIL: TestMarkers (4.38s)
    --- FAIL: TestMarkers/definition/embed.txt (0.47s)
        marker.go:884: b/b.go:13:4-6 (definition/embed.txt:51:4-6): definition location does not match:
            	got: <missing location>
            	want a/a.go:5:12-14 (definition/embed.txt:11:12-14)
        marker.go:895: b/b.go:13:4-6 (definition/embed.txt:51:4-6): hover location does not match:
            	got: <missing location>
            	want b/b.go:13:4-6 (definition/embed.txt:51:4-6))
        marker.go:911: b/b.go:13:4-6 (definition/embed.txt:51:4-6): hover markdown mismatch (-want +got):
            --- want
...
    --- FAIL: TestMarkers/definition/import.txt (0.39s)
        marker.go:911: bar/dotimport.go:7:6-7 (definition/import.txt:28:6-7): hover markdown mismatch (-want +got):
            --- want
            +++ got
            @@ -1,5 +1,5 @@
             ```go
            -var _ Foo
            +var _ invalid type
             ```

...
            -
            -
            -[`(types.TypeName).Name` on pkg.go.dev](https://pkg.go.dev/go/types#TypeName.Name)
            +

        marker.go:328: std.go:4:2-7 (hover/std.txt:21:2-7): unexpected diagnostic: "could not import fmt (missing metadata for import of \"fmt\")"
        marker.go:328: std.go:5:2-12 (hover/std.txt:22:2-12): unexpected diagnostic: "could not import go/types (missing metadata for import of \"go/types\")"
        marker.go:328: std.go:6:2-8 (hover/std.txt:23:2-8): unexpected diagnostic: "could not import sync (missing metadata for import of \"sync\")"
        marker.go:328: go.mod:1:1-15 (hover/std.txt:14:1-15): unexpected diagnostic: "packages.Load error: err: exit status 2: stderr: go: no such tool \"compile\"\ngo: no such tool \"compile\""
exitcode=1
2023-02-07 20:50 android-386-emu tools@10a39ef3 go@d939b371 x/tools/gopls/internal/regtest/marker.TestMarkers (log) 
--- FAIL: TestMarkers (4.59s)
    --- FAIL: TestMarkers/definition/embed.txt (0.63s)
        marker.go:884: b/b.go:13:4-6 (definition/embed.txt:51:4-6): definition location does not match:
            	got: <missing location>
            	want a/a.go:5:12-14 (definition/embed.txt:11:12-14)
        marker.go:895: b/b.go:13:4-6 (definition/embed.txt:51:4-6): hover location does not match:
            	got: <missing location>
            	want b/b.go:13:4-6 (definition/embed.txt:51:4-6))
        marker.go:911: b/b.go:13:4-6 (definition/embed.txt:51:4-6): hover markdown mismatch (-want +got):
            --- want
...
    --- FAIL: TestMarkers/definition/import.txt (0.39s)
        marker.go:911: bar/dotimport.go:7:6-7 (definition/import.txt:28:6-7): hover markdown mismatch (-want +got):
            --- want
            +++ got
            @@ -1,5 +1,5 @@
             ```go
            -var _ Foo
            +var _ invalid type
             ```

...
            -
            -
            -[`(types.TypeName).Name` on pkg.go.dev](https://pkg.go.dev/go/types#TypeName.Name)
            +

        marker.go:328: go.mod:1:1-15 (hover/std.txt:14:1-15): unexpected diagnostic: "packages.Load error: err: exit status 2: stderr: go: no such tool \"compile\"\ngo: no such tool \"compile\""
        marker.go:328: std.go:4:2-7 (hover/std.txt:21:2-7): unexpected diagnostic: "could not import fmt (missing metadata for import of \"fmt\")"
        marker.go:328: std.go:5:2-12 (hover/std.txt:22:2-12): unexpected diagnostic: "could not import go/types (missing metadata for import of \"go/types\")"
        marker.go:328: std.go:6:2-8 (hover/std.txt:23:2-8): unexpected diagnostic: "could not import sync (missing metadata for import of \"sync\")"
exitcode=1
2023-02-07 20:50 android-amd64-emu tools@10a39ef3 go@de4748c4 x/tools/gopls/internal/regtest/marker.TestMarkers (log) 
--- FAIL: TestMarkers (4.37s)
    --- FAIL: TestMarkers/definition/embed.txt (0.65s)
        marker.go:884: b/b.go:13:4-6 (definition/embed.txt:51:4-6): definition location does not match:
            	got: <missing location>
            	want a/a.go:5:12-14 (definition/embed.txt:11:12-14)
        marker.go:895: b/b.go:13:4-6 (definition/embed.txt:51:4-6): hover location does not match:
            	got: <missing location>
            	want b/b.go:13:4-6 (definition/embed.txt:51:4-6))
        marker.go:911: b/b.go:13:4-6 (definition/embed.txt:51:4-6): hover markdown mismatch (-want +got):
            --- want
...
    --- FAIL: TestMarkers/definition/import.txt (0.28s)
        marker.go:911: bar/dotimport.go:7:6-7 (definition/import.txt:28:6-7): hover markdown mismatch (-want +got):
            --- want
            +++ got
            @@ -1,5 +1,5 @@
             ```go
            -var _ Foo
            +var _ invalid type
             ```

...
            -
            -
            -[`(types.TypeName).Name` on pkg.go.dev](https://pkg.go.dev/go/types#TypeName.Name)
            +

        marker.go:328: go.mod:1:1-15 (hover/std.txt:14:1-15): unexpected diagnostic: "packages.Load error: err: exit status 2: stderr: go: no such tool \"compile\""
        marker.go:328: std.go:4:2-7 (hover/std.txt:21:2-7): unexpected diagnostic: "could not import fmt (missing metadata for import of \"fmt\")"
        marker.go:328: std.go:5:2-12 (hover/std.txt:22:2-12): unexpected diagnostic: "could not import go/types (missing metadata for import of \"go/types\")"
        marker.go:328: std.go:6:2-8 (hover/std.txt:23:2-8): unexpected diagnostic: "could not import sync (missing metadata for import of \"sync\")"
exitcode=1
2023-02-07 20:50 android-amd64-emu tools@10a39ef3 go@d939b371 x/tools/gopls/internal/regtest/marker.TestMarkers (log) 
--- FAIL: TestMarkers (4.38s)
    --- FAIL: TestMarkers/definition/embed.txt (0.56s)
        marker.go:884: b/b.go:13:4-6 (definition/embed.txt:51:4-6): definition location does not match:
            	got: <missing location>
            	want a/a.go:5:12-14 (definition/embed.txt:11:12-14)
        marker.go:895: b/b.go:13:4-6 (definition/embed.txt:51:4-6): hover location does not match:
            	got: <missing location>
            	want b/b.go:13:4-6 (definition/embed.txt:51:4-6))
        marker.go:911: b/b.go:13:4-6 (definition/embed.txt:51:4-6): hover markdown mismatch (-want +got):
            --- want
...
    --- FAIL: TestMarkers/definition/import.txt (0.37s)
        marker.go:911: bar/dotimport.go:7:6-7 (definition/import.txt:28:6-7): hover markdown mismatch (-want +got):
            --- want
            +++ got
            @@ -1,5 +1,5 @@
             ```go
            -var _ Foo
            +var _ invalid type
             ```

...
            -
            -
            -[`(types.TypeName).Name` on pkg.go.dev](https://pkg.go.dev/go/types#TypeName.Name)
            +

        marker.go:328: std.go:5:2-12 (hover/std.txt:22:2-12): unexpected diagnostic: "could not import go/types (missing metadata for import of \"go/types\")"
        marker.go:328: std.go:6:2-8 (hover/std.txt:23:2-8): unexpected diagnostic: "could not import sync (missing metadata for import of \"sync\")"
        marker.go:328: go.mod:1:1-15 (hover/std.txt:14:1-15): unexpected diagnostic: "packages.Load error: err: exit status 2: stderr: go: no such tool \"compile\""
        marker.go:328: std.go:4:2-7 (hover/std.txt:21:2-7): unexpected diagnostic: "could not import fmt (missing metadata for import of \"fmt\")"
exitcode=1
2023-02-07 20:55 android-386-emu tools@ebad375b go@de4748c4 x/tools/gopls/internal/regtest/marker.TestMarkers (log) 
--- FAIL: TestMarkers (4.76s)
    --- FAIL: TestMarkers/definition/embed.txt (0.61s)
        marker.go:884: b/b.go:13:4-6 (definition/embed.txt:51:4-6): definition location does not match:
            	got: <missing location>
            	want a/a.go:5:12-14 (definition/embed.txt:11:12-14)
        marker.go:895: b/b.go:13:4-6 (definition/embed.txt:51:4-6): hover location does not match:
            	got: <missing location>
            	want b/b.go:13:4-6 (definition/embed.txt:51:4-6))
        marker.go:911: b/b.go:13:4-6 (definition/embed.txt:51:4-6): hover markdown mismatch (-want +got):
            --- want
...
    --- FAIL: TestMarkers/definition/import.txt (0.38s)
        marker.go:911: bar/dotimport.go:7:6-7 (definition/import.txt:28:6-7): hover markdown mismatch (-want +got):
            --- want
            +++ got
            @@ -1,5 +1,5 @@
             ```go
            -var _ Foo
            +var _ invalid type
             ```

...
            -
            -
            -[`(types.TypeName).Name` on pkg.go.dev](https://pkg.go.dev/go/types#TypeName.Name)
            +

        marker.go:328: std.go:6:2-8 (hover/std.txt:23:2-8): unexpected diagnostic: "could not import sync (missing metadata for import of \"sync\")"
        marker.go:328: go.mod:1:1-15 (hover/std.txt:14:1-15): unexpected diagnostic: "packages.Load error: err: exit status 2: stderr: go: no such tool \"compile\"\ngo: no such tool \"compile\""
        marker.go:328: std.go:4:2-7 (hover/std.txt:21:2-7): unexpected diagnostic: "could not import fmt (missing metadata for import of \"fmt\")"
        marker.go:328: std.go:5:2-12 (hover/std.txt:22:2-12): unexpected diagnostic: "could not import go/types (missing metadata for import of \"go/types\")"
exitcode=1
2023-02-07 20:55 android-386-emu tools@ebad375b go@d939b371 x/tools/gopls/internal/regtest/marker.TestMarkers (log) 
--- FAIL: TestMarkers (4.44s)
    --- FAIL: TestMarkers/definition/embed.txt (0.59s)
        marker.go:884: b/b.go:13:4-6 (definition/embed.txt:51:4-6): definition location does not match:
            	got: <missing location>
            	want a/a.go:5:12-14 (definition/embed.txt:11:12-14)
        marker.go:895: b/b.go:13:4-6 (definition/embed.txt:51:4-6): hover location does not match:
            	got: <missing location>
            	want b/b.go:13:4-6 (definition/embed.txt:51:4-6))
        marker.go:911: b/b.go:13:4-6 (definition/embed.txt:51:4-6): hover markdown mismatch (-want +got):
            --- want
...
    --- FAIL: TestMarkers/definition/import.txt (0.44s)
        marker.go:911: bar/dotimport.go:7:6-7 (definition/import.txt:28:6-7): hover markdown mismatch (-want +got):
            --- want
            +++ got
            @@ -1,5 +1,5 @@
             ```go
            -var _ Foo
            +var _ invalid type
             ```

...
            -
            -
            -[`(types.TypeName).Name` on pkg.go.dev](https://pkg.go.dev/go/types#TypeName.Name)
            +

        marker.go:328: go.mod:1:1-15 (hover/std.txt:14:1-15): unexpected diagnostic: "packages.Load error: err: exit status 2: stderr: go: no such tool \"compile\""
        marker.go:328: std.go:4:2-7 (hover/std.txt:21:2-7): unexpected diagnostic: "could not import fmt (missing metadata for import of \"fmt\")"
        marker.go:328: std.go:5:2-12 (hover/std.txt:22:2-12): unexpected diagnostic: "could not import go/types (missing metadata for import of \"go/types\")"
        marker.go:328: std.go:6:2-8 (hover/std.txt:23:2-8): unexpected diagnostic: "could not import sync (missing metadata for import of \"sync\")"
exitcode=1
2023-02-07 20:55 android-amd64-emu tools@ebad375b go@de4748c4 x/tools/gopls/internal/regtest/marker.TestMarkers (log) 
--- FAIL: TestMarkers (4.10s)
    --- FAIL: TestMarkers/definition/embed.txt (0.52s)
        marker.go:884: b/b.go:13:4-6 (definition/embed.txt:51:4-6): definition location does not match:
            	got: <missing location>
            	want a/a.go:5:12-14 (definition/embed.txt:11:12-14)
        marker.go:895: b/b.go:13:4-6 (definition/embed.txt:51:4-6): hover location does not match:
            	got: <missing location>
            	want b/b.go:13:4-6 (definition/embed.txt:51:4-6))
        marker.go:911: b/b.go:13:4-6 (definition/embed.txt:51:4-6): hover markdown mismatch (-want +got):
            --- want
...
    --- FAIL: TestMarkers/definition/import.txt (0.32s)
        marker.go:911: bar/dotimport.go:7:6-7 (definition/import.txt:28:6-7): hover markdown mismatch (-want +got):
            --- want
            +++ got
            @@ -1,5 +1,5 @@
             ```go
            -var _ Foo
            +var _ invalid type
             ```

...
            -
            -
            -[`(types.TypeName).Name` on pkg.go.dev](https://pkg.go.dev/go/types#TypeName.Name)
            +

        marker.go:328: go.mod:1:1-15 (hover/std.txt:14:1-15): unexpected diagnostic: "packages.Load error: err: exit status 2: stderr: go: no such tool \"compile\""
        marker.go:328: std.go:4:2-7 (hover/std.txt:21:2-7): unexpected diagnostic: "could not import fmt (missing metadata for import of \"fmt\")"
        marker.go:328: std.go:5:2-12 (hover/std.txt:22:2-12): unexpected diagnostic: "could not import go/types (missing metadata for import of \"go/types\")"
        marker.go:328: std.go:6:2-8 (hover/std.txt:23:2-8): unexpected diagnostic: "could not import sync (missing metadata for import of \"sync\")"
exitcode=1
2023-02-07 20:55 android-amd64-emu tools@ebad375b go@d939b371 x/tools/gopls/internal/regtest/marker.TestMarkers (log) 
--- FAIL: TestMarkers (4.42s)
    --- FAIL: TestMarkers/definition/embed.txt (0.52s)
        marker.go:884: b/b.go:13:4-6 (definition/embed.txt:51:4-6): definition location does not match:
            	got: <missing location>
            	want a/a.go:5:12-14 (definition/embed.txt:11:12-14)
        marker.go:895: b/b.go:13:4-6 (definition/embed.txt:51:4-6): hover location does not match:
            	got: <missing location>
            	want b/b.go:13:4-6 (definition/embed.txt:51:4-6))
        marker.go:911: b/b.go:13:4-6 (definition/embed.txt:51:4-6): hover markdown mismatch (-want +got):
            --- want
...
    --- FAIL: TestMarkers/definition/import.txt (0.45s)
        marker.go:911: bar/dotimport.go:7:6-7 (definition/import.txt:28:6-7): hover markdown mismatch (-want +got):
            --- want
            +++ got
            @@ -1,5 +1,5 @@
             ```go
            -var _ Foo
            +var _ invalid type
             ```

...
            -
            -
            -[`(types.TypeName).Name` on pkg.go.dev](https://pkg.go.dev/go/types#TypeName.Name)
            +

        marker.go:328: std.go:5:2-12 (hover/std.txt:22:2-12): unexpected diagnostic: "could not import go/types (missing metadata for import of \"go/types\")"
        marker.go:328: std.go:6:2-8 (hover/std.txt:23:2-8): unexpected diagnostic: "could not import sync (missing metadata for import of \"sync\")"
        marker.go:328: go.mod:1:1-15 (hover/std.txt:14:1-15): unexpected diagnostic: "packages.Load error: err: exit status 2: stderr: go: no such tool \"compile\""
        marker.go:328: std.go:4:2-7 (hover/std.txt:21:2-7): unexpected diagnostic: "could not import fmt (missing metadata for import of \"fmt\")"
exitcode=1

— watchflakes

@gopherbot
Copy link
Contributor Author

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "golang.org/x/tools/gopls/internal/regtest/marker" && test == "TestMarkers"
2023-04-21 21:02 plan9-arm tools@e8f417a9 go@ddd822e5 x/tools/gopls/internal/regtest/marker.TestMarkers (log) 
panic: test timed out after 30m0s
running tests:
	TestMarkers (30m0s)
	TestMarkers/rename/methods.txt (27m54s)

testing.(*T).Run(0xa0420f0, {0x9e947e9, 0x12}, 0xb040480)
	/boot/workdir/go/src/testing/testing.go:1649 +0x40c
golang.org/x/tools/gopls/internal/lsp/regtest.RunMarkerTests(0xa0420f0, {0xa7b80e, 0x8})
	/boot/workdir/gopath/src/golang.org/x/tools/gopls/internal/lsp/regtest/marker.go:303 +0xfc
golang.org/x/tools/gopls/internal/regtest/marker.TestMarkers(0xa0420f0)
	/boot/workdir/gopath/src/golang.org/x/tools/gopls/internal/regtest/marker/marker_test.go:20 +0x2c
testing.tRunner(0xa0420f0, 0xbd9508)

— watchflakes

@gopherbot gopherbot reopened this Apr 24, 2023
@gopherbot
Copy link
Contributor Author

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "golang.org/x/tools/gopls/internal/regtest/marker" && test == "TestMarkers"
2023-04-25 20:18 plan9-arm tools@76e1037d go@39957b5d x/tools/gopls/internal/regtest/marker.TestMarkers (log) 
panic: test timed out after 30m0s
running tests:
	TestMarkers (30m0s)
	TestMarkers/definition/embed.txt (29m53s)

testing.(*T).Run(0x9f522d0, {0x9c367a9, 0x14}, 0xa141758)
	/boot/workdir/go/src/testing/testing.go:1649 +0x40c
golang.org/x/tools/gopls/internal/lsp/regtest.RunMarkerTests(0x9f522d0, {0xa7c1de, 0x8})
	/boot/workdir/gopath/src/golang.org/x/tools/gopls/internal/lsp/regtest/marker.go:303 +0xfc
golang.org/x/tools/gopls/internal/regtest/marker.TestMarkers(0x9f522d0)
	/boot/workdir/gopath/src/golang.org/x/tools/gopls/internal/regtest/marker/marker_test.go:20 +0x2c
testing.tRunner(0x9f522d0, 0xbd9ee4)

— watchflakes

@findleyr
Copy link
Member

This should be fixed by @bcmills' https://go.dev/cl/489217

@gopherbot gopherbot reopened this Jun 1, 2023
@golang golang deleted a comment from gopherbot Jun 3, 2023
@golang golang deleted a comment from gopherbot Jun 3, 2023
@golang golang deleted a comment from gopherbot Jun 3, 2023
@golang golang deleted a comment from gopherbot Jun 3, 2023
@golang golang deleted a comment from gopherbot Jun 3, 2023
@bcmills bcmills closed this as completed Jun 3, 2023
@bcmills
Copy link
Contributor

bcmills commented Jun 3, 2023

Gopherbot posted a bunch of non-Android failures here, which I'm attempting to move to #60584 because they seem to have a different root cause.

@golang golang locked and limited conversation to collaborators Jun 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge gopls Issues related to the Go language server, gopls. mobile Android, iOS, and x/mobile NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. Testing An issue that has been verified to require only test changes, not just a test failure. Tools This label describes issues relating to any tools in the x/tools repository.
Projects
Test Flakes
Archived in project
Milestone
gopls/v0.12.0
Development

No branches or pull requests
4 participants
@bcmills @suzmue @gopherbot @findleyr