x/tools/gopls/internal/regtest/marker: TestMarkers failures #60584

bcmills · 2023-06-03T03:39:14Z

#!watchflakes
post <- pkg == "golang.org/x/tools/gopls/internal/regtest/marker" && test == "TestMarkers" && date >= "2023-05-01"

The text was updated successfully, but these errors were encountered:

bcmills · 2023-06-03T03:41:03Z

(attn @findleyr @adonovan)

gopherbot · 2023-06-03T03:44:50Z

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "golang.org/x/tools/gopls/internal/regtest/marker" && test == "TestMarkers" && date >= "2023-05-01"

2023-06-01 13:34 darwin-amd64-13 tools@0dda7d61 go@5f695f70 x/tools/gopls/internal/regtest/marker.TestMarkers (log)

--- FAIL: TestMarkers (103.81s)
    --- FAIL: TestMarkers/diagnostics/addgowork.txt (2.52s)
        marker.go:488: b/main.go:3:26 (diagnostics/addgowork.txt:36:26): no diagnostic at b/main.go:3:8-16 (diagnostics/addgowork.txt:36:8-16) matches "cannot find package"
    marker.go:463: (Filenames are relative to /tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/regtest/marker/testdata.)

2023-06-01 13:34 netbsd-amd64-9_3 tools@0dda7d61 go@65dcddeb x/tools/gopls/internal/regtest/marker.TestMarkers (log)

--- FAIL: TestMarkers (41.60s)
    --- FAIL: TestMarkers/diagnostics/addgowork.txt (0.44s)
        marker.go:488: a/main.go:3:26 (diagnostics/addgowork.txt:18:26): no diagnostic at a/main.go:3:8-16 (diagnostics/addgowork.txt:18:8-16) matches "cannot find package"
        marker.go:488: b/main.go:3:26 (diagnostics/addgowork.txt:36:26): no diagnostic at b/main.go:3:8-16 (diagnostics/addgowork.txt:36:8-16) matches "cannot find package"
        marker.go:432: b/go.mod:1:1 (diagnostics/addgowork.txt:29:1): unexpected diagnostic: "gopls was not able to find modules in your workspace.\nWhen outside of GOPATH, gopls needs to know which modules you are working on.\nYou can fix this by opening your workspace to a folder inside a Go module, or\nby using a go.work file to specify multiple modules.\nSee the documentation for more information on setting up your workspace:\nhttps://github.com/golang/tools/blob/master/gopls/doc/workspace.md."
        marker.go:432: a/lib/lib.go:1:1 (diagnostics/addgowork.txt:25:1): unexpected diagnostic: "gopls was not able to find modules in your workspace.\nWhen outside of GOPATH, gopls needs to know which modules you are working on.\nYou can fix this by opening your workspace to a folder inside a Go module, or\nby using a go.work file to specify multiple modules.\nSee the documentation for more information on setting up your workspace:\nhttps://github.com/golang/tools/blob/master/gopls/doc/workspace.md."
        marker.go:432: b/main.go:1:1 (diagnostics/addgowork.txt:34:1): unexpected diagnostic: "gopls was not able to find modules in your workspace.\nWhen outside of GOPATH, gopls needs to know which modules you are working on.\nYou can fix this by opening your workspace to a folder inside a Go module, or\nby using a go.work file to specify multiple modules.\nSee the documentation for more information on setting up your workspace:\nhttps://github.com/golang/tools/blob/master/gopls/doc/workspace.md."
        marker.go:432: a/go.mod:1:1 (diagnostics/addgowork.txt:11:1): unexpected diagnostic: "gopls was not able to find modules in your workspace.\nWhen outside of GOPATH, gopls needs to know which modules you are working on.\nYou can fix this by opening your workspace to a folder inside a Go module, or\nby using a go.work file to specify multiple modules.\nSee the documentation for more information on setting up your workspace:\nhttps://github.com/golang/tools/blob/master/gopls/doc/workspace.md."
        marker.go:432: b/lib/lib.go:1:1 (diagnostics/addgowork.txt:43:1): unexpected diagnostic: "gopls was not able to find modules in your workspace.\nWhen outside of GOPATH, gopls needs to know which modules you are working on.\nYou can fix this by opening your workspace to a folder inside a Go module, or\nby using a go.work file to specify multiple modules.\nSee the documentation for more information on setting up your workspace:\nhttps://github.com/golang/tools/blob/master/gopls/doc/workspace.md."
        marker.go:432: a/main.go:1:1 (diagnostics/addgowork.txt:16:1): unexpected diagnostic: "gopls was not able to find modules in your workspace.\nWhen outside of GOPATH, gopls needs to know which modules you are working on.\nYou can fix this by opening your workspace to a folder inside a Go module, or\nby using a go.work file to specify multiple modules.\nSee the documentation for more information on setting up your workspace:\nhttps://github.com/golang/tools/blob/master/gopls/doc/workspace.md."
    marker.go:463: (Filenames are relative to /tmp/workdir/gopath/src/golang.org/x/tools/gopls/internal/regtest/marker/testdata.)

2023-06-01 15:25 openbsd-amd64-72 tools@77fd064f go@ed9db1d3 x/tools/gopls/internal/regtest/marker.TestMarkers (log)

--- FAIL: TestMarkers (160.07s)
    --- FAIL: TestMarkers/diagnostics/addgowork.txt (2.89s)
        marker.go:488: b/main.go:3:26 (diagnostics/addgowork.txt:36:26): no diagnostic at b/main.go:3:8-16 (diagnostics/addgowork.txt:36:8-16) matches "cannot find package"
    marker.go:463: (Filenames are relative to /tmp/workdir/gopath/src/golang.org/x/tools/gopls/internal/regtest/marker/testdata.)

2023-06-01 21:21 freebsd-386-13_0 tools@c35c44fa go@9f450041 x/tools/gopls/internal/regtest/marker.TestMarkers (log)

--- FAIL: TestMarkers (38.13s)
    --- FAIL: TestMarkers/diagnostics/addgowork.txt (0.64s)
        marker.go:488: a/main.go:3:26 (diagnostics/addgowork.txt:18:26): no diagnostic at a/main.go:3:8-16 (diagnostics/addgowork.txt:18:8-16) matches "cannot find package"
        marker.go:488: b/main.go:3:26 (diagnostics/addgowork.txt:36:26): no diagnostic at b/main.go:3:8-16 (diagnostics/addgowork.txt:36:8-16) matches "cannot find package"
        marker.go:432: a/main.go:1:1 (diagnostics/addgowork.txt:16:1): unexpected diagnostic: "gopls was not able to find modules in your workspace.\nWhen outside of GOPATH, gopls needs to know which modules you are working on.\nYou can fix this by opening your workspace to a folder inside a Go module, or\nby using a go.work file to specify multiple modules.\nSee the documentation for more information on setting up your workspace:\nhttps://github.com/golang/tools/blob/master/gopls/doc/workspace.md."
        marker.go:432: a/go.mod:1:1 (diagnostics/addgowork.txt:11:1): unexpected diagnostic: "gopls was not able to find modules in your workspace.\nWhen outside of GOPATH, gopls needs to know which modules you are working on.\nYou can fix this by opening your workspace to a folder inside a Go module, or\nby using a go.work file to specify multiple modules.\nSee the documentation for more information on setting up your workspace:\nhttps://github.com/golang/tools/blob/master/gopls/doc/workspace.md."
        marker.go:432: b/go.mod:1:1 (diagnostics/addgowork.txt:29:1): unexpected diagnostic: "gopls was not able to find modules in your workspace.\nWhen outside of GOPATH, gopls needs to know which modules you are working on.\nYou can fix this by opening your workspace to a folder inside a Go module, or\nby using a go.work file to specify multiple modules.\nSee the documentation for more information on setting up your workspace:\nhttps://github.com/golang/tools/blob/master/gopls/doc/workspace.md."
        marker.go:432: b/main.go:1:1 (diagnostics/addgowork.txt:34:1): unexpected diagnostic: "gopls was not able to find modules in your workspace.\nWhen outside of GOPATH, gopls needs to know which modules you are working on.\nYou can fix this by opening your workspace to a folder inside a Go module, or\nby using a go.work file to specify multiple modules.\nSee the documentation for more information on setting up your workspace:\nhttps://github.com/golang/tools/blob/master/gopls/doc/workspace.md."
        marker.go:432: b/lib/lib.go:1:1 (diagnostics/addgowork.txt:43:1): unexpected diagnostic: "gopls was not able to find modules in your workspace.\nWhen outside of GOPATH, gopls needs to know which modules you are working on.\nYou can fix this by opening your workspace to a folder inside a Go module, or\nby using a go.work file to specify multiple modules.\nSee the documentation for more information on setting up your workspace:\nhttps://github.com/golang/tools/blob/master/gopls/doc/workspace.md."
        marker.go:432: a/lib/lib.go:1:1 (diagnostics/addgowork.txt:25:1): unexpected diagnostic: "gopls was not able to find modules in your workspace.\nWhen outside of GOPATH, gopls needs to know which modules you are working on.\nYou can fix this by opening your workspace to a folder inside a Go module, or\nby using a go.work file to specify multiple modules.\nSee the documentation for more information on setting up your workspace:\nhttps://github.com/golang/tools/blob/master/gopls/doc/workspace.md."
    marker.go:463: (Filenames are relative to /tmp/workdir/gopath/src/golang.org/x/tools/gopls/internal/regtest/marker/testdata.)

2023-06-01 21:43 dragonfly-amd64-622 tools@04ceacbf go@936ce874 x/tools/gopls/internal/regtest/marker.TestMarkers (log)

--- FAIL: TestMarkers (47.10s)
    --- FAIL: TestMarkers/diagnostics/addgowork.txt (1.50s)
        marker.go:488: a/main.go:3:26 (diagnostics/addgowork.txt:18:26): no diagnostic at a/main.go:3:8-16 (diagnostics/addgowork.txt:18:8-16) matches "cannot find package"
    marker.go:463: (Filenames are relative to /tmp/workdir/gopath/src/golang.org/x/tools/gopls/internal/regtest/marker/testdata.)

— watchflakes

gopherbot · 2023-06-03T21:57:18Z

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "golang.org/x/tools/gopls/internal/regtest/marker" && test == "TestMarkers" && date >= "2023-05-01"

2023-06-01 21:43 openbsd-amd64-72 tools@86c93e87 go@ed9db1d3 x/tools/gopls/internal/regtest/marker.TestMarkers (log)

--- FAIL: TestMarkers (182.41s)
    --- FAIL: TestMarkers/diagnostics/addgowork.txt (3.36s)
        marker.go:488: a/main.go:3:26 (diagnostics/addgowork.txt:18:26): no diagnostic at a/main.go:3:8-16 (diagnostics/addgowork.txt:18:8-16) matches "cannot find package"
    marker.go:463: (Filenames are relative to /tmp/workdir/gopath/src/golang.org/x/tools/gopls/internal/regtest/marker/testdata.)

— watchflakes

gopherbot · 2023-06-05T18:39:42Z

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "golang.org/x/tools/gopls/internal/regtest/marker" && test == "TestMarkers" && date >= "2023-05-01"

2023-06-05 15:26 dragonfly-amd64-622 tools@6f567c80 go@d8c9eece x/tools/gopls/internal/regtest/marker.TestMarkers (log)

--- FAIL: TestMarkers (76.44s)
    --- FAIL: TestMarkers/diagnostics/addgowork.txt (2.09s)
        marker.go:488: b/main.go:3:26 (diagnostics/addgowork.txt:36:26): no diagnostic at b/main.go:3:8-16 (diagnostics/addgowork.txt:36:8-16) matches "cannot find package"
    marker.go:463: (Filenames are relative to /tmp/workdir/gopath/src/golang.org/x/tools/gopls/internal/regtest/marker/testdata.)

— watchflakes

gopherbot · 2023-06-06T17:48:18Z

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "golang.org/x/tools/gopls/internal/regtest/marker" && test == "TestMarkers" && date >= "2023-05-01"

2023-06-05 15:26 linux-amd64-nocgo tools@6f567c80 go@b7fc272c x/tools/gopls/internal/regtest/marker.TestMarkers (log)

--- FAIL: TestMarkers (16.42s)
    --- FAIL: TestMarkers/diagnostics/addgowork.txt (0.37s)
        marker.go:488: b/main.go:3:26 (diagnostics/addgowork.txt:36:26): no diagnostic at b/main.go:3:8-16 (diagnostics/addgowork.txt:36:8-16) matches "cannot find package"
    marker.go:463: (Filenames are relative to /workdir/gopath/src/golang.org/x/tools/gopls/internal/regtest/marker/testdata.)

— watchflakes

gopherbot · 2023-06-09T16:20:43Z

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "golang.org/x/tools/gopls/internal/regtest/marker" && test == "TestMarkers" && date >= "2023-05-01"

2023-06-06 20:18 openbsd-amd64-72 tools@a01290f9 go@6801c278 x/tools/gopls/internal/regtest/marker.TestMarkers (log)

--- FAIL: TestMarkers (141.13s)
    --- FAIL: TestMarkers/diagnostics/addgowork.txt (2.80s)
        marker.go:488: a/main.go:3:26 (diagnostics/addgowork.txt:18:26): no diagnostic at a/main.go:3:8-16 (diagnostics/addgowork.txt:18:8-16) matches "cannot find package"
    marker.go:463: (Filenames are relative to /tmp/workdir/gopath/src/golang.org/x/tools/gopls/internal/regtest/marker/testdata.)

— watchflakes

gopherbot · 2023-06-11T12:55:41Z

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "golang.org/x/tools/gopls/internal/regtest/marker" && test == "TestMarkers" && date >= "2023-05-01"

2023-06-10 16:55 freebsd-riscv64-unmatched tools@db6a81ed go@e1493786 x/tools/gopls/internal/regtest/marker.TestMarkers (log)

--- FAIL: TestMarkers (147.36s)
    --- FAIL: TestMarkers/diagnostics/addgowork.txt (2.67s)
        marker.go:488: a/main.go:3:26 (diagnostics/addgowork.txt:18:26): no diagnostic at a/main.go:3:8-16 (diagnostics/addgowork.txt:18:8-16) matches "cannot find package"
    marker.go:463: (Filenames are relative to /tmp/workdir-host-freebsd-riscv64-unmatched/gopath/src/golang.org/x/tools/gopls/internal/regtest/marker/testdata.)

— watchflakes

gopherbot · 2023-06-13T02:19:10Z

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "golang.org/x/tools/gopls/internal/regtest/marker" && test == "TestMarkers" && date >= "2023-05-01"

2023-06-12 17:49 darwin-amd64-12_0 tools@c59d87f5 go@c643b293 x/tools/gopls/internal/regtest/marker.TestMarkers (log)

--- FAIL: TestMarkers (116.65s)
    --- FAIL: TestMarkers/diagnostics/addgowork.txt (4.28s)
        marker.go:488: b/main.go:3:26 (diagnostics/addgowork.txt:36:26): no diagnostic at b/main.go:3:8-16 (diagnostics/addgowork.txt:36:8-16) matches "cannot find package"
    marker.go:463: (Filenames are relative to /tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/regtest/marker/testdata.)

— watchflakes

gopherbot · 2023-06-13T03:22:47Z

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "golang.org/x/tools/gopls/internal/regtest/marker" && test == "TestMarkers" && date >= "2023-05-01"

2023-06-12 20:53 freebsd-amd64-13_0 tools@6e1595c1 go@0b5a4afe x/tools/gopls/internal/regtest/marker.TestMarkers (log)

--- FAIL: TestMarkers (35.16s)
    --- FAIL: TestMarkers/diagnostics/addgowork.txt (0.68s)
        marker.go:488: a/main.go:3:26 (diagnostics/addgowork.txt:18:26): no diagnostic at a/main.go:3:8-16 (diagnostics/addgowork.txt:18:8-16) matches "cannot find package"
    marker.go:463: (Filenames are relative to /tmp/workdir/gopath/src/golang.org/x/tools/gopls/internal/regtest/marker/testdata.)

— watchflakes

gopherbot · 2023-06-13T18:24:14Z

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "golang.org/x/tools/gopls/internal/regtest/marker" && test == "TestMarkers" && date >= "2023-05-01"

2023-06-13 17:37 windows-amd64-2016 tools@0245e1df go@17dcbd86 x/tools/gopls/internal/regtest/marker.TestMarkers (log)

--- FAIL: TestMarkers (80.73s)
    --- FAIL: TestMarkers/diagnostics\addgowork.txt (1.11s)
        marker.go:488: a/main.go:3:26 (diagnostics\addgowork.txt:18:26): no diagnostic at a/main.go:3:8-16 (diagnostics\addgowork.txt:18:8-16) matches "cannot find package"
    marker.go:463: (Filenames are relative to C:\workdir\gopath\src\golang.org\x\tools\gopls\internal\regtest\marker\testdata.)

— watchflakes

gopherbot · 2023-06-14T18:12:30Z

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "golang.org/x/tools/gopls/internal/regtest/marker" && test == "TestMarkers" && date >= "2023-05-01"

2023-06-13 19:45 aix-ppc64 tools@c6c98305 go@ba4c6d1d x/tools/gopls/internal/regtest/marker.TestMarkers (log)

--- FAIL: TestMarkers (118.50s)
    --- FAIL: TestMarkers/fixedbugs/issue59318.txt (2.06s)
        marker.go:488: b/main.go:4:14 (fixedbugs/issue59318.txt:17:14): no diagnostic at b/main.go:4:6-7 (fixedbugs/issue59318.txt:17:6-7) matches "not used"
    marker.go:463: (Filenames are relative to /ramdisk8GB/workdir-host-aix-ppc64-osuosl/gopath/src/golang.org/x/tools/gopls/internal/regtest/marker/testdata.)

2023-06-13 19:45 darwin-amd64-11_0 tools@c6c98305 go@80629cae x/tools/gopls/internal/regtest/marker.TestMarkers (log)

--- FAIL: TestMarkers (134.26s)
    --- FAIL: TestMarkers/diagnostics/addgowork.txt (3.67s)
        marker.go:488: a/main.go:3:26 (diagnostics/addgowork.txt:18:26): no diagnostic at a/main.go:3:8-16 (diagnostics/addgowork.txt:18:8-16) matches "cannot find package"
    marker.go:463: (Filenames are relative to /tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/regtest/marker/testdata.)

2023-06-14 15:55 darwin-arm64-11 tools@27dbf852 go@f5172dcd x/tools/gopls/internal/regtest/marker.TestMarkers (log)

--- FAIL: TestMarkers (21.98s)
    --- FAIL: TestMarkers/diagnostics/addgowork.txt (0.42s)
        marker.go:488: a/main.go:3:26 (diagnostics/addgowork.txt:18:26): no diagnostic at a/main.go:3:8-16 (diagnostics/addgowork.txt:18:8-16) matches "cannot find package"
    marker.go:463: (Filenames are relative to /tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/regtest/marker/testdata.)

— watchflakes

gopherbot · 2023-06-14T19:37:21Z

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "golang.org/x/tools/gopls/internal/regtest/marker" && test == "TestMarkers" && date >= "2023-05-01"

2023-06-14 19:32 freebsd-amd64-12_3 tools@ac294602 go@3aea422e x/tools/gopls/internal/regtest/marker.TestMarkers (log)

--- FAIL: TestMarkers (36.98s)
    --- FAIL: TestMarkers/implementation/generics.txt (0.37s)
        marker.go:488: other/other.go:7:54 (implementation/generics.txt:30:54): implementation: incorrect result locations: (got 0, want 1):
              []string{
            - 	"implementation/implementation.go:11:6-19 (implementation/generics.txt:21:6-19)",
              }
    marker.go:463: (Filenames are relative to /tmp/workdir/gopath/src/golang.org/x/tools/gopls/internal/regtest/marker/testdata.)

— watchflakes

gopherbot · 2023-06-15T15:02:03Z

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "golang.org/x/tools/gopls/internal/regtest/marker" && test == "TestMarkers" && date >= "2023-05-01"

2023-06-15 14:21 openbsd-386-72 tools@7261b326 go@f5172dcd x/tools/gopls/internal/regtest/marker.TestMarkers (log)

--- FAIL: TestMarkers (293.22s)
    --- FAIL: TestMarkers/diagnostics/addgowork.txt (6.97s)
        marker.go:488: b/main.go:3:26 (diagnostics/addgowork.txt:36:26): no diagnostic at b/main.go:3:8-16 (diagnostics/addgowork.txt:36:8-16) matches "cannot find package"
    marker.go:463: (Filenames are relative to /tmp/workdir/gopath/src/golang.org/x/tools/gopls/internal/regtest/marker/testdata.)

— watchflakes

gopherbot · 2023-06-15T15:33:52Z

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "golang.org/x/tools/gopls/internal/regtest/marker" && test == "TestMarkers" && date >= "2023-05-01"

2023-06-15 14:21 dragonfly-amd64-622 tools@7261b326 go@befec5dd x/tools/gopls/internal/regtest/marker.TestMarkers (log)

--- FAIL: TestMarkers (43.23s)
    --- FAIL: TestMarkers/diagnostics/addgowork.txt (1.15s)
        marker.go:488: a/main.go:3:26 (diagnostics/addgowork.txt:18:26): no diagnostic at a/main.go:3:8-16 (diagnostics/addgowork.txt:18:8-16) matches "cannot find package"
    marker.go:463: (Filenames are relative to /tmp/workdir/gopath/src/golang.org/x/tools/gopls/internal/regtest/marker/testdata.)

2023-06-15 14:21 dragonfly-amd64-622 tools@7261b326 go@f5172dcd x/tools/gopls/internal/regtest/marker.TestMarkers (log)

--- FAIL: TestMarkers (66.84s)
    --- FAIL: TestMarkers/fixedbugs/issue59318.txt (0.91s)
        marker.go:488: b/main.go:4:14 (fixedbugs/issue59318.txt:17:14): no diagnostic at b/main.go:4:6-7 (fixedbugs/issue59318.txt:17:6-7) matches "not used"
    marker.go:463: (Filenames are relative to /tmp/workdir/gopath/src/golang.org/x/tools/gopls/internal/regtest/marker/testdata.)

— watchflakes

gopherbot · 2023-06-15T21:33:50Z

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "golang.org/x/tools/gopls/internal/regtest/marker" && test == "TestMarkers" && date >= "2023-05-01"

2023-06-15 14:21 darwin-amd64-longtest tools@7261b326 go@60e6afb6 x/tools/gopls/internal/regtest/marker.TestMarkers (log)

--- FAIL: TestMarkers (131.44s)
    --- FAIL: TestMarkers/diagnostics/addgowork.txt (1.99s)
        marker.go:488: a/main.go:3:26 (diagnostics/addgowork.txt:18:26): no diagnostic at a/main.go:3:8-16 (diagnostics/addgowork.txt:18:8-16) matches "cannot find package"
        marker.go:488: b/main.go:3:26 (diagnostics/addgowork.txt:36:26): no diagnostic at b/main.go:3:8-16 (diagnostics/addgowork.txt:36:8-16) matches "cannot find package"
        marker.go:432: a/go.mod:1:1 (diagnostics/addgowork.txt:11:1): unexpected diagnostic: "gopls was not able to find modules in your workspace.\nWhen outside of GOPATH, gopls needs to know which modules you are working on.\nYou can fix this by opening your workspace to a folder inside a Go module, or\nby using a go.work file to specify multiple modules.\nSee the documentation for more information on setting up your workspace:\nhttps://github.com/golang/tools/blob/master/gopls/doc/workspace.md."
        marker.go:432: a/main.go:1:1 (diagnostics/addgowork.txt:16:1): unexpected diagnostic: "gopls was not able to find modules in your workspace.\nWhen outside of GOPATH, gopls needs to know which modules you are working on.\nYou can fix this by opening your workspace to a folder inside a Go module, or\nby using a go.work file to specify multiple modules.\nSee the documentation for more information on setting up your workspace:\nhttps://github.com/golang/tools/blob/master/gopls/doc/workspace.md."
        marker.go:432: b/go.mod:1:1 (diagnostics/addgowork.txt:29:1): unexpected diagnostic: "gopls was not able to find modules in your workspace.\nWhen outside of GOPATH, gopls needs to know which modules you are working on.\nYou can fix this by opening your workspace to a folder inside a Go module, or\nby using a go.work file to specify multiple modules.\nSee the documentation for more information on setting up your workspace:\nhttps://github.com/golang/tools/blob/master/gopls/doc/workspace.md."
        marker.go:432: a/lib/lib.go:1:1 (diagnostics/addgowork.txt:25:1): unexpected diagnostic: "gopls was not able to find modules in your workspace.\nWhen outside of GOPATH, gopls needs to know which modules you are working on.\nYou can fix this by opening your workspace to a folder inside a Go module, or\nby using a go.work file to specify multiple modules.\nSee the documentation for more information on setting up your workspace:\nhttps://github.com/golang/tools/blob/master/gopls/doc/workspace.md."
        marker.go:432: b/main.go:1:1 (diagnostics/addgowork.txt:34:1): unexpected diagnostic: "gopls was not able to find modules in your workspace.\nWhen outside of GOPATH, gopls needs to know which modules you are working on.\nYou can fix this by opening your workspace to a folder inside a Go module, or\nby using a go.work file to specify multiple modules.\nSee the documentation for more information on setting up your workspace:\nhttps://github.com/golang/tools/blob/master/gopls/doc/workspace.md."
        marker.go:432: b/lib/lib.go:1:1 (diagnostics/addgowork.txt:43:1): unexpected diagnostic: "gopls was not able to find modules in your workspace.\nWhen outside of GOPATH, gopls needs to know which modules you are working on.\nYou can fix this by opening your workspace to a folder inside a Go module, or\nby using a go.work file to specify multiple modules.\nSee the documentation for more information on setting up your workspace:\nhttps://github.com/golang/tools/blob/master/gopls/doc/workspace.md."
    marker.go:463: (Filenames are relative to /tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/regtest/marker/testdata.)

— watchflakes

gopherbot · 2023-06-17T03:10:29Z

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "golang.org/x/tools/gopls/internal/regtest/marker" && test == "TestMarkers" && date >= "2023-05-01"

2023-06-16 16:38 darwin-amd64-nocgo tools@a4ed05f1 go@9ece9a7a x/tools/gopls/internal/regtest/marker.TestMarkers (log)

--- FAIL: TestMarkers (124.23s)
    --- FAIL: TestMarkers/implementation/generics.txt (1.10s)
        marker.go:488: other/other.go:7:54 (implementation/generics.txt:30:54): implementation: incorrect result locations: (got 0, want 1):
              []string{
            - 	"implementation/implementation.go:11:6-19 (implementation/generics.txt:21:6-19)",
              }
    marker.go:463: (Filenames are relative to /tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/regtest/marker/testdata.)

— watchflakes

gopherbot · 2023-06-20T01:39:13Z

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "golang.org/x/tools/gopls/internal/regtest/marker" && test == "TestMarkers" && date >= "2023-05-01"

2023-06-16 16:38 solaris-amd64-oraclerel tools@a4ed05f1 go@63ad2b58 x/tools/gopls/internal/regtest/marker.TestMarkers (log)

--- FAIL: TestMarkers (52.83s)
    --- FAIL: TestMarkers/diagnostics/addgowork.txt (1.14s)
        marker.go:488: a/main.go:3:26 (diagnostics/addgowork.txt:18:26): no diagnostic at a/main.go:3:8-16 (diagnostics/addgowork.txt:18:8-16) matches "cannot find package"
    marker.go:463: (Filenames are relative to /tmp/workdir-host-solaris-oracle-amd64-oraclerel/gopath/src/golang.org/x/tools/gopls/internal/regtest/marker/testdata.)

— watchflakes

gopherbot · 2023-06-20T21:45:35Z

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "golang.org/x/tools/gopls/internal/regtest/marker" && test == "TestMarkers" && date >= "2023-05-01"

2023-06-20 21:27 openbsd-amd64-72 tools@85554d61 go@d51e322a x/tools/gopls/internal/regtest/marker.TestMarkers (log)

--- FAIL: TestMarkers (146.31s)
    --- FAIL: TestMarkers/diagnostics/addgowork.txt (3.53s)
        marker.go:488: a/main.go:3:26 (diagnostics/addgowork.txt:18:26): no diagnostic at a/main.go:3:8-16 (diagnostics/addgowork.txt:18:8-16) matches "cannot find package"
    marker.go:463: (Filenames are relative to /tmp/workdir/gopath/src/golang.org/x/tools/gopls/internal/regtest/marker/testdata.)

— watchflakes

gopherbot · 2023-06-21T20:57:36Z

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "golang.org/x/tools/gopls/internal/regtest/marker" && test == "TestMarkers" && date >= "2023-05-01"

2023-06-21 15:21 windows-arm64-11 tools@0ca9d30b go@b23cae80 x/tools/gopls/internal/regtest/marker.TestMarkers (log)

--- FAIL: TestMarkers (99.23s)
    --- FAIL: TestMarkers/diagnostics\excludedfile.txt (8.21s)
        testing.go:1225: TempDir RemoveAll cleanup: remove C:\Users\gopher\AppData\Local\Temp\TestMarkersdiagnosticsexcludedfile.txt389061629\001\work\b\b.go: The process cannot access the file because it is being used by another process.
    marker.go:463: (Filenames are relative to C:\workdir\gopath\src\golang.org\x\tools\gopls\internal\regtest\marker\testdata.)

— watchflakes

gopherbot · 2023-06-24T01:07:42Z

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "golang.org/x/tools/gopls/internal/regtest/marker" && test == "TestMarkers" && date >= "2023-05-01"

2023-06-23 15:06 linux-amd64-longtest-race tools@fa103593 go@36192557 x/tools/gopls/internal/regtest/marker.TestMarkers (log)

--- FAIL: TestMarkers (59.95s)
    --- FAIL: TestMarkers/diagnostics/addgowork.txt (0.51s)
        marker.go:488: a/main.go:3:26 (diagnostics/addgowork.txt:18:26): no diagnostic at a/main.go:3:8-16 (diagnostics/addgowork.txt:18:8-16) matches "cannot find package"
    marker.go:463: (Filenames are relative to /workdir/gopath/src/golang.org/x/tools/gopls/internal/regtest/marker/testdata.)

— watchflakes

gopherbot · 2023-09-28T14:44:03Z

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "golang.org/x/tools/gopls/internal/regtest/marker" && test == "TestMarkers" && date >= "2023-05-01"

2023-09-28 14:04 aix-ppc64 tools@6de34480 go@83dce459 x/tools/gopls/internal/regtest/marker.TestMarkers (log)

--- FAIL: TestMarkers (0.76s)
    --- FAIL: TestMarkers/completion/unimported.txt (60.85s)
        marker.go:567: unimported/unimported.go:4:9 (completion/unimported.txt:38:9): Completion(...) returned unexpect results (-want +got):
              []regtest.completionItem(
            - 	{
            - 		{Label: "http", Detail: `"net/http"`, Kind: "package"},
            - 		{Label: "httptest", Detail: `"net/http/httptest"`, Kind: "package"},
            - 		{Label: "httptrace", Detail: `"net/http/httptrace"`, Kind: "package"},
            - 		{Label: "httputil", Detail: `"net/http/httputil"`, Kind: "package"},
            - 	},
            + 	nil,
              )

— watchflakes

gopherbot · 2023-09-28T15:04:48Z

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "golang.org/x/tools/gopls/internal/regtest/marker" && test == "TestMarkers" && date >= "2023-05-01"

2023-09-27 21:28 aix-ppc64 tools@7f23bc81 go@0ba8ef47 x/tools/gopls/internal/regtest/marker.TestMarkers (log)

--- FAIL: TestMarkers (0.65s)
    --- FAIL: TestMarkers/completion/unimported.txt (66.31s)
        marker.go:567: unimported/unimported.go:4:9 (completion/unimported.txt:38:9): Completion(...) returned unexpect results (-want +got):
              []regtest.completionItem(
            - 	{
            - 		{Label: "http", Detail: `"net/http"`, Kind: "package"},
            - 		{Label: "httptest", Detail: `"net/http/httptest"`, Kind: "package"},
            - 		{Label: "httptrace", Detail: `"net/http/httptrace"`, Kind: "package"},
            - 		{Label: "httputil", Detail: `"net/http/httputil"`, Kind: "package"},
            - 	},
            + 	nil,
              )

— watchflakes

gopherbot · 2023-09-28T15:06:18Z

Change https://go.dev/cl/531556 mentions this issue: gopls/internal/lsp/fake: don't set a completion budget for tests

gopherbot · 2023-09-28T16:27:51Z

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "golang.org/x/tools/gopls/internal/regtest/marker" && test == "TestMarkers" && date >= "2023-05-01"

2023-09-28 14:04 solaris-amd64-oraclerel tools@6de34480 go@a15ef1bb x/tools/gopls/internal/regtest/marker.TestMarkers (log)

--- FAIL: TestMarkers (0.96s)
    --- FAIL: TestMarkers/completion/issue62676.txt (67.43s)
        marker.go:567: foo/foo.go:5:12 (completion/issue62676.txt:21:12): Completion(...) did not return an item labeled "Open"
    --- FAIL: TestMarkers/completion/unimported.txt (98.10s)
        marker.go:567: unimported/unimported.go:4:9 (completion/unimported.txt:38:9): Completion(...) returned unexpect results (-want +got):
              []regtest.completionItem(
            - 	{
            - 		{Label: "http", Detail: `"net/http"`, Kind: "package"},
            - 		{Label: "httptest", Detail: `"net/http/httptest"`, Kind: "package"},
            - 		{Label: "httptrace", Detail: `"net/http/httptrace"`, Kind: "package"},
            - 		{Label: "httputil", Detail: `"net/http/httputil"`, Kind: "package"},
            - 	},
            + 	nil,
              )

— watchflakes

We were already setting an arbitrarily high completion budget of 10s for tests, but this appears to be causing flakes in the heavily parallelized marker tests on slow builders (e.g. golang/go#60584). No reason to have any budget at all: any tests/benchmarks that depend on the budget should set it explicitly. For golang/go#60584 Change-Id: Ic5e84d483fdffb58b801aae7b814ff705e6ecee9 Reviewed-on: https://go-review.googlesource.com/c/tools/+/531556 Auto-Submit: Robert Findley <[email protected]> Reviewed-by: Peter Weinberger <[email protected]> LUCI-TryBot-Result: Go LUCI <[email protected]>

gopherbot · 2023-09-28T17:09:16Z

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "golang.org/x/tools/gopls/internal/regtest/marker" && test == "TestMarkers" && date >= "2023-05-01"

2023-09-28 16:43 solaris-amd64-oraclerel tools@57ecf488 go@9d3cc85e x/tools/gopls/internal/regtest/marker.TestMarkers (log)

--- FAIL: TestMarkers (0.65s)
    --- FAIL: TestMarkers/completion/unimported.txt (90.43s)
        marker.go:567: unimported/unimported.go:4:9 (completion/unimported.txt:38:9): Completion(...) returned unexpect results (-want +got):
              []regtest.completionItem(
            - 	{
            - 		{Label: "http", Detail: `"net/http"`, Kind: "package"},
            - 		{Label: "httptest", Detail: `"net/http/httptest"`, Kind: "package"},
            - 		{Label: "httptrace", Detail: `"net/http/httptrace"`, Kind: "package"},
            - 		{Label: "httputil", Detail: `"net/http/httputil"`, Kind: "package"},
            - 	},
            + 	nil,
              )
    --- FAIL: TestMarkers/completion/issue62676.txt (76.30s)
        marker.go:567: foo/foo.go:5:12 (completion/issue62676.txt:21:12): Completion(...) did not return an item labeled "Open"

— watchflakes

gopherbot · 2023-09-28T17:50:47Z

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "golang.org/x/tools/gopls/internal/regtest/marker" && test == "TestMarkers" && date >= "2023-05-01"

2023-09-28 16:43 aix-ppc64 tools@57ecf488 go@83dce459 x/tools/gopls/internal/regtest/marker.TestMarkers (log)

--- FAIL: TestMarkers (0.72s)
    --- FAIL: TestMarkers/completion/unimported.txt (54.81s)
        marker.go:567: unimported/unimported.go:4:9 (completion/unimported.txt:38:9): Completion(...) returned unexpect results (-want +got):
              []regtest.completionItem(
            - 	{
            - 		{Label: "http", Detail: `"net/http"`, Kind: "package"},
            - 		{Label: "httptest", Detail: `"net/http/httptest"`, Kind: "package"},
            - 		{Label: "httptrace", Detail: `"net/http/httptrace"`, Kind: "package"},
            - 		{Label: "httputil", Detail: `"net/http/httputil"`, Kind: "package"},
            - 	},
            + 	nil,
              )
    --- FAIL: TestMarkers/completion/issue62676.txt (49.89s)
        marker.go:567: foo/foo.go:5:12 (completion/issue62676.txt:21:12): Completion(...) did not return an item labeled "Open"

2023-09-28 16:43 solaris-amd64-oraclerel tools@57ecf488 go@a15ef1bb x/tools/gopls/internal/regtest/marker.TestMarkers (log)

--- FAIL: TestMarkers (0.44s)
    --- FAIL: TestMarkers/completion/issue62676.txt (99.86s)
        marker.go:567: foo/foo.go:5:12 (completion/issue62676.txt:21:12): Completion(...) did not return an item labeled "Open"
    --- FAIL: TestMarkers/completion/unimported.txt (102.00s)
        marker.go:567: unimported/unimported.go:4:9 (completion/unimported.txt:38:9): Completion(...) returned unexpect results (-want +got):
              []regtest.completionItem(
            - 	{
            - 		{Label: "http", Detail: `"net/http"`, Kind: "package"},
            - 		{Label: "httptest", Detail: `"net/http/httptest"`, Kind: "package"},
            - 		{Label: "httptrace", Detail: `"net/http/httptrace"`, Kind: "package"},
            - 		{Label: "httputil", Detail: `"net/http/httputil"`, Kind: "package"},
            - 	},
            + 	nil,
              )

— watchflakes

gopherbot · 2023-11-03T22:30:23Z

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "golang.org/x/tools/gopls/internal/regtest/marker" && test == "TestMarkers" && date >= "2023-05-01"

2023-11-03 21:35 linux-s390x-ibm tools@0ee4d876 go@434af853 x/tools/gopls/internal/regtest/marker.TestMarkers (log)

--- FAIL: TestMarkers (1.60s)
    --- FAIL: TestMarkers/diagnostics/parseerr.txt (1.33s)
        marker.go:580: bad.go:7:15 (diagnostics/parseerr.txt:20:15): no diagnostic at bad.go:7:6 (diagnostics/parseerr.txt:20:6) matches "expected 'IDENT', found '.'"
        marker.go:580: good.go:4:15 (diagnostics/parseerr.txt:26:15): no diagnostic at good.go:4:9-11 (diagnostics/parseerr.txt:26:9-11) matches "a slice"
        marker.go:514: go.mod:1:1 (diagnostics/parseerr.txt:10:1): unexpected diagnostic: "/data/golang/workdir/tmp/TestMarkersdiagnosticsparseerr.txt1145313885/001/work/go.mod:1: unknown directive: package\n/data/golang/workdir/tmp/TestMarkersdiagnosticsparseerr.txt1145313885/001/work/go.mod:3: unknown directive: func\n/data/golang/workdir/tmp/TestMarkersdiagnosticsparseerr.txt1145313885/001/work/go.mod:4:2: unknown directive: append\n/data/golang/workdir/tmp/TestMarkersdiagnosticsparseerr.txt1145313885/001/work/go.mod:6:2: unknown directive: x\n/data/golang/workdir/tmp/TestMarkersdiagnosticsparseerr.txt1145313885/001/work/go.mod:7: unknown directive: }"

— watchflakes

adonovan · 2023-11-03T22:39:23Z

The s390 failure in #60584 (comment) is really weird: it's reading the wrong file out of the gopls/internal/regtest/marker/testdata/diagnostics/parseerr.txt txtar archive. The file named go.mod contains the contents of the (Go) file named bad.go.

gopherbot · 2023-11-04T00:55:21Z

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "golang.org/x/tools/gopls/internal/regtest/marker" && test == "TestMarkers" && date >= "2023-05-01"

2023-11-03 22:05 linux-s390x-ibm tools@9f1cca37 go@998fdce3 x/tools/gopls/internal/regtest/marker.TestMarkers (log)

--- FAIL: TestMarkers (3.63s)
    --- FAIL: TestMarkers/diagnostics/generated.txt (2.88s)
        marker.go:514: go.mod:1:1 (diagnostics/generated.txt:4:1): unexpected diagnostic: "/data/golang/workdir/tmp/TestMarkersdiagnosticsgenerated.txt537923998/001/work/go.mod:1: unknown directive: package\n/data/golang/workdir/tmp/TestMarkersdiagnosticsgenerated.txt537923998/001/work/go.mod:3: unknown block type: import\n/data/golang/workdir/tmp/TestMarkersdiagnosticsgenerated.txt537923998/001/work/go.mod:8: unknown directive: func\n/data/golang/workdir/tmp/TestMarkersdiagnosticsgenerated.txt537923998/001/work/go.mod:9:2: unknown directive: var\n/data/golang/workdir/tmp/TestMarkersdiagnosticsgenerated.txt537923998/001/work/go.mod:10:2: unknown directive: var\n/data/golang/workdir/tmp/TestMarkersdiagnosticsgenerated.txt537923998/001/work/go.mod:11: unknown directive: }\n/data/golang/workdir/tmp/TestMarkersdiagnosticsgenerated.txt537923998/001/work/go.mod:13: unknown directive: type\n/data/golang/workdir/tmp/TestMarkersdiagnosticsgenerated.txt537923998/001/work/go.mod:15: unknown directive: func\n/data/golang/workdir/tmp/TestMarkersdiagnosticsgenerated.txt537923998/001/work/go.mod:16: unknown directive: func"
    --- FAIL: TestMarkers/definition/misc.txt (9.80s)
        marker.go:580: a.go:70:9 (definition/misc.txt:76:9): hover markdown mismatch (-want +got):
            --- want
            +++ got
            @@ -4,5 +4,3 @@
             }
             ```
...
            -
        marker.go:580: random.go:30:34 (definition/misc.txt:119:34): hover markdown mismatch (-want +got):
            --- want
            +++ got
            @@ -2,5 +2,3 @@
             func (*Pos).Sum() int
             ```

            -[`(a.Pos).Sum` on pkg.go.dev](https://pkg.go.dev/mod.com#Pos.Sum)
            -

— watchflakes

findleyr · 2023-11-04T13:15:38Z

Absolutely bizarre. Also, note this:

/data/golang/workdir/tmp/TestMarkersdiagnosticsparseerr.txt1145313885/001/work/go.mod:6:2: unknown directive: x

There is no line starting with 'x' in that file (though the character 'x' occurs in the word 'syntax'. Is this file just entirely corrupted?

findleyr · 2023-11-04T13:28:10Z

The other failure is similarly confusing, though less obviously corruption: somehow gopls is otherwise working, but excludes pkg.go.dev links. These links should only be omitted if the "linksInHover" option is set, or if the link matches GOPRIVATE. It doesn't seem likely that a bug causes one of those conditions to be set, yet everything else appears to work normally. I would expect that e.g. a configuration race or go env corruption would manifest in more errors.

gopherbot · 2023-11-08T16:17:07Z

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "golang.org/x/tools/gopls/internal/regtest/marker" && test == "TestMarkers" && date >= "2023-05-01"

2023-11-07 21:15 linux-s390x-ibm tools@e7fb31ad go@1e91861f x/tools/gopls/internal/regtest/marker.TestMarkers (log)

--- FAIL: TestMarkers (2.82s)
    --- FAIL: TestMarkers/completion/foobarbaz.txt (3.60s)
        marker.go:580: foo/foo.go:26:47 (completion/foobarbaz.txt:46:47): no diagnostic at foo/foo.go:26:3-6 (completion/foobarbaz.txt:46:3-6) matches "(undefined|undeclared)"
        marker.go:580: bar/bar.go:18:60 (completion/foobarbaz.txt:71:60): no diagnostic at bar/bar.go:18:7-8 (completion/foobarbaz.txt:71:7-8) matches "expected type"
        marker.go:580: bar/bar.go:29:23 (completion/foobarbaz.txt:82:23): no diagnostic at bar/bar.go:29:6-9 (completion/foobarbaz.txt:82:6-9) matches "unkeyed fields"
        marker.go:580: bar/bar.go:32:25 (completion/foobarbaz.txt:85:25): no diagnostic at bar/bar.go:32:8-11 (completion/foobarbaz.txt:85:8-11) matches "unkeyed fields"
        marker.go:580: baz/baz.go:14:16 (completion/foobarbaz.txt:120:16): no diagnostic at baz/baz.go:14:13 (completion/foobarbaz.txt:120:13) matches "must be function call"
        marker.go:580: literal_snippets/literal_snippets.go:18:22 (completion/foobarbaz.txt:337:22): no completion item found matching &[]int{} (got: [])
        marker.go:580: literal_snippets/literal_snippets.go:22:14 (completion/foobarbaz.txt:341:14): no completion item found matching []int{} (got: [])
        marker.go:580: literal_snippets/literal_snippets.go:23:14 (completion/foobarbaz.txt:342:14): no completion item found matching make([]int, 0) (got: [])
...
        marker.go:580: literal_snippets/literal_snippets.go:206:8 (completion/foobarbaz.txt:525:8): no completion item found matching []int{} (got: [])
        marker.go:580: literal_snippets/literal_snippets.go:221:14 (completion/foobarbaz.txt:540:14): Completion(...) returned unexpect results (-want +got):
              []regtest.completionItem(
            - 	{{Label: "func(...) {}", Kind: "var"}},
            + 	nil,
              )
        marker.go:580: literal_snippets/literal_snippets.go:221:38 (completion/foobarbaz.txt:540:38): no completion item found matching func(...) {} (got: [])
    --- FAIL: TestMarkers/diagnostics/analyzers.txt (17.64s)
        marker.go:580: bad_test.go:19:24 (diagnostics/analyzers.txt:30:24): no diagnostic at bad_test.go:19:2-21 (diagnostics/analyzers.txt:30:2-21) matches "example.com.printfWrapper format %s reads arg #1, but call has 0 args"
        marker.go:514: bad_test.go:19:2 (diagnostics/analyzers.txt:30:2): unexpected diagnostic: "mod.com/b.printfWrapper format %s reads arg #1, but call has 0 args"

— watchflakes

gopherbot · 2023-11-20T18:37:19Z

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "golang.org/x/tools/gopls/internal/regtest/marker" && test == "TestMarkers" && date >= "2023-05-01"

2023-11-20 17:36 linux-amd64-longtest tools@25294814 go@ee6b3479 x/tools/gopls/internal/regtest/marker.TestMarkers (log)

--- FAIL: TestMarkers (0.96s)
    --- FAIL: TestMarkers/rename/issue60752.txt (2.05s)
        marker.go:609: a/recv.go:3:22 (rename/issue60752.txt:24:22): converting args: cannot convert t (expect.Identifier) to string
        marker.go:609: a/param.go:3:19 (rename/issue60752.txt:29:19): converting args: cannot convert t (expect.Identifier) to string
        marker.go:609: a/result.go:3:30 (rename/issue60752.txt:34:30): converting args: cannot convert t (expect.Identifier) to string
        marker.go:609: a/typeparam.go:3:21 (rename/issue60752.txt:39:21): converting args: cannot convert t (expect.Identifier) to string
    --- FAIL: TestMarkers/rename/generics.txt (1.23s)
        marker.go:609: g.go:9:12 (rename/generics.txt:40:12): rename failed: work/g.go:8:8: renaming this type "R" to "S"
            work/g.go:8:17:	would cause this reference to become shadowed
            work/g.go:3:6:	by this intervening type definition. (Use @renameerr for expected errors.)

2023-11-20 17:36 linux-arm64-longtest tools@25294814 go@ee6b3479 x/tools/gopls/internal/regtest/marker.TestMarkers (log)

--- FAIL: TestMarkers (0.59s)
    --- FAIL: TestMarkers/rename/issue60752.txt (0.84s)
        marker.go:609: a/recv.go:3:22 (rename/issue60752.txt:24:22): converting args: cannot convert t (expect.Identifier) to string
        marker.go:609: a/param.go:3:19 (rename/issue60752.txt:29:19): converting args: cannot convert t (expect.Identifier) to string
        marker.go:609: a/result.go:3:30 (rename/issue60752.txt:34:30): converting args: cannot convert t (expect.Identifier) to string
        marker.go:609: a/typeparam.go:3:21 (rename/issue60752.txt:39:21): converting args: cannot convert t (expect.Identifier) to string
    --- FAIL: TestMarkers/rename/generics.txt (0.59s)
        marker.go:609: g.go:9:12 (rename/generics.txt:40:12): rename failed: work/g.go:8:8: renaming this type "R" to "S"
            work/g.go:8:17:	would cause this reference to become shadowed
            work/g.go:3:6:	by this intervening type definition. (Use @renameerr for expected errors.)

— watchflakes

gopherbot · 2023-11-20T18:58:07Z

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "golang.org/x/tools/gopls/internal/regtest/marker" && test == "TestMarkers" && date >= "2023-05-01"

2023-11-20 17:36 darwin-amd64-11_0 tools@25294814 go@e1dc209b x/tools/gopls/internal/regtest/marker.TestMarkers (log)

--- FAIL: TestMarkers (1.81s)
    --- FAIL: TestMarkers/rename/issue60752.txt (9.46s)
        marker.go:609: a/recv.go:3:22 (rename/issue60752.txt:24:22): converting args: cannot convert t (expect.Identifier) to string
        marker.go:609: a/param.go:3:19 (rename/issue60752.txt:29:19): converting args: cannot convert t (expect.Identifier) to string
        marker.go:609: a/result.go:3:30 (rename/issue60752.txt:34:30): converting args: cannot convert t (expect.Identifier) to string
        marker.go:609: a/typeparam.go:3:21 (rename/issue60752.txt:39:21): converting args: cannot convert t (expect.Identifier) to string
    --- FAIL: TestMarkers/rename/generics.txt (6.12s)
        marker.go:609: g.go:9:12 (rename/generics.txt:40:12): rename failed: work/g.go:8:8: renaming this type "R" to "S"
            work/g.go:8:17:	would cause this reference to become shadowed
            work/g.go:3:6:	by this intervening type definition. (Use @renameerr for expected errors.)

2023-11-20 17:36 darwin-amd64-11_0 tools@25294814 go@4952f411 x/tools/gopls/internal/regtest/marker.TestMarkers (log)

--- FAIL: TestMarkers (1.38s)
    --- FAIL: TestMarkers/rename/issue60752.txt (11.60s)
        marker.go:609: a/recv.go:3:22 (rename/issue60752.txt:24:22): converting args: cannot convert t (expect.Identifier) to string
        marker.go:609: a/param.go:3:19 (rename/issue60752.txt:29:19): converting args: cannot convert t (expect.Identifier) to string
        marker.go:609: a/result.go:3:30 (rename/issue60752.txt:34:30): converting args: cannot convert t (expect.Identifier) to string
        marker.go:609: a/typeparam.go:3:21 (rename/issue60752.txt:39:21): converting args: cannot convert t (expect.Identifier) to string
    --- FAIL: TestMarkers/rename/generics.txt (13.41s)
        marker.go:609: g.go:9:12 (rename/generics.txt:40:12): rename failed: work/g.go:8:8: renaming this type "R" to "S"
            work/g.go:8:17:	would cause this reference to become shadowed
            work/g.go:3:6:	by this intervening type definition. (Use @renameerr for expected errors.)

2023-11-20 17:36 darwin-amd64-12_0 tools@25294814 go@e1dc209b x/tools/gopls/internal/regtest/marker.TestMarkers (log)

--- FAIL: TestMarkers (1.41s)
    --- FAIL: TestMarkers/rename/issue60752.txt (13.51s)
        marker.go:609: a/recv.go:3:22 (rename/issue60752.txt:24:22): converting args: cannot convert t (expect.Identifier) to string
        marker.go:609: a/param.go:3:19 (rename/issue60752.txt:29:19): converting args: cannot convert t (expect.Identifier) to string
        marker.go:609: a/result.go:3:30 (rename/issue60752.txt:34:30): converting args: cannot convert t (expect.Identifier) to string
        marker.go:609: a/typeparam.go:3:21 (rename/issue60752.txt:39:21): converting args: cannot convert t (expect.Identifier) to string
    --- FAIL: TestMarkers/rename/generics.txt (15.75s)
        marker.go:609: g.go:9:12 (rename/generics.txt:40:12): rename failed: work/g.go:8:8: renaming this type "R" to "S"
            work/g.go:8:17:	would cause this reference to become shadowed
            work/g.go:3:6:	by this intervening type definition. (Use @renameerr for expected errors.)

2023-11-20 17:36 darwin-amd64-12_0 tools@25294814 go@4952f411 x/tools/gopls/internal/regtest/marker.TestMarkers (log)

--- FAIL: TestMarkers (0.70s)
    --- FAIL: TestMarkers/rename/issue60752.txt (8.66s)
        marker.go:609: a/recv.go:3:22 (rename/issue60752.txt:24:22): converting args: cannot convert t (expect.Identifier) to string
        marker.go:609: a/param.go:3:19 (rename/issue60752.txt:29:19): converting args: cannot convert t (expect.Identifier) to string
        marker.go:609: a/result.go:3:30 (rename/issue60752.txt:34:30): converting args: cannot convert t (expect.Identifier) to string
        marker.go:609: a/typeparam.go:3:21 (rename/issue60752.txt:39:21): converting args: cannot convert t (expect.Identifier) to string
    --- FAIL: TestMarkers/rename/generics.txt (6.88s)
        marker.go:609: g.go:9:12 (rename/generics.txt:40:12): rename failed: work/g.go:8:8: renaming this type "R" to "S"
            work/g.go:8:17:	would cause this reference to become shadowed
            work/g.go:3:6:	by this intervening type definition. (Use @renameerr for expected errors.)

2023-11-20 17:36 darwin-amd64-13 tools@25294814 go@e1dc209b x/tools/gopls/internal/regtest/marker.TestMarkers (log)

--- FAIL: TestMarkers (1.30s)
    --- FAIL: TestMarkers/rename/issue60752.txt (5.69s)
        marker.go:609: a/recv.go:3:22 (rename/issue60752.txt:24:22): converting args: cannot convert t (expect.Identifier) to string
        marker.go:609: a/param.go:3:19 (rename/issue60752.txt:29:19): converting args: cannot convert t (expect.Identifier) to string
        marker.go:609: a/result.go:3:30 (rename/issue60752.txt:34:30): converting args: cannot convert t (expect.Identifier) to string
        marker.go:609: a/typeparam.go:3:21 (rename/issue60752.txt:39:21): converting args: cannot convert t (expect.Identifier) to string
    --- FAIL: TestMarkers/rename/generics.txt (4.55s)
        marker.go:609: g.go:9:12 (rename/generics.txt:40:12): rename failed: work/g.go:8:8: renaming this type "R" to "S"
            work/g.go:8:17:	would cause this reference to become shadowed
            work/g.go:3:6:	by this intervening type definition. (Use @renameerr for expected errors.)

2023-11-20 17:36 darwin-amd64-13 tools@25294814 go@4952f411 x/tools/gopls/internal/regtest/marker.TestMarkers (log)

--- FAIL: TestMarkers (1.46s)
    --- FAIL: TestMarkers/rename/issue60752.txt (4.68s)
        marker.go:609: a/recv.go:3:22 (rename/issue60752.txt:24:22): converting args: cannot convert t (expect.Identifier) to string
        marker.go:609: a/param.go:3:19 (rename/issue60752.txt:29:19): converting args: cannot convert t (expect.Identifier) to string
        marker.go:609: a/result.go:3:30 (rename/issue60752.txt:34:30): converting args: cannot convert t (expect.Identifier) to string
        marker.go:609: a/typeparam.go:3:21 (rename/issue60752.txt:39:21): converting args: cannot convert t (expect.Identifier) to string
    --- FAIL: TestMarkers/rename/generics.txt (5.35s)
        marker.go:609: g.go:9:12 (rename/generics.txt:40:12): rename failed: work/g.go:8:8: renaming this type "R" to "S"
            work/g.go:8:17:	would cause this reference to become shadowed
            work/g.go:3:6:	by this intervening type definition. (Use @renameerr for expected errors.)

2023-11-20 17:36 illumos-amd64 tools@25294814 go@4952f411 x/tools/gopls/internal/regtest/marker.TestMarkers (log)

--- FAIL: TestMarkers (0.39s)
    --- FAIL: TestMarkers/rename/issue60752.txt (0.74s)
        marker.go:609: a/recv.go:3:22 (rename/issue60752.txt:24:22): converting args: cannot convert t (expect.Identifier) to string
        marker.go:609: a/param.go:3:19 (rename/issue60752.txt:29:19): converting args: cannot convert t (expect.Identifier) to string
        marker.go:609: a/result.go:3:30 (rename/issue60752.txt:34:30): converting args: cannot convert t (expect.Identifier) to string
        marker.go:609: a/typeparam.go:3:21 (rename/issue60752.txt:39:21): converting args: cannot convert t (expect.Identifier) to string
    --- FAIL: TestMarkers/rename/generics.txt (0.82s)
        marker.go:609: g.go:9:12 (rename/generics.txt:40:12): rename failed: work/g.go:8:8: renaming this type "R" to "S"
            work/g.go:8:17:	would cause this reference to become shadowed
            work/g.go:3:6:	by this intervening type definition. (Use @renameerr for expected errors.)

— watchflakes

gopherbot · 2023-11-20T20:00:39Z

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "golang.org/x/tools/gopls/internal/regtest/marker" && test == "TestMarkers" && date >= "2023-05-01"

2023-11-20 17:36 solaris-amd64-oraclerel tools@25294814 go@e1dc209b x/tools/gopls/internal/regtest/marker.TestMarkers (log)

--- FAIL: TestMarkers (0.44s)
    --- FAIL: TestMarkers/rename/issue60752.txt (12.11s)
        marker.go:609: a/recv.go:3:22 (rename/issue60752.txt:24:22): converting args: cannot convert t (expect.Identifier) to string
        marker.go:609: a/param.go:3:19 (rename/issue60752.txt:29:19): converting args: cannot convert t (expect.Identifier) to string
        marker.go:609: a/result.go:3:30 (rename/issue60752.txt:34:30): converting args: cannot convert t (expect.Identifier) to string
        marker.go:609: a/typeparam.go:3:21 (rename/issue60752.txt:39:21): converting args: cannot convert t (expect.Identifier) to string
    --- FAIL: TestMarkers/rename/generics.txt (10.58s)
        marker.go:609: g.go:9:12 (rename/generics.txt:40:12): rename failed: work/g.go:8:8: renaming this type "R" to "S"
            work/g.go:8:17:	would cause this reference to become shadowed
            work/g.go:3:6:	by this intervening type definition. (Use @renameerr for expected errors.)

2023-11-20 17:36 solaris-amd64-oraclerel tools@25294814 go@4952f411 x/tools/gopls/internal/regtest/marker.TestMarkers (log)

--- FAIL: TestMarkers (0.44s)
    --- FAIL: TestMarkers/rename/issue60752.txt (18.86s)
        marker.go:609: a/recv.go:3:22 (rename/issue60752.txt:24:22): converting args: cannot convert t (expect.Identifier) to string
        marker.go:609: a/param.go:3:19 (rename/issue60752.txt:29:19): converting args: cannot convert t (expect.Identifier) to string
        marker.go:609: a/result.go:3:30 (rename/issue60752.txt:34:30): converting args: cannot convert t (expect.Identifier) to string
        marker.go:609: a/typeparam.go:3:21 (rename/issue60752.txt:39:21): converting args: cannot convert t (expect.Identifier) to string
    --- FAIL: TestMarkers/rename/generics.txt (14.97s)
        marker.go:609: g.go:9:12 (rename/generics.txt:40:12): rename failed: work/g.go:8:8: renaming this type "R" to "S"
            work/g.go:8:17:	would cause this reference to become shadowed
            work/g.go:3:6:	by this intervening type definition. (Use @renameerr for expected errors.)

— watchflakes

gopherbot · 2023-11-20T20:21:32Z

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "golang.org/x/tools/gopls/internal/regtest/marker" && test == "TestMarkers" && date >= "2023-05-01"

2023-11-20 17:36 darwin-amd64-nocgo tools@25294814 go@e1dc209b x/tools/gopls/internal/regtest/marker.TestMarkers (log)

--- FAIL: TestMarkers (2.11s)
    --- FAIL: TestMarkers/rename/generics.txt (9.02s)
        marker.go:609: g.go:9:12 (rename/generics.txt:40:12): rename failed: work/g.go:8:8: renaming this type "R" to "S"
            work/g.go:8:17:	would cause this reference to become shadowed
            work/g.go:3:6:	by this intervening type definition. (Use @renameerr for expected errors.)
    --- FAIL: TestMarkers/rename/issue60752.txt (8.05s)
        marker.go:609: a/recv.go:3:22 (rename/issue60752.txt:24:22): converting args: cannot convert t (expect.Identifier) to string
        marker.go:609: a/param.go:3:19 (rename/issue60752.txt:29:19): converting args: cannot convert t (expect.Identifier) to string
        marker.go:609: a/result.go:3:30 (rename/issue60752.txt:34:30): converting args: cannot convert t (expect.Identifier) to string
        marker.go:609: a/typeparam.go:3:21 (rename/issue60752.txt:39:21): converting args: cannot convert t (expect.Identifier) to string

2023-11-20 17:36 darwin-amd64-nocgo tools@25294814 go@4952f411 x/tools/gopls/internal/regtest/marker.TestMarkers (log)

--- FAIL: TestMarkers (1.22s)
    --- FAIL: TestMarkers/rename/issue60752.txt (7.82s)
        marker.go:609: a/recv.go:3:22 (rename/issue60752.txt:24:22): converting args: cannot convert t (expect.Identifier) to string
        marker.go:609: a/param.go:3:19 (rename/issue60752.txt:29:19): converting args: cannot convert t (expect.Identifier) to string
        marker.go:609: a/result.go:3:30 (rename/issue60752.txt:34:30): converting args: cannot convert t (expect.Identifier) to string
        marker.go:609: a/typeparam.go:3:21 (rename/issue60752.txt:39:21): converting args: cannot convert t (expect.Identifier) to string
    --- FAIL: TestMarkers/rename/generics.txt (15.40s)
        marker.go:609: g.go:9:12 (rename/generics.txt:40:12): rename failed: work/g.go:8:8: renaming this type "R" to "S"
            work/g.go:8:17:	would cause this reference to become shadowed
            work/g.go:3:6:	by this intervening type definition. (Use @renameerr for expected errors.)

2023-11-20 17:36 freebsd-arm64-dmgk tools@25294814 go@4952f411 x/tools/gopls/internal/regtest/marker.TestMarkers (log)

--- FAIL: TestMarkers (0.45s)
    --- FAIL: TestMarkers/rename/issue60752.txt (1.31s)
        marker.go:609: a/recv.go:3:22 (rename/issue60752.txt:24:22): converting args: cannot convert t (expect.Identifier) to string
        marker.go:609: a/param.go:3:19 (rename/issue60752.txt:29:19): converting args: cannot convert t (expect.Identifier) to string
        marker.go:609: a/result.go:3:30 (rename/issue60752.txt:34:30): converting args: cannot convert t (expect.Identifier) to string
        marker.go:609: a/typeparam.go:3:21 (rename/issue60752.txt:39:21): converting args: cannot convert t (expect.Identifier) to string
    --- FAIL: TestMarkers/rename/generics.txt (0.89s)
        marker.go:609: g.go:9:12 (rename/generics.txt:40:12): rename failed: work/g.go:8:8: renaming this type "R" to "S"
            work/g.go:8:17:	would cause this reference to become shadowed
            work/g.go:3:6:	by this intervening type definition. (Use @renameerr for expected errors.)

— watchflakes

gopherbot · 2023-11-21T21:41:19Z

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "golang.org/x/tools/gopls/internal/regtest/marker" && test == "TestMarkers" && date >= "2023-05-01"

2023-11-20 17:36 darwin-amd64-11_0 tools@25294814 go@ee6b3479 x/tools/gopls/internal/regtest/marker.TestMarkers (log)

--- FAIL: TestMarkers (1.80s)
    --- FAIL: TestMarkers/rename/issue60752.txt (9.42s)
        marker.go:609: a/recv.go:3:22 (rename/issue60752.txt:24:22): converting args: cannot convert t (expect.Identifier) to string
        marker.go:609: a/param.go:3:19 (rename/issue60752.txt:29:19): converting args: cannot convert t (expect.Identifier) to string
        marker.go:609: a/result.go:3:30 (rename/issue60752.txt:34:30): converting args: cannot convert t (expect.Identifier) to string
        marker.go:609: a/typeparam.go:3:21 (rename/issue60752.txt:39:21): converting args: cannot convert t (expect.Identifier) to string
    --- FAIL: TestMarkers/rename/generics.txt (17.68s)
        marker.go:609: g.go:9:12 (rename/generics.txt:40:12): rename failed: work/g.go:8:8: renaming this type "R" to "S"
            work/g.go:8:17:	would cause this reference to become shadowed
            work/g.go:3:6:	by this intervening type definition. (Use @renameerr for expected errors.)

2023-11-20 17:36 darwin-amd64-longtest tools@25294814 go@ee6b3479 x/tools/gopls/internal/regtest/marker.TestMarkers (log)

--- FAIL: TestMarkers (6.58s)
    --- FAIL: TestMarkers/rename/issue60752.txt (5.95s)
        marker.go:609: a/recv.go:3:22 (rename/issue60752.txt:24:22): converting args: cannot convert t (expect.Identifier) to string
        marker.go:609: a/param.go:3:19 (rename/issue60752.txt:29:19): converting args: cannot convert t (expect.Identifier) to string
        marker.go:609: a/result.go:3:30 (rename/issue60752.txt:34:30): converting args: cannot convert t (expect.Identifier) to string
        marker.go:609: a/typeparam.go:3:21 (rename/issue60752.txt:39:21): converting args: cannot convert t (expect.Identifier) to string
    --- FAIL: TestMarkers/rename/generics.txt (5.42s)
        marker.go:609: g.go:9:12 (rename/generics.txt:40:12): rename failed: work/g.go:8:8: renaming this type "R" to "S"
            work/g.go:8:17:	would cause this reference to become shadowed
            work/g.go:3:6:	by this intervening type definition. (Use @renameerr for expected errors.)

2023-11-20 17:36 linux-386-longtest tools@25294814 go@ee6b3479 x/tools/gopls/internal/regtest/marker.TestMarkers (log)

--- FAIL: TestMarkers (1.03s)
    --- FAIL: TestMarkers/rename/issue60752.txt (0.32s)
        marker.go:609: a/recv.go:3:22 (rename/issue60752.txt:24:22): converting args: cannot convert t (expect.Identifier) to string
        marker.go:609: a/param.go:3:19 (rename/issue60752.txt:29:19): converting args: cannot convert t (expect.Identifier) to string
        marker.go:609: a/result.go:3:30 (rename/issue60752.txt:34:30): converting args: cannot convert t (expect.Identifier) to string
        marker.go:609: a/typeparam.go:3:21 (rename/issue60752.txt:39:21): converting args: cannot convert t (expect.Identifier) to string
    --- FAIL: TestMarkers/rename/generics.txt (0.39s)
        marker.go:609: g.go:9:12 (rename/generics.txt:40:12): rename failed: work/g.go:8:8: renaming this type "R" to "S"
            work/g.go:8:17:	would cause this reference to become shadowed
            work/g.go:3:6:	by this intervening type definition. (Use @renameerr for expected errors.)

2023-11-20 17:36 linux-amd64-longtest-race tools@25294814 go@ee6b3479 x/tools/gopls/internal/regtest/marker.TestMarkers (log)

--- FAIL: TestMarkers (1.30s)
    --- FAIL: TestMarkers/rename/issue60752.txt (1.78s)
        marker.go:609: a/recv.go:3:22 (rename/issue60752.txt:24:22): converting args: cannot convert t (expect.Identifier) to string
        marker.go:609: a/param.go:3:19 (rename/issue60752.txt:29:19): converting args: cannot convert t (expect.Identifier) to string
        marker.go:609: a/result.go:3:30 (rename/issue60752.txt:34:30): converting args: cannot convert t (expect.Identifier) to string
        marker.go:609: a/typeparam.go:3:21 (rename/issue60752.txt:39:21): converting args: cannot convert t (expect.Identifier) to string
    --- FAIL: TestMarkers/rename/generics.txt (1.28s)
        marker.go:609: g.go:9:12 (rename/generics.txt:40:12): rename failed: work/g.go:8:8: renaming this type "R" to "S"
            work/g.go:8:17:	would cause this reference to become shadowed
            work/g.go:3:6:	by this intervening type definition. (Use @renameerr for expected errors.)

2023-11-20 17:36 windows-amd64-longtest tools@25294814 go@ee6b3479 x/tools/gopls/internal/regtest/marker.TestMarkers (log)

--- FAIL: TestMarkers (1.38s)
    --- FAIL: TestMarkers/rename\issue60752.txt (5.15s)
        marker.go:609: a/recv.go:3:22 (rename\issue60752.txt:24:22): converting args: cannot convert t (expect.Identifier) to string
        marker.go:609: a/param.go:3:19 (rename\issue60752.txt:29:19): converting args: cannot convert t (expect.Identifier) to string
        marker.go:609: a/result.go:3:30 (rename\issue60752.txt:34:30): converting args: cannot convert t (expect.Identifier) to string
        marker.go:609: a/typeparam.go:3:21 (rename\issue60752.txt:39:21): converting args: cannot convert t (expect.Identifier) to string
    --- FAIL: TestMarkers/rename\generics.txt (6.67s)
        marker.go:609: g.go:9:12 (rename\generics.txt:40:12): rename failed: work/g.go:8:8: renaming this type "R" to "S"
            work/g.go:8:17:	would cause this reference to become shadowed
            work/g.go:3:6:	by this intervening type definition. (Use @renameerr for expected errors.)

— watchflakes

gopherbot · 2023-11-24T09:21:20Z

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "golang.org/x/tools/gopls/internal/regtest/marker" && test == "TestMarkers" && date >= "2023-05-01"

2023-11-20 17:36 freebsd-riscv64-unmatched tools@25294814 go@ee6b3479 x/tools/gopls/internal/regtest/marker.TestMarkers (log)

--- FAIL: TestMarkers (9.16s)
    --- FAIL: TestMarkers/rename/issue60752.txt (5.44s)
        marker.go:609: a/recv.go:3:22 (rename/issue60752.txt:24:22): converting args: cannot convert t (expect.Identifier) to string
        marker.go:609: a/param.go:3:19 (rename/issue60752.txt:29:19): converting args: cannot convert t (expect.Identifier) to string
        marker.go:609: a/result.go:3:30 (rename/issue60752.txt:34:30): converting args: cannot convert t (expect.Identifier) to string
        marker.go:609: a/typeparam.go:3:21 (rename/issue60752.txt:39:21): converting args: cannot convert t (expect.Identifier) to string
    --- FAIL: TestMarkers/rename/generics.txt (5.90s)
        marker.go:609: g.go:9:12 (rename/generics.txt:40:12): rename failed: work/g.go:8:8: renaming this type "R" to "S"
            work/g.go:8:17:	would cause this reference to become shadowed
            work/g.go:3:6:	by this intervening type definition. (Use @renameerr for expected errors.)

— watchflakes

gopherbot · 2023-11-24T22:11:29Z

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "golang.org/x/tools/gopls/internal/regtest/marker" && test == "TestMarkers" && date >= "2023-05-01"

2023-11-20 17:36 freebsd-arm64-dmgk tools@25294814 go@e1dc209b x/tools/gopls/internal/regtest/marker.TestMarkers (log)

--- FAIL: TestMarkers (0.56s)
    --- FAIL: TestMarkers/rename/issue60752.txt (1.22s)
        marker.go:609: a/recv.go:3:22 (rename/issue60752.txt:24:22): converting args: cannot convert t (expect.Identifier) to string
        marker.go:609: a/param.go:3:19 (rename/issue60752.txt:29:19): converting args: cannot convert t (expect.Identifier) to string
        marker.go:609: a/result.go:3:30 (rename/issue60752.txt:34:30): converting args: cannot convert t (expect.Identifier) to string
        marker.go:609: a/typeparam.go:3:21 (rename/issue60752.txt:39:21): converting args: cannot convert t (expect.Identifier) to string
    --- FAIL: TestMarkers/rename/generics.txt (1.86s)
        marker.go:609: g.go:9:12 (rename/generics.txt:40:12): rename failed: work/g.go:8:8: renaming this type "R" to "S"
            work/g.go:8:17:	would cause this reference to become shadowed
            work/g.go:3:6:	by this intervening type definition. (Use @renameerr for expected errors.)

— watchflakes

findleyr · 2024-01-12T23:02:46Z

These tests have been moved, and are no longer flaking. Marking as fixed.

bcmills added NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. gopls Issues related to the Go language server, gopls. labels Jun 3, 2023

bcmills added this to Test Flakes Jun 3, 2023

gopherbot added the Tools This label describes issues relating to any tools in the x/tools repository. label Jun 3, 2023

gopherbot added this to the Unreleased milestone Jun 3, 2023

bcmills mentioned this issue Jun 3, 2023

x/tools/gopls/internal/regtest/marker: TestMarkers failing on android builders at Go 1.20 and above #58396

Closed

bcmills modified the milestones: Unreleased, gopls/unplanned Jun 3, 2023

findleyr modified the milestones: gopls/unplanned, gopls/v0.12.5 Jun 26, 2023

findleyr modified the milestones: gopls/v0.14.0, gopls/v0.14.1 Oct 9, 2023

findleyr modified the milestones: gopls/v0.14.2, gopls/v0.15.0 Nov 14, 2023

findleyr closed this as completed Jan 12, 2024

github-project-automation bot moved this to Done in Test Flakes Jan 12, 2024

findleyr self-assigned this Jan 17, 2024

golang locked and limited conversation to collaborators Jan 16, 2025

gopherbot added the FrozenDueToAge label Jan 16, 2025

x/tools/gopls/internal/regtest/marker: TestMarkers failures #60584

x/tools/gopls/internal/regtest/marker: TestMarkers failures #60584

Comments

bcmills commented Jun 3, 2023

bcmills commented Jun 3, 2023

gopherbot commented Jun 3, 2023

gopherbot commented Jun 3, 2023

gopherbot commented Jun 5, 2023

gopherbot commented Jun 6, 2023

gopherbot commented Jun 9, 2023

gopherbot commented Jun 11, 2023

gopherbot commented Jun 13, 2023

gopherbot commented Jun 13, 2023

gopherbot commented Jun 13, 2023

gopherbot commented Jun 14, 2023

gopherbot commented Jun 14, 2023

gopherbot commented Jun 15, 2023

gopherbot commented Jun 15, 2023

gopherbot commented Jun 15, 2023

gopherbot commented Jun 17, 2023

gopherbot commented Jun 20, 2023

gopherbot commented Jun 20, 2023

gopherbot commented Jun 21, 2023

gopherbot commented Jun 24, 2023

gopherbot commented Sep 28, 2023

gopherbot commented Sep 28, 2023

gopherbot commented Sep 28, 2023

gopherbot commented Sep 28, 2023

gopherbot commented Sep 28, 2023

gopherbot commented Sep 28, 2023

gopherbot commented Nov 3, 2023

adonovan commented Nov 3, 2023

gopherbot commented Nov 4, 2023

findleyr commented Nov 4, 2023

findleyr commented Nov 4, 2023

gopherbot commented Nov 8, 2023

gopherbot commented Nov 20, 2023

gopherbot commented Nov 20, 2023

gopherbot commented Nov 20, 2023

gopherbot commented Nov 20, 2023

gopherbot commented Nov 21, 2023

gopherbot commented Nov 24, 2023

gopherbot commented Nov 24, 2023

findleyr commented Jan 12, 2024