Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/example: replace references to x/tools/go/loader with x/tools/go/packages #60593

Closed
adonovan opened this issue Jun 4, 2023 · 1 comment
Closed

x/example: replace references to x/tools/go/loader with x/tools/go/packages #60593

adonovan opened this issue Jun 4, 2023 · 1 comment
Assignees
@adonovan
Labels
Analysis Issues related to static analysis (vet, x/tools/go/analysis) Documentation Issues describing a change to documentation. FrozenDueToAge
Milestone
Unreleased

Comments

@adonovan
Copy link
Member

adonovan commented Jun 4, 2023

The go/types tutorial at https://github.com/golang/example/tree/master/gotypes uses the old loader package in many examples. That package cannot handle modules correctly and is deprecated; all users should use go/packages instead. Let's update the doc to avoid steering people in the wrong direction.

See also #35872
@adonovan adonovan self-assigned this Jun 4, 2023
@gopherbot gopherbot added this to the Unreleased milestone Jun 4, 2023
@adonovan adonovan added Documentation Issues describing a change to documentation. Analysis Issues related to static analysis (vet, x/tools/go/analysis) labels Jun 4, 2023
@gopherbot
Copy link
Contributor

Change https://go.dev/cl/534695 mentions this issue: gotypes: stop directing people to golang.org/x/tools/go/loader

next2golang added a commit to next2golang/go-sample that referenced this issue Apr 19, 2024
@next2golang
gotypes: stop directing people to golang.org/x/tools/go/loader
eda2f8d 
It is very obsolete. Use go/packages instead.

Also, add a go generate command to weave the README.

Fixes golang/go#60593

Change-Id: Ifaf3ffa588dc3e65fb1e96b39b249a9084d66451
Reviewed-on: https://go-review.googlesource.com/c/example/+/534695
Reviewed-by: Robert Findley <[email protected]>
Run-TryBot: Robert Findley <[email protected]>
Auto-Submit: Alan Donovan <[email protected]>
TryBot-Result: Gopher Robot <[email protected]>
Commit-Queue: Alan Donovan <[email protected]>
@golang golang locked and limited conversation to collaborators Oct 12, 2024
astro0099 pushed a commit to astro0099/golang-example that referenced this issue Nov 20, 2024
@adonovan @gopherbot
gotypes: stop directing people to golang.org/x/tools/go/loader
9cb2a2d 
It is very obsolete. Use go/packages instead.

Also, add a go generate command to weave the README.

Fixes golang/go#60593

Change-Id: Ifaf3ffa588dc3e65fb1e96b39b249a9084d66451
Reviewed-on: https://go-review.googlesource.com/c/example/+/534695
Reviewed-by: Robert Findley <[email protected]>
Run-TryBot: Robert Findley <[email protected]>
Auto-Submit: Alan Donovan <[email protected]>
TryBot-Result: Gopher Robot <[email protected]>
Commit-Queue: Alan Donovan <[email protected]>
Dreamcatcher600 added a commit to Dreamcatcher600/GoLang-project that referenced this issue Jan 27, 2025
@Dreamcatcher600
gotypes: stop directing people to golang.org/x/tools/go/loader
8be4b28 
It is very obsolete. Use go/packages instead.

Also, add a go generate command to weave the README.

Fixes golang/go#60593

Change-Id: Ifaf3ffa588dc3e65fb1e96b39b249a9084d66451
Reviewed-on: https://go-review.googlesource.com/c/example/+/534695
Reviewed-by: Robert Findley <[email protected]>
Run-TryBot: Robert Findley <[email protected]>
Auto-Submit: Alan Donovan <[email protected]>
TryBot-Result: Gopher Robot <[email protected]>
Commit-Queue: Alan Donovan <[email protected]>
sweetdream-001 added a commit to sweetdream-001/go-example that referenced this issue Feb 14, 2025
@sweetdream-001
gotypes: stop directing people to golang.org/x/tools/go/loader
ffc9a14 
It is very obsolete. Use go/packages instead.

Also, add a go generate command to weave the README.

Fixes golang/go#60593

Change-Id: Ifaf3ffa588dc3e65fb1e96b39b249a9084d66451
Reviewed-on: https://go-review.googlesource.com/c/example/+/534695
Reviewed-by: Robert Findley <[email protected]>
Run-TryBot: Robert Findley <[email protected]>
Auto-Submit: Alan Donovan <[email protected]>
TryBot-Result: Gopher Robot <[email protected]>
Commit-Queue: Alan Donovan <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@adonovan adonovan

Labels
Analysis Issues related to static analysis (vet, x/tools/go/analysis) Documentation Issues describing a change to documentation. FrozenDueToAge
Projects
None yet
Milestone
Unreleased
Development

No branches or pull requests
2 participants
@adonovan @gopherbot