Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/website: add clear warning against checking go.work into VCS #62179

Closed
goto1134 opened this issue Aug 21, 2023 · 2 comments
Closed

x/website: add clear warning against checking go.work into VCS #62179

goto1134 opened this issue Aug 21, 2023 · 2 comments

Comments

@goto1134
Copy link
Contributor

goto1134 commented Aug 21, 2023

Since the original proposal strongly suggests against checking go.work into VCS:

go.work files should not be checked into version control repos containing modules so that the go.work file in a module does not end up overriding the configuration a user created themselves outside of the module. The go.work documentation should contain clear warnings about this.
https://go.googlesource.com/proposal/+/master/design/45713-workspace.md#rationale-the-file

Please add a clear warning against checking go.work into VCS to the documentation here: https://go.dev/ref/mod#go-work-file

This issue is inspired by the following Reddit discussion: https://www.reddit.com/r/golang/comments/15v8i06/why_gowork_file_should_not_be_committed/

@gopherbot
Copy link
Contributor

Change https://go.dev/cl/521515 mentions this issue: _content/ref/mod.md: add clear warning against checking go.work into VCS

@seankhliao
Copy link
Member

Duplicate of #53502

@seankhliao seankhliao marked this as a duplicate of #53502 Aug 21, 2023
@seankhliao seankhliao closed this as not planned Won't fix, can't repro, duplicate, stale Aug 21, 2023
@golang golang locked and limited conversation to collaborators Aug 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants