Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

crypto: rollback BoringCrypto fips-20220613 update [1.22 backport] #65324

Closed
gopherbot opened this issue Jan 26, 2024 · 3 comments
Closed

crypto: rollback BoringCrypto fips-20220613 update [1.22 backport] #65324

gopherbot opened this issue Jan 26, 2024 · 3 comments
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Milestone
Go1.22

Comments

@gopherbot
Copy link
Contributor

@FiloSottile requested issue #65321 to be considered for backport to the next 1.22 minor release.

@gopherbot please open backport issues for Go 1.20, Go 1.21, and Go 1.22 (if that works).

This is rolling back the #64717 cherry-picks.
@gopherbot gopherbot added the CherryPickCandidate Used during the release process for point releases label Jan 26, 2024
@gopherbot gopherbot mentioned this issue Jan 26, 2024
Closed
@gopherbot
Copy link
Contributor Author

Change https://go.dev/cl/558797 mentions this issue: [release-branch.go1.22] Revert "crypto/internal/boring: upgrade module to fips-20220613" +1

@dmitshur dmitshur added this to the Go1.22 milestone Jan 26, 2024
@dmitshur
Copy link
Contributor

and Go 1.22 (if that works).

It works but isn't needed right now. See https://go.dev/s/release#july--january-week-3-work-on-the-next-release-begins:

While the current release is being stabilized, the tree reopens for work on the next. During this period, fixes intended for the current release need to be cherry-picked onto the release branch. Unlike cherry-picks for minor releases, these changes don’t need a backport issue and don’t need to be approved by the release team. As long as they’re permitted by the freeze policy, they can be reviewed and submitted like any other CL.

Since the issue is already created and referenced by the CL, I'll remove its CherryPickCandidate label, put it into Go1.22 milestone, and move #65321 to Go1.23.

@dmitshur dmitshur added NeedsFix The path to resolution is known, but the work has not been done. and removed CherryPickCandidate Used during the release process for point releases labels Jan 26, 2024
gopherbot pushed a commit that referenced this issue Jan 29, 2024
@FiloSottile @gopherbot
[release-branch.go1.22] Revert "crypto/internal/boring: upgrade modul…
117d7b1 
…e to fips-20220613" +1

This reverts commit 7383b2a
("crypto/internal/boring: upgrade module to fips-20220613") and commit
4106de9 ("crypto/tls: align FIPS-only
mode with BoringSSL policy").

Fixes #65324
Updates #65321
Updates #64717
Updates #62372

Change-Id: I0938b97e5b4904e6532448b8ae76e920d03d0508
Reviewed-on: https://go-review.googlesource.com/c/go/+/558796
Reviewed-by: Michael Knyszek <[email protected]>
Reviewed-by: Roland Shoemaker <[email protected]>
Auto-Submit: Filippo Valsorda <[email protected]>
LUCI-TryBot-Result: Go LUCI <[email protected]>
(cherry picked from commit 09b5de4)
Reviewed-on: https://go-review.googlesource.com/c/go/+/558797
Reviewed-by: Dmitri Shuralyov <[email protected]>
@gopherbot
Copy link
Contributor Author

Closed by merging 117d7b1 to release-branch.go1.22.

@golang golang locked and limited conversation to collaborators Jan 28, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Projects
None yet
Milestone
Go1.22
Development

No branches or pull requests
2 participants
@dmitshur @gopherbot