Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/link: issues with Xcode 16 beta [1.22 backport] #68198

Closed
gopherbot opened this issue Jun 26, 2024 · 7 comments
Closed

cmd/link: issues with Xcode 16 beta [1.22 backport] #68198

gopherbot opened this issue Jun 26, 2024 · 7 comments
Labels
CherryPickApproved Used during the release process for point releases compiler/runtime Issues related to the Go compiler and/or runtime.
Milestone
Go1.22.6

Comments

@gopherbot
Copy link
Contributor

@cherrymui requested issue #68088 to be considered for backport to the next 1.22 minor release.

@gopherbot please backport this to Go 1.22. Thanks.

Reason is similar to the freeze exception above. Xcode 16 will probably be released while Go 1.22 is still in support.
@gopherbot gopherbot added the CherryPickCandidate Used during the release process for point releases label Jun 26, 2024
@gopherbot gopherbot mentioned this issue Jun 26, 2024
Closed
@cherrymui cherrymui changed the title cmd/link: issues with Xcode 16 beta [freeze exception] [1.22 backport] cmd/link: issues with Xcode 16 beta [1.22 backport] Jun 26, 2024
@gopherbot gopherbot added the compiler/runtime Issues related to the Go compiler and/or runtime. label Jun 26, 2024
@gopherbot gopherbot added this to the Go1.22.5 milestone Jun 26, 2024
@cherrymui
Copy link
Member

Go 1.21 will be out of support soon, certainly before Xcode 16 is released. So I don't think we need to do Go 1.21.

@gabyhelp
Copy link

Similar Issues

(Emoji vote if this was helpful or unhelpful; more detailed feedback welcome in this discussion.)

@joedian
Copy link

joedian commented Jun 26, 2024

@cherrymui agreed to approve , however please create backport for 1.21 as well.

@joedian joedian added the CherryPickApproved Used during the release process for point releases label Jun 26, 2024
@gopherbot gopherbot removed the CherryPickCandidate Used during the release process for point releases label Jun 26, 2024
@cherrymui
Copy link
Member

however please create backport for 1.21 as well.

As commented above #68198 (comment) I don't think we need to backport to Go 1.21. Could you explain why that is necessary? Thanks.

@dmitshur
Copy link
Contributor

dmitshur commented Jun 26, 2024 •
edited
Loading

Our default policy decision is to support all supported versions of Go equally. See accepted proposal 34536. Since this problem affects both Go 1.22 and 1.21, it seemed that 1.21 should get the fix too.

I was going to suggest that if backporting to Go 1.21 creates unreasonable overhead, it's likely fine to wait a bit while Xcode 16 is still in beta, and revisit this after Go 1.23.0 is out, but I understand you were making the same point in #68198 (comment) in that the problem isn't there now, but in the future, and by then 1.23 and 1.22 will be supported. So I think it is indeed okay to move forward with 1.22 only from that perspective. Thanks.

@joedian joedian added NeedsFix The path to resolution is known, but the work has not been done. and removed NeedsFix The path to resolution is known, but the work has not been done. labels Jun 28, 2024
@rsc rsc changed the title cmd/link: issues with Xcode 16 beta [1.22 backport] cmd/link: issues with Xcode 16 beta [1.22 backport] Jun 28, 2024
@gopherbot gopherbot modified the milestones: Go1.22.5, Go1.22.6 Jul 2, 2024
@gopherbot
Copy link
Contributor Author

Change https://go.dev/cl/596455 mentions this issue: [release-branch.go1.22] cmd/link: don't let dsymutil delete our temp directory

gopherbot pushed a commit that referenced this issue Jul 10, 2024
@cherrymui @cagedmantis
[release-branch.go1.22] cmd/link: don't let dsymutil delete our temp …
4e548f2 
…directory

To work around #59026, where dsymutil may not clean up its temp
directory at exit, we set DSYMUTIL_REPRODUCER_PATH to our temp
directory so it uses that, and we can delete it at the end.

In Xcode 16 beta, dsymutil deletes the DSYMUTIL_REPRODUCER_PATH
directory even if it is not empty. We still need our tmpdir at the
point, so give a subdirectory to dsymutil instead.

Updates #68088.
Fixes #68198.

Change-Id: I18759cc39512819bbd0511793ce917eae72245d6
Reviewed-on: https://go-review.googlesource.com/c/go/+/593659
Reviewed-by: Than McIntosh <[email protected]>
LUCI-TryBot-Result: Go LUCI <[email protected]>
(cherry picked from commit 5f319b7)
Reviewed-on: https://go-review.googlesource.com/c/go/+/596455
@gopherbot
Copy link
Contributor Author

Closed by merging 4e548f2 to release-branch.go1.22.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
CherryPickApproved Used during the release process for point releases compiler/runtime Issues related to the Go compiler and/or runtime.
Projects
None yet
Milestone
Go1.22.6
Development

No branches or pull requests
5 participants
@dmitshur @gopherbot @cherrymui @joedian @gabyhelp