x/tools/gopls: stubmethods: "could not find the enclosing function of the return statement" bug in GetIfaceStubInfo #70666
Assignees
Labels
gopls/telemetry-wins
gopls
Issues related to the Go language server, gopls.
NeedsInvestigation
Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Tools
This label describes issues relating to any tools in the x/tools repository.
Milestone
Comments
adonovan
added
NeedsInvestigation
|
Another nonsensical backtrace. |
|
Change https://go.dev/cl/633375 mentions this issue: |
gopherbot
pushed a commit
to golang/tools
that referenced
this issue
Dec 3, 2024
This CL refine an as-yet unreproducible crash into a bug report. It seems clear that the code intended to check that sig != nil, yet instead checked that sig.Results != nil. With that said, I don't think it's possible to have a return statement without an enclosing signature. For now, turn this into a bug report. For golang/go#70666 Change-Id: I79031d437d643f6d70360e3abde86166176647b3 Reviewed-on: https://go-review.googlesource.com/c/tools/+/633375 Reviewed-by: Alan Donovan <[email protected]> LUCI-TryBot-Result: Go LUCI <[email protected]>
|
Change https://go.dev/cl/633715 mentions this issue: |
func fromReturnStmt(fset *token.FileSet, info *types.Info, pos token.Pos, path []ast.Node, ret *ast.ReturnStmt) (*IfaceStubInfo, error) {
// Find return operand containing pos.
returnIdx := -1
for i, r := range ret.Results {
if r.Pos() <= pos && pos <= r.End() {
returnIdx = i
break
}
}
if returnIdx == -1 {
return nil, fmt.Errorf("pos %d not within return statement bounds: [%d-%d]", pos, ret.Pos(), ret.End())
}
concType, pointer := concreteType(ret.Results[returnIdx], info)
if concType == nil || concType.Obj().Pkg() == nil {
return nil, nil // result is not a named or *named or alias thereof
}
// Inv: the return is not a spread return,
// such as "return f()" where f() has tuple type.
conc := concType.Obj()
if conc.Parent() != conc.Pkg().Scope() {
return nil, fmt.Errorf("local type %q cannot be stubbed", conc.Name())
}
sig := typesutil.EnclosingSignature(path, info) // this is L0284
...@prattmic Notice that all the lines matching L0284--the call to EnclosingSignature, which is not in the telemetry stack trace--are only loads from stack slots and the CALL itself: nothing really fallible. |
findleyr
changed the title
This was referenced Dec 17, 2024
adonovan
changed the title
|
One possibility: there is an enclosing Func{Decl,Lit}, but the type checker has failed to record an Info.{Defs,Types} for it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Issue created by stacks.
This stack
P5n9hAwas reported by telemetry:crash/crashruntime.gopanic:+69runtime.panicmem:=262runtime.sigpanic:+19golang.org/x/tools/gopls/internal/golang/stubmethods.fromReturnStmt:+24golang.org/x/tools/gopls/internal/golang/stubmethods.GetIfaceStubInfo:+10golang.org/x/tools/gopls/internal/golang.quickFix:+44golang.org/x/tools/gopls/internal/golang.CodeActions:+65golang.org/x/tools/gopls/internal/server.(*server).CodeAction:+154golang.org/x/tools/gopls/internal/protocol.serverDispatch:+160golang.org/x/tools/gopls/internal/lsprpc.(*streamServer).ServeStream.ServerHandler.func3:+5golang.org/x/tools/gopls/internal/lsprpc.(*streamServer).ServeStream.handshaker.func4:+52golang.org/x/tools/gopls/internal/protocol.Handlers.MustReplyHandler.func1:+2golang.org/x/tools/gopls/internal/protocol.Handlers.AsyncHandler.func2.2:+3runtime.goexit:+0Dups: fm8UdQ
The text was updated successfully, but these errors were encountered: