Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

database/sql: document Stmt lifetime #29890

Closed
wants to merge 1 commit into from
Closed

database/sql: document Stmt lifetime #29890

wants to merge 1 commit into from

Conversation

pushrax
Copy link
Contributor

@pushrax pushrax commented Jan 23, 2019

When prepared on a DB, prepared statement code in database/sql handles everything to keep the prepared statement alive as it moves across the connection pool. Understanding this is an important part of using this API correctly, but it was only documented indirectly via (*Tx) Prepare*.

@googlebot googlebot added the cla: yes Used by googlebot to label PRs as having a valid CLA. The text of this label should not change. label Jan 23, 2019
@pushrax pushrax mentioned this pull request Jan 23, 2019
Closed
@gopherbot
Copy link
Contributor

This PR (HEAD: 55dba87) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/159077 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Contributor

Message from Gobot Gobot:

Patch Set 1:

Congratulations on opening your first change. Thank you for your contribution!

Next steps:
Within the next week or so, a maintainer will review your change and provide
feedback. See https://golang.org/doc/contribute.html#review for more info and
tips to get your patch through code review.

Most changes in the Go project go through a few rounds of revision. This can be
surprising to people new to the project. The careful, iterative review process
is our way of helping mentor contributors and ensuring that their contributions
have a lasting impact.

During May-July and Nov-Jan the Go project is in a code freeze, during which
little code gets reviewed or merged. If a reviewer responds with a comment like
R=go1.11, it means that this CL will be reviewed as part of the next development
cycle. See https://golang.org/s/release for more details.

Please don’t reply on this GitHub thread. Visit golang.org/cl/159077.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Brad Fitzpatrick:

Patch Set 1: Code-Review+2

Please don’t reply on this GitHub thread. Visit golang.org/cl/159077.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Daniel Theophanes:

Patch Set 1: Code-Review+2

(1 comment)

LGTM
Brad: I'm fine if this goes in at any point in time.
Just a doc addition. So close to release I'll defer to you
if it should be submitted or not.

Please don’t reply on this GitHub thread. Visit golang.org/cl/159077.
After addressing review feedback, remember to publish your drafts!

gopherbot pushed a commit that referenced this pull request Feb 8, 2019
@pushrax @bradfitz
database/sql: document Stmt lifetime
d5a3653 
When prepared on a DB, prepared statement code in database/sql handles everything to keep the prepared statement alive as it moves across the connection pool. Understanding this is an important part of using this API correctly, but it was only documented indirectly via `(*Tx) Prepare*`.

Change-Id: Ic8757e0150d59e675d9f0252f6c15aef2cc2e831
GitHub-Last-Rev: 55dba87
GitHub-Pull-Request: #29890
Reviewed-on: https://go-review.googlesource.com/c/159077
Reviewed-by: Brad Fitzpatrick <[email protected]>
Reviewed-by: Daniel Theophanes <[email protected]>
@gopherbot
Copy link
Contributor

This PR is being closed because golang.org/cl/159077 has been merged.

@gopherbot gopherbot closed this Feb 8, 2019
nebulabox pushed a commit to nebulabox/go that referenced this pull request Feb 18, 2019
@pushrax @nebulabox
database/sql: document Stmt lifetime
d90074c 
When prepared on a DB, prepared statement code in database/sql handles everything to keep the prepared statement alive as it moves across the connection pool. Understanding this is an important part of using this API correctly, but it was only documented indirectly via `(*Tx) Prepare*`.

Change-Id: Ic8757e0150d59e675d9f0252f6c15aef2cc2e831
GitHub-Last-Rev: 55dba87
GitHub-Pull-Request: golang#29890
Reviewed-on: https://go-review.googlesource.com/c/159077
Reviewed-by: Brad Fitzpatrick <[email protected]>
Reviewed-by: Daniel Theophanes <[email protected]>
nebulabox pushed a commit to nebulabox/go that referenced this pull request Feb 20, 2019
@pushrax @nebulabox
database/sql: document Stmt lifetime
9354c90 
When prepared on a DB, prepared statement code in database/sql handles everything to keep the prepared statement alive as it moves across the connection pool. Understanding this is an important part of using this API correctly, but it was only documented indirectly via `(*Tx) Prepare*`.

Change-Id: Ic8757e0150d59e675d9f0252f6c15aef2cc2e831
GitHub-Last-Rev: 55dba87
GitHub-Pull-Request: golang#29890
Reviewed-on: https://go-review.googlesource.com/c/159077
Reviewed-by: Brad Fitzpatrick <[email protected]>
Reviewed-by: Daniel Theophanes <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
cla: yes Used by googlebot to label PRs as having a valid CLA. The text of this label should not change.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pushrax @gopherbot @googlebot