cmd/go: make sure that the RelPaths always returns valid paths #30533
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When dealing with symlinks, filepath.Rel does not always return a valid path as described in golang#30336 This change makes sure that the shorter path is not used if it isn't valid. Fixes golang#30336
googlebot
added
the
cla: yes
|
This PR (HEAD: fb6bfa4) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/go/+/164957 to see it. Tip: You can toggle comments from me using the |
|
Message from Bryan C. Mills: Patch Set 1: Code-Review-1 If filepath.Rel returns a nil error, the resulting path should always be valid. Please don’t reply on this GitHub thread. Visit golang.org/cl/164957. |
gopherbot
force-pushed
the
master
branch
3 times, most recently
from
53bd915 to
6139019
Compare
gopherbot
force-pushed
the
master
branch
6 times, most recently
from
4a7ed1f to
0f992b9
Compare
|
This PR is being closed because golang.org/cl/164957 has been abandoned. Underlying problem needs more investigation. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When dealing with symlinks, filepath.Rel does not always return a valid path
as described in #30336
This change makes sure that the shorter path is not used if it isn't valid.
Fixes #30336