Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go:linkname must refer to declared function or variable is not an error in 1.17 #55891

Closed

Conversation

chengjoey
Copy link

@chengjoey chengjoey commented Sep 27, 2022

In version 1.17, go:linkname must refer to declared function or variable is not an error
may be should change the comment to 1.18

@google-cla
Copy link

google-cla bot commented Sep 27, 2022

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@chengjoey chengjoey force-pushed the fix/linkname-error branch 2 times, most recently from a9a6d0f to b2ae208 Compare September 28, 2022 07:53
@gopherbot
Copy link
Contributor

This PR (HEAD: 1834077) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/435736 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Contributor

Message from Gopher Robot:

Patch Set 1:

Congratulations on opening your first change. Thank you for your contribution!

Next steps:
A maintainer will review your change and provide feedback. See
https://go.dev/doc/contribute#review for more info and tips to get your
patch through code review.

Most changes in the Go project go through a few rounds of revision. This can be
surprising to people new to the project. The careful, iterative review process
is our way of helping mentor contributors and ensuring that their contributions
have a lasting impact.

During May-July and Nov-Jan the Go project is in a code freeze, during which
little code gets reviewed or merged. If a reviewer responds with a comment like
R=go1.11 or adds a tag like "wait-release", it means that this CL will be
reviewed as part of the next development cycle. See https://go.dev/s/release
for more details.


Please don’t reply on this GitHub thread. Visit golang.org/cl/435736.
After addressing review feedback, remember to publish your drafts!

@chengjoey chengjoey closed this Sep 28, 2022
@chengjoey chengjoey reopened this Sep 28, 2022
@chengjoey
Copy link
Author

#51706

@mvdan
Copy link
Member

mvdan commented Sep 29, 2022

You are targeting a 1.17 branch which hasn't been updated for some time. The right fix is being discussed in #55889.

@mvdan mvdan closed this Sep 29, 2022
@chengjoey
Copy link
Author

You are targeting a 1.17 branch which hasn't been updated for some time. The right fix is being discussed in #55889.

I don't quite understand what is the correct fix

In the comments for the 1.17 branch,go:linkname must refer to declared function or variable will become an error in version 1.17, but in fact, version 1.18 only throws it as an error

@bcmills cound you take a look when you have time

@mdempsky
Copy link
Contributor

Thanks for your interest in helping, but this CL is unnecessary. We don't care about internal comments in obsolete versions of Go.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants