reflect: deprecate PtrTo #61440

qiulaidongfeng · 2023-07-19T12:16:02Z

Replace reflect.PtrTo with reflect.PointerTo.

Fixes #59599

Change-Id: I49407193e2050543ef983cd637703acc682d9f51

gopherbot · 2023-07-19T12:24:01Z

This PR (HEAD: bfc08a4) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/511035.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to register for Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2023-07-19T12:30:07Z

Message from Gopher Robot:

Patch Set 1:

Congratulations on opening your first change. Thank you for your contribution!

Next steps:
A maintainer will review your change and provide feedback. See
https://go.dev/doc/contribute#review for more info and tips to get your
patch through code review.

Most changes in the Go project go through a few rounds of revision. This can be
surprising to people new to the project. The careful, iterative review process
is our way of helping mentor contributors and ensuring that their contributions
have a lasting impact.

During May-July and Nov-Jan the Go project is in a code freeze, during which
little code gets reviewed or merged. If a reviewer responds with a comment like
R=go1.11 or adds a tag like "wait-release", it means that this CL will be
reviewed as part of the next development cycle. See https://go.dev/s/release
for more details.

Please don’t reply on this GitHub thread. Visit golang.org/cl/511035.
After addressing review feedback, remember to publish your drafts!

thaJeztah · 2023-07-20T21:58:03Z

src/reflect/type.go

@@ -1171,6 +1171,7 @@ var ptrMap sync.Map // map[*rtype]*ptrType
 //
 // PtrTo is the old spelling of PointerTo.
 // The two functions behave identically.
+// Deprecated: Superseded by [PointerTo]


I think there must be an empty comment line before the Deprecated line, otherwise it may not be picked up as "deprecated"

gopherbot · 2023-07-20T23:25:49Z

Message from Ian Lance Taylor:

Patch Set 2:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/511035.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-07-21T01:37:10Z

This PR (HEAD: 2775205) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/511035.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to register for Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2023-07-21T01:52:00Z

Message from qiulaidongfeng:

Patch Set 3:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/511035.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-07-21T05:23:42Z

Message from Ian Lance Taylor:

Patch Set 3:

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/511035.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-07-21T05:35:07Z

This PR (HEAD: fc184f8) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/511035.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to register for Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2023-07-21T05:40:32Z

Message from Ian Lance Taylor:

Patch Set 4:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/511035.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-07-21T05:40:33Z

Message from Ian Lance Taylor:

Patch Set 4:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/511035.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-07-21T05:40:33Z

Message from qiulaidongfeng:

Patch Set 4:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/511035.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-07-21T05:46:14Z

Message from qiulaidongfeng:

Patch Set 5:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/511035.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-07-21T18:36:48Z

Message from Ian Lance Taylor:

Patch Set 5:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/511035.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-07-21T18:36:49Z

Message from Ian Lance Taylor:

Patch Set 5:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/511035.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-07-21T18:36:50Z

Message from Ian Lance Taylor:

Patch Set 5: Auto-Submit+1 Code-Review+2 Run-TryBot+1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/511035.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-07-21T18:36:50Z

Message from Gopher Robot:

Patch Set 5:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/511035.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-07-21T18:42:58Z

Message from Gopher Robot:

Patch Set 5:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/511035.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-07-21T18:42:59Z

Message from Gopher Robot:

Patch Set 5: TryBot-Result-1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/511035.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-07-21T18:49:01Z

Message from Ian Lance Taylor:

Patch Set 5: -Auto-Submit -Code-Review

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/511035.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-07-22T01:06:02Z

This PR (HEAD: 6c65c6a) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/511035.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to register for Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2023-07-22T01:29:37Z

Message from qiulaidongfeng:

Patch Set 6:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/511035.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-07-22T05:38:22Z

Message from Ian Lance Taylor:

Patch Set 6: Run-TryBot+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/511035.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-07-22T05:43:23Z

Message from Gopher Robot:

Patch Set 6:

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/511035.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-07-22T05:43:31Z

This PR (HEAD: 007cbbc) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/511035.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to register for Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2023-07-22T05:48:44Z

Message from Gopher Robot:

Patch Set 6:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/511035.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-07-22T05:48:45Z

Message from qiulaidongfeng:

Patch Set 7:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/511035.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-07-25T23:54:54Z

Message from Ian Lance Taylor:

Patch Set 7: Run-TryBot+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/511035.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-07-26T00:00:12Z

Message from Gopher Robot:

Patch Set 7:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/511035.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-07-26T00:05:53Z

Message from Gopher Robot:

Patch Set 7:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/511035.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-07-26T00:11:33Z

Message from Gopher Robot:

Patch Set 7: TryBot-Result-1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/511035.
After addressing review feedback, remember to publish your drafts!

Replace reflect.PtrTo with reflect.PointerTo Fixes golang#59599 Change-Id: I49407193e2050543ef983cd637703acc682d9f51

gopherbot · 2023-07-26T05:59:56Z

This PR (HEAD: 7bc9ccf) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/511035.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to register for Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2023-07-26T06:05:50Z

Message from qiulaidongfeng:

Patch Set 8:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/511035.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-07-26T14:27:47Z

Message from Ian Lance Taylor:

Patch Set 8: Run-TryBot+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/511035.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-07-26T14:33:46Z

Message from Gopher Robot:

Patch Set 8:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/511035.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-07-26T14:39:52Z

Message from Gopher Robot:

Patch Set 8: TryBot-Result+1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/511035.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-07-26T17:42:13Z

Message from Keith Randall:

Patch Set 8: Code-Review+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/511035.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-07-26T17:47:56Z

Message from Keith Randall:

Patch Set 8:

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/511035.
After addressing review feedback, remember to publish your drafts!

Replace reflect.PtrTo with reflect.PointerTo. Fixes #59599 Change-Id: I49407193e2050543ef983cd637703acc682d9f51 Change-Id: I49407193e2050543ef983cd637703acc682d9f51 GitHub-Last-Rev: 7bc9ccf GitHub-Pull-Request: #61440 Reviewed-on: https://go-review.googlesource.com/c/go/+/511035 Run-TryBot: Ian Lance Taylor <[email protected]> Run-TryBot: Ian Lance Taylor <[email protected]> TryBot-Result: Gopher Robot <[email protected]> Auto-Submit: Ian Lance Taylor <[email protected]> Reviewed-by: Keith Randall <[email protected]> Reviewed-by: Ian Lance Taylor <[email protected]>

gopherbot · 2023-07-27T23:34:47Z

This PR is being closed because golang.org/cl/511035 has been merged.

thaJeztah reviewed Jul 20, 2023

View reviewed changes

qiulaidongfeng force-pushed the 59599-3 branch from bfc08a4 to 2775205 Compare July 21, 2023 01:33

qiulaidongfeng force-pushed the 59599-3 branch from 2775205 to fc184f8 Compare July 21, 2023 05:32

qiulaidongfeng force-pushed the 59599-3 branch from fc184f8 to 6c65c6a Compare July 22, 2023 01:02

qiulaidongfeng force-pushed the 59599-3 branch from 6c65c6a to 007cbbc Compare July 22, 2023 05:43

reflect: deprecate PtrTo

7bc9ccf

Replace reflect.PtrTo with reflect.PointerTo Fixes golang#59599 Change-Id: I49407193e2050543ef983cd637703acc682d9f51

qiulaidongfeng force-pushed the 59599-3 branch from 007cbbc to 7bc9ccf Compare July 26, 2023 05:56

gopherbot closed this Jul 27, 2023

reflect: deprecate PtrTo #61440

reflect: deprecate PtrTo #61440

Conversation

qiulaidongfeng commented Jul 19, 2023 • edited Loading

gopherbot commented Jul 19, 2023

gopherbot commented Jul 19, 2023

thaJeztah Jul 20, 2023

Choose a reason for hiding this comment

gopherbot commented Jul 20, 2023

gopherbot commented Jul 21, 2023

gopherbot commented Jul 21, 2023

gopherbot commented Jul 21, 2023

gopherbot commented Jul 21, 2023

gopherbot commented Jul 21, 2023

gopherbot commented Jul 21, 2023

gopherbot commented Jul 21, 2023

gopherbot commented Jul 21, 2023

gopherbot commented Jul 21, 2023

gopherbot commented Jul 21, 2023

gopherbot commented Jul 21, 2023

gopherbot commented Jul 21, 2023

gopherbot commented Jul 21, 2023

gopherbot commented Jul 21, 2023

gopherbot commented Jul 21, 2023

gopherbot commented Jul 22, 2023

gopherbot commented Jul 22, 2023

gopherbot commented Jul 22, 2023

gopherbot commented Jul 22, 2023

gopherbot commented Jul 22, 2023

gopherbot commented Jul 22, 2023

gopherbot commented Jul 22, 2023

gopherbot commented Jul 25, 2023

gopherbot commented Jul 26, 2023

gopherbot commented Jul 26, 2023

gopherbot commented Jul 26, 2023

gopherbot commented Jul 26, 2023

gopherbot commented Jul 26, 2023

gopherbot commented Jul 26, 2023

gopherbot commented Jul 26, 2023

gopherbot commented Jul 26, 2023

gopherbot commented Jul 26, 2023

gopherbot commented Jul 26, 2023

gopherbot commented Jul 27, 2023

qiulaidongfeng commented Jul 19, 2023 •

edited

Loading