-
Notifications
You must be signed in to change notification settings - Fork 17.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
archive/tar: add FileInfoNames interface #61662
Conversation
This PR (HEAD: 600a1bf) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/514235. Important tips:
|
Message from Ian Lance Taylor: Patch Set 2: (4 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/514235. |
This PR (HEAD: d7cd35d) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/514235. Important tips:
|
Message from qiulaidongfeng: Patch Set 4: (4 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/514235. |
Message from Ian Lance Taylor: Patch Set 4: (5 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/514235. |
This PR (HEAD: 812d827) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/514235. Important tips:
|
Message from qiulaidongfeng: Patch Set 5: (4 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/514235. |
Message from qiulaidongfeng: Patch Set 5: (3 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/514235. |
Message from Ian Lance Taylor: Patch Set 5: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/514235. |
Message from Ian Lance Taylor: Patch Set 5: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/514235. |
Message from Ian Lance Taylor: Patch Set 5: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/514235. |
An optional interface FileInfoNames has been added. If the parameter fi of FileInfoHeader implements the interface the Gname and Uname of the return value Header are provided by the method of the interface. Also added testing. Fixes golang#50102 Change-Id: I6fd06c7c9aaf29b22b7384542fe57affed33009a
This PR (HEAD: 5e82257) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/514235. Important tips:
|
Message from qiulaidongfeng: Patch Set 6: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/514235. |
Message from Ian Lance Taylor: Patch Set 6: Run-TryBot+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/514235. |
Message from Gopher Robot: Patch Set 6: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/514235. |
Message from Gopher Robot: Patch Set 6: TryBot-Result+1 (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/514235. |
Message from Ian Lance Taylor: Patch Set 6: Auto-Submit+1 Code-Review+2 Run-TryBot+1 (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/514235. |
An optional interface FileInfoNames has been added. If the parameter fi of FileInfoHeader implements the interface the Gname and Uname of the return value Header are provided by the method of the interface. Also added testing. Fixes #50102 Change-Id: I6fd06c7c9aaf29b22b7384542fe57affed33009a Change-Id: I6fd06c7c9aaf29b22b7384542fe57affed33009a GitHub-Last-Rev: 5e82257 GitHub-Pull-Request: #61662 Reviewed-on: https://go-review.googlesource.com/c/go/+/514235 Run-TryBot: Ian Lance Taylor <[email protected]> Reviewed-by: Ian Lance Taylor <[email protected]> Reviewed-by: Michael Knyszek <[email protected]> TryBot-Result: Gopher Robot <[email protected]> Run-TryBot: Ian Lance Taylor <[email protected]> Auto-Submit: Ian Lance Taylor <[email protected]>
This PR is being closed because golang.org/cl/514235 has been merged. |
An optional interface FileInfoNames has been added.
If the parameter fi of FileInfoHeader implements the interface
the Gname and Uname of the return value Header are
provided by the method of the interface.
Also added testing.
Fixes #50102
Change-Id: I6fd06c7c9aaf29b22b7384542fe57affed33009a