-
Notifications
You must be signed in to change notification settings - Fork 17.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cmd/go/internal/str,cmd/go/internal/work: remove redundant Contains #64136
Conversation
This PR (HEAD: 6c7bcc8) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/542416. Important tips:
|
Message from Gopher Robot: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/542416. |
Message from kyose chang: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/542416. |
Message from Mauri de Souza Meneguzzo: Patch Set 1: Code-Review+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/542416. |
Message from Mauri de Souza Meneguzzo: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/542416. |
Message from kyose chang: Patch Set 2: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/542416. |
"cmd/go/internal/str.Contains" does the same thing as the "slices.Contains". Given that the slices package is already used in the package, replace "str.Contains" with "slices.Contains". "str.Contains" is no longer used so just remove it.
6c7bcc8
to
e74d333
Compare
This PR (HEAD: e74d333) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/542416. Important tips:
|
Message from kyose chang: Patch Set 3: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/542416. |
Message from Bryan Mills: Patch Set 3: Auto-Submit+1 Code-Review+2 Commit-Queue+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/542416. |
Message from Go LUCI: Patch Set 3: Dry run: CV is trying the patch. Bot data: {"action":"start","triggered_at":"2024-01-23T17:43:27Z","revision":"aa00c7e31ab8e2e1ccf43b6c041ab587b27f5f79"} Please don’t reply on this GitHub thread. Visit golang.org/cl/542416. |
Message from Bryan Mills: Patch Set 3: -Commit-Queue Please don’t reply on this GitHub thread. Visit golang.org/cl/542416. |
Message from Go LUCI: Patch Set 3: This CL has passed the run Please don’t reply on this GitHub thread. Visit golang.org/cl/542416. |
Message from Go LUCI: Patch Set 3: LUCI-TryBot-Result+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/542416. |
"cmd/go/internal/str.Contains" does the same thing as the "slices.Contains". The name "str.Contains" is also easily confused with "strings.Contains". Given that the slices package is already used in the package, replace "str.Contains" with "slices.Contains". "str.Contains" is no longer used so just remove it. Change-Id: I80572464bd17d4a60e7ff41db3a77c4d0bd03fa3 GitHub-Last-Rev: e74d333 GitHub-Pull-Request: #64136 Reviewed-on: https://go-review.googlesource.com/c/go/+/542416 Auto-Submit: Bryan Mills <[email protected]> LUCI-TryBot-Result: Go LUCI <[email protected]> Reviewed-by: Cherry Mui <[email protected]> Reviewed-by: Mauri de Souza Meneguzzo <[email protected]> Reviewed-by: Bryan Mills <[email protected]>
This PR is being closed because golang.org/cl/542416 has been merged. |
"cmd/go/internal/str.Contains" does the same thing as the "slices.Contains". The name "str.Contains" is also easily confused with "strings.Contains". Given that the slices package is already used in the package, replace "str.Contains" with "slices.Contains". "str.Contains" is no longer used so just remove it. Change-Id: I80572464bd17d4a60e7ff41db3a77c4d0bd03fa3 GitHub-Last-Rev: e74d333 GitHub-Pull-Request: golang#64136 Reviewed-on: https://go-review.googlesource.com/c/go/+/542416 Auto-Submit: Bryan Mills <[email protected]> LUCI-TryBot-Result: Go LUCI <[email protected]> Reviewed-by: Cherry Mui <[email protected]> Reviewed-by: Mauri de Souza Meneguzzo <[email protected]> Reviewed-by: Bryan Mills <[email protected]>
"cmd/go/internal/str.Contains" does the same thing as the "slices.Contains".
The name "str.Contains" is also easily confused with "strings.Contains".
Given that the slices package is already used in the package,
replace "str.Contains" with "slices.Contains".
"str.Contains" is no longer used so just remove it.