-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
websocket: add support for dialing with context #160
Conversation
This PR (HEAD: d208c33) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/net/+/463097 to see it. Tip: You can toggle comments from me using the |
Message from Gopher Robot: Patch Set 1: Congratulations on opening your first change. Thank you for your contribution! Next steps: Most changes in the Go project go through a few rounds of revision. This can be During May-July and Nov-Jan the Go project is in a code freeze, during which Please don’t reply on this GitHub thread. Visit golang.org/cl/463097. |
sorry for the noise , it seems this is handled in gerrit instead of github |
Message from Damien Neil: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/463097. |
Message from Alex Besogonov: Patch Set 1: (2 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/463097. |
Message from Damien Neil: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/463097. |
d208c33
to
3771fe4
Compare
This PR (HEAD: 3771fe4) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/net/+/463097. Important tips:
|
Message from Damien Neil: Patch Set 2: Commit-Queue+1 (2 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/463097. |
Message from Go LUCI: Patch Set 2: Dry run: CV is trying the patch. Bot data: {"action":"start","triggered_at":"2023-11-28T18:49:06Z","revision":"ead762457fbc2099a503ce912f04926ef5466371"} Please don’t reply on this GitHub thread. Visit golang.org/cl/463097. |
Message from Damien Neil: Patch Set 2: -Commit-Queue Please don’t reply on this GitHub thread. Visit golang.org/cl/463097. |
Message from Go LUCI: Patch Set 2: This CL has passed the run Please don’t reply on this GitHub thread. Visit golang.org/cl/463097. |
Message from Go LUCI: Patch Set 2: LUCI-TryBot-Result+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/463097. |
Message from Alex Besogonov: Patch Set 2: (2 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/463097. |
Message from Damien Neil: Patch Set 2: Auto-Submit+1 Code-Review+2 (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/463097. |
Message from Dmitri Shuralyov: Patch Set 3: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/463097. |
Message from Damien Neil: Patch Set 3: -Code-Review (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/463097. |
Right now there is no way to pass context.Context to websocket.Dial. In addition, this method can block indefinitely in the `NewClient` call. Fixes golang/go#57953
3771fe4
to
5e8c3a7
Compare
This PR (HEAD: 5e8c3a7) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/net/+/463097. Important tips:
|
Message from Alex Besogonov: Patch Set 4: (2 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/463097. |
Message from Dmitri Shuralyov: Patch Set 4: Code-Review+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/463097. |
Message from Damien Neil: Patch Set 4: Code-Review+2 Please don’t reply on this GitHub thread. Visit golang.org/cl/463097. |
Right now there is no way to pass context.Context to websocket.Dial. In addition, this method can block indefinitely in the NewClient call. Fixes golang/go#57953. Change-Id: Ic52d4b8306cd0850e78d683abb1bf11f0d4247ca GitHub-Last-Rev: 5e8c3a7 GitHub-Pull-Request: #160 Reviewed-on: https://go-review.googlesource.com/c/net/+/463097 Auto-Submit: Damien Neil <[email protected]> Reviewed-by: Damien Neil <[email protected]> LUCI-TryBot-Result: Go LUCI <[email protected]> Reviewed-by: Dmitri Shuralyov <[email protected]>
Message from Damien Neil: Patch Set 4: Auto-Submit+1 Commit-Queue+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/463097. |
Message from Go LUCI: Patch Set 4: Dry run: CV is trying the patch. Bot data: {"action":"start","triggered_at":"2024-02-27T23:12:12Z","revision":"2cbcd8d4cf89a3b70f55467db52f8ddacfb739ba"} Please don’t reply on this GitHub thread. Visit golang.org/cl/463097. |
This PR is being closed because golang.org/cl/463097 has been merged. |
Right now there is no way to pass context.Context to websocket.Dial.
In addition, this method can block indefinitely in the NewClient call.
Fixes golang/go#57953.