Skip to content

Commit

Permalink
proto: fix govet failures in Go 1.10 (#505)
Browse files Browse the repository at this point in the history
In Go 1.10, go test automatically runs go vet as well.  This
uncovered a vet failure in TestUnmarshalRepeatingNonRepeatedExtension
where pb.ComplexExtension is passed as a fmt.Stringer to t.Errorf.
The string method exists only on the pointer-receiver type,
*pb.ComplexExtension.
  • Loading branch information
Chris Manghane authored and dsnet committed Feb 1, 2018
1 parent 57af863 commit 97a81c9
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion proto/extensions_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -623,7 +623,7 @@ func TestUnmarshalRepeatingNonRepeatedExtension(t *testing.T) {
t.Fatalf("[%s] Invalid extension", test.name)
}
if !proto.Equal(ext, &want) {
t.Errorf("[%s] Wrong value for ComplexExtension: got: %s want: %s\n", test.name, ext, want)
t.Errorf("[%s] Wrong value for ComplexExtension: got: %s want: %s\n", test.name, ext, &want)
}
}
}
Expand Down

0 comments on commit 97a81c9

Please sign in to comment.