-
Notifications
You must be signed in to change notification settings - Fork 581
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
windows: add net user enum #190
Conversation
This PR (HEAD: 3d01bca) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/sys/+/578475. Important tips:
|
Message from Gopher Robot: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/578475. |
Message from Gopher Robot: Patch Set 1: Congratulations on opening your first change. Thank you for your contribution! Next steps: Most changes in the Go project go through a few rounds of revision. This can be During May-July and Nov-Jan the Go project is in a code freeze, during which Please don’t reply on this GitHub thread. Visit golang.org/cl/578475. |
Message from Alex Brainman: Patch Set 1: (3 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/578475. |
Message from Joey Shapiro: Patch Set 1: (2 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/578475. |
Message from Alex Brainman: Patch Set 3: Code-Review+2 Commit-Queue+1 (2 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/578475. |
Message from Go LUCI: Patch Set 3: Dry run: CV is trying the patch. Bot data: {"action":"start","triggered_at":"2024-05-05T10:41:05Z","revision":"6f5f8d62e0e4df84627e5561d6a8d23225749216"} Please don’t reply on this GitHub thread. Visit golang.org/cl/578475. |
Message from Alex Brainman: Patch Set 3: -Commit-Queue Please don’t reply on this GitHub thread. Visit golang.org/cl/578475. |
Message from Go LUCI: Patch Set 3: This CL has passed the run Please don’t reply on this GitHub thread. Visit golang.org/cl/578475. |
Message from Go LUCI: Patch Set 3: LUCI-TryBot-Result+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/578475. |
Message from Alex Brainman: Patch Set 3: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/578475. |
Message from Cherry Mui: Patch Set 3: Code-Review+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/578475. |
Message from David Chase: Patch Set 3: Code-Review+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/578475. |
In the go windows package, you can get user information by using `NetUserGetInfo` along with a specified level. However, there is no way to get a list of the users. The only options are to 1. know the users, 2. brute force users, or 3. use an external tool or command (`net users`). I suggest adding a function that implements the windows api for `NetUserEnum`. This will allow a built in way to enumerate users and follow the standard. A side note is that I used `buf **byte` because it is how the others are done, but using `buf *byte` works just as well. Change-Id: Ifcc916659eb1d796175cd18acd2e81f2661bfcd2 GitHub-Last-Rev: 3d01bca GitHub-Pull-Request: #190 Reviewed-on: https://go-review.googlesource.com/c/sys/+/578475 Reviewed-by: Alex Brainman <[email protected]> Auto-Submit: Cherry Mui <[email protected]> LUCI-TryBot-Result: Go LUCI <[email protected]> Reviewed-by: David Chase <[email protected]> Reviewed-by: Cherry Mui <[email protected]>
This PR is being closed because golang.org/cl/578475 has been merged. |
In the go windows package, you can get user information by using
NetUserGetInfo
along with a specified level. However, there isno way to get a list of the users.
The only options are to
net users
).I suggest adding a function that implements the windows api for
NetUserEnum
. This will allow a built in way to enumerateusers and follow the standard.
A side note is that I used
buf **byte
becauseit is how the others are done, but using
buf *byte
works just as well.