Skip to content

Commit

Permalink
internal/lsp: run analyses despite some errors
Browse files Browse the repository at this point in the history
Updates golang/go#32247

Change-Id: Id474e62ea70676c782eb49dddebd64d7f274d2cf
Reviewed-on: https://go-review.googlesource.com/c/tools/+/179218
Run-TryBot: Rebecca Stambler <[email protected]>
Reviewed-by: Ian Cottrell <[email protected]>
  • Loading branch information
stamblerre committed May 28, 2019
1 parent 09281b5 commit 08bd53a
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion internal/lsp/source/analysis.go
Original file line number Diff line number Diff line change
Expand Up @@ -158,7 +158,7 @@ func (act *Action) execOnce(ctx context.Context, fset *token.FileSet) error {
}
act.pass = pass

if len(act.Pkg.GetErrors()) > 0 && !pass.Analyzer.RunDespiteErrors {
if act.Pkg.IsIllTyped() && !pass.Analyzer.RunDespiteErrors {
act.err = fmt.Errorf("analysis skipped due to errors in package: %v", act.Pkg.GetErrors())
} else {
act.result, act.err = pass.Analyzer.Run(pass)
Expand Down

0 comments on commit 08bd53a

Please sign in to comment.