internal/lsp/cache: remove unsynchronized write to snapshot.files

snapshot.GetVersionedFile already memoizes the file handle in snapshot.files. There is no reason to do another write, and this write is unsynchronized. Fixes golang/go#50747 Change-Id: Ib196395135de6f22dd59169accb756665ad10e58 Reviewed-on: https://go-review.googlesource.com/c/tools/+/380214 Trust: Robert Findley <[email protected]> Run-TryBot: Robert Findley <[email protected]> Reviewed-by: Bryan Mills <[email protected]> gopls-CI: kokoro <[email protected]> TryBot-Result: Gopher Robot <[email protected]>
golang · Jan 21, 2022 · e7c9de2 · e7c9de2
1 parent 3425967
commit e7c9de2
Showing 1 changed file with 1 addition and 2 deletions.
diff --git a/internal/lsp/cache/view.go b/internal/lsp/cache/view.go
@@ -396,11 +396,10 @@ func (s *snapshot) locateTemplateFiles(ctx context.Context) {
 		excluded := pathExcludedByFilter(relpath, dir, s.view.gomodcache, s.view.options)
 		if fileHasExtension(path, suffixes) && !excluded && !fi.IsDir() {
 			k := span.URIFromPath(path)
-			fh, err := s.GetVersionedFile(ctx, k)
+			_, err := s.GetVersionedFile(ctx, k)
 			if err != nil {
 				return nil
 			}
-			s.files[k] = fh
 		}
 		searched++
 		if fileLimit > 0 && searched > fileLimit {