Skip to content

Commit

Permalink
cmd/govulncheck: remove line about go version requirements
Browse files Browse the repository at this point in the history 
Use the go directive in go.mod as the single source of truth
for the required Go version for installing golvulncheck.

Updates golang/go#68034
Fixes golang/go#68256

Change-Id: Ief445ffa40282feff6a97419b48dc6290071d971
Reviewed-on: https://go-review.googlesource.com/c/vuln/+/595935
LUCI-TryBot-Result: Go LUCI <[email protected]>
Reviewed-by: Than McIntosh <[email protected]>
Reviewed-by: Zvonimir Pavlinovic <[email protected]>
  • Loading branch information
@seankhliao @zpavlinovic
seankhliao authored and zpavlinovic committed Jul 1, 2024
1 parent 055425f commit deda8bb
Showing 1 changed file with 0 additions and 2 deletions.
2 changes: 0 additions & 2 deletions cmd/govulncheck/doc.go
View file
Original file line number Diff line number Diff line change
Expand Up @@ -20,8 +20,6 @@ specified by the “go” command found on the PATH. For binaries, the build
configuration is the one used to build the binary. Note that different build
configurations may have different known vulnerabilities.
Govulncheck must be built with Go version 1.18 or later.
# Usage
To analyze source code, run govulncheck from the module directory, using the
Expand Down

3 comments on commit deda8bb

@iglov
Copy link

@iglov iglov commented on deda8bb Jul 1, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there is one more line Govulncheck only reads binaries compiled with Go 1.18 and later.

@zpavlinovic
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that this is related to binary analysis done by govulncheck, not building govulncheck.

This line might change in the near future, but for very different reasons.

@iglov
Copy link

@iglov iglov commented on deda8bb Jul 1, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, ok, thanks :)

Please sign in to comment.