feat: update POC

golangci · Mar 3, 2024 · 0b14054 · 0b14054
1 parent 6fb922a
commit 0b14054
Show file tree

Hide file tree

Showing 5 changed files with 19 additions and 11 deletions.
diff --git a/pkg/experimental/commands/.mygcl.reference.yml b/pkg/experimental/commands/.mygcl.reference.yml
@@ -1,5 +1,6 @@
 version: v1.56.2
 name: custom-golangci-lint # optional, default: gcl-custom
+destination: ./my/path/    # optional, default: .
 plugins:
   # a plugin from a Go proxy
   - module: 'github.com/example/plugin3'

diff --git a/pkg/experimental/commands/custom/internal/builder.go b/pkg/experimental/commands/custom/internal/builder.go
@@ -178,7 +178,14 @@ func (b Builder) copyBinary(binaryName string) error {
 		return fmt.Errorf("stat source file: %w", err)
 	}
 
-	dst, err := os.OpenFile(filepath.Clean(binaryName), os.O_RDWR|os.O_CREATE|os.O_TRUNC, info.Mode())
+	if b.cfg.Destination != "" {
+		err = os.MkdirAll(b.cfg.Destination, os.ModePerm)
+		if err != nil {
+			return fmt.Errorf("create destination directory: %w", err)
+		}
+	}
+
+	dst, err := os.OpenFile(filepath.Join(b.cfg.Destination, binaryName), os.O_RDWR|os.O_CREATE|os.O_TRUNC, info.Mode())
 	if err != nil {
 		return fmt.Errorf("create destination file: %w", err)
 	}

diff --git a/pkg/experimental/commands/custom/internal/configuration.go b/pkg/experimental/commands/custom/internal/configuration.go
@@ -23,6 +23,9 @@ type Configuration struct {
 	// Name of the binary.
 	Name string `yaml:"name,omitempty"`
 
+	// Destination is the path to a directory to store the binary.
+	Destination string `yaml:"destination,omitempty"`
+
 	// Plugins information.
 	Plugins []*Plugin `yaml:"plugins,omitempty"`
 }

diff --git a/pkg/experimental/commands/custom/internal/imports.go b/pkg/experimental/commands/custom/internal/imports.go
@@ -22,7 +22,7 @@ import (
 func (b Builder) updatePluginsFile() error {
 	importsDest := filepath.Join(b.repo, "cmd", "golangci-lint", "plugins.go")
 
-	_, err := os.Stat(importsDest)
+	info, err := os.Stat(importsDest)
 	if err != nil {
 		return fmt.Errorf("file %s not found: %w", importsDest, err)
 	}
@@ -34,14 +34,7 @@ func (b Builder) updatePluginsFile() error {
 
 	b.log.Infof("generated imports info %s:\n%s\n", importsDest, source)
 
-	file, err := os.Open(filepath.Clean(importsDest))
-	if err != nil {
-		return fmt.Errorf("open file %s: %w", importsDest, err)
-	}
-
-	defer func() { _ = file.Close() }()
-
-	_, err = file.Write(source)
+	err = os.WriteFile(filepath.Clean(importsDest), source, info.Mode())
 	if err != nil {
 		return fmt.Errorf("write file %s: %w", importsDest, err)
 	}

diff --git a/pkg/experimental/commands/mygcl.schema.json b/pkg/experimental/commands/mygcl.schema.json
@@ -12,6 +12,10 @@
           "type": "string",
           "description": "Name of the binary."
         },
+        "destination": {
+          "type": "string",
+          "description": "Destination is the path to a directory to store the binary."
+        },
         "plugins": {
           "items": {
             "$ref": "#/$defs/Plugin"
@@ -69,4 +73,4 @@
     }
   },
   "description": "mygcl configuration definition file"
-}
+}