Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

--deadline is a misnomer #655

Closed
variadico opened this issue Aug 30, 2019 · 1 comment · Fixed by #793
Closed

--deadline is a misnomer #655

variadico opened this issue Aug 30, 2019 · 1 comment · Fixed by #793
Labels
area: config Related to .golangci.yml and/or cli options area: docs

Comments

@variadico
Copy link

--deadline should be called --timeout. A timeout is a relative time like what we're supposed to pass to the --deadline flag. An actual deadline is an absolute time.

Timeout: finish in 10 seconds.
Deadline: finish at 7:15:35PM.

https://news.ycombinator.com/item?id=9948203
https://golang.org/pkg/context/#WithDeadline

This was confusing to me when I was reading the docs.
@tpounds tpounds added the area: config Related to .golangci.yml and/or cli options label Oct 6, 2019
@titusjaka
Copy link
Contributor

I would like to grab this one :)

@titusjaka titusjaka mentioned this issue Oct 7, 2019
Merged
RomanBednar added a commit to RomanBednar/ibm-vpc-block-csi-driver that referenced this issue Jul 16, 2024
@RomanBednar
fix golangci-lint argument
be0ba69 
The argument was renamed long time ago and not available in latest
releases: golangci/golangci-lint#655
RomanBednar added a commit to RomanBednar/ibm-vpc-block-csi-driver that referenced this issue Jul 16, 2024
@RomanBednar
UPSTREAM: 173: lint fix
da391c1 
This is a partial cherry-pick of upstream PR 173 to fix golangci-lint.

The --deadline argument was removed in the latest releases:
golangci/golangci-lint#655
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area: config Related to .golangci.yml and/or cli options area: docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Rename deadline option to timeout and mark deadline as deprecated titusjaka/golangci-lint
3 participants
@tpounds @variadico @titusjaka