Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-enable default excludes by ID #1045

Merged
merged 3 commits into from
Apr 25, 2020

Conversation

JohnStarich
Copy link
Contributor

Adds IDs to default exclusions so they can be re-included on a case-by-case basis.

Backward-compatible part of #456

@CLAassistant
Copy link

CLAassistant commented Apr 25, 2020

CLA assistant check
All committers have signed the CLA.

Copy link
Member

@ernado ernado left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with one minor point.

Pattern: "Potential file inclusion via variable",
Linter: "gosec",
Why: "False positive is triggered by 'src, err := ioutil.ReadFile(filename)'",
},
}

func GetDefaultExcludePatternsStrings() []string {
func GetDefaultExcludePatternsStrings(include []string) []string {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please create a new function so we can maintain backward compatibility in API?
E..g. GetExcludePatternsStrings(include []string) that will be called from GetDefaultExcludePatternsStrings().

@JohnStarich
Copy link
Contributor Author

Thanks for the lightning-fast review! Updated 👍

@JohnStarich JohnStarich requested a review from ernado April 25, 2020 19:31
@ernado ernado merged commit 4a3e9fd into golangci:master Apr 25, 2020
@JohnStarich JohnStarich deleted the feature/include-excludes branch April 25, 2020 21:41
@JohnStarich
Copy link
Contributor Author

Thank you @ernado! Easily the fastest turn-around on a PR I've had in a while 😄

Thoughts on when the next release might be cut?

@ernado
Copy link
Member

ernado commented Apr 25, 2020

Thoughts on when the next release might be cut?

I'm planning to do it next week, currently busy with github action for golangci-lint :)
Also trying not to rush with new versions and should test it for a while.

@JohnStarich
Copy link
Contributor Author

Ok, no worries! Sounds fun 🙂

@ldez ldez added this to the v1.25 milestone Mar 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants