-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Re-enable default excludes by ID #1045
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with one minor point.
pkg/config/config.go
Outdated
Pattern: "Potential file inclusion via variable", | ||
Linter: "gosec", | ||
Why: "False positive is triggered by 'src, err := ioutil.ReadFile(filename)'", | ||
}, | ||
} | ||
|
||
func GetDefaultExcludePatternsStrings() []string { | ||
func GetDefaultExcludePatternsStrings(include []string) []string { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you please create a new function so we can maintain backward compatibility in API?
E..g. GetExcludePatternsStrings(include []string)
that will be called from GetDefaultExcludePatternsStrings()
.
Thanks for the lightning-fast review! Updated 👍 |
Thank you @ernado! Easily the fastest turn-around on a PR I've had in a while 😄 Thoughts on when the next release might be cut? |
I'm planning to do it next week, currently busy with github action for golangci-lint :) |
Ok, no worries! Sounds fun 🙂 |
Adds IDs to default exclusions so they can be re-included on a case-by-case basis.
Backward-compatible part of #456