Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: SARIF format require issue column >= 1 #4775

Merged
merged 2 commits into from
May 30, 2024
Merged

fix: SARIF format require issue column >= 1 #4775

merged 2 commits into from
May 30, 2024

Conversation

Zxilly
Copy link
Contributor

@Zxilly Zxilly commented May 30, 2024

Some linters won't provider column value for issue, under this situation we should set it to 1.

image

For real world error see https://github.com/Zxilly/go-size-analyzer/actions/runs/9300840788/job/25597744381

@ldez ldez added the area: output Related to issue output label May 30, 2024
@ldez ldez changed the title fix: sarif format require issue column >= 1 fix: SARIF format require issue column >= 1 May 30, 2024
@ldez ldez added the bug Something isn't working label May 30, 2024
@ldez ldez added this to the next milestone May 30, 2024
ldez
ldez approved these changes May 30, 2024
View reviewed changes
Copy link
Member

@ldez ldez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ldez ldez merged commit e1a8055 into golangci:master May 30, 2024
13 checks passed
@ldez ldez modified the milestones: next, v1.59 Jun 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ldez ldez ldez approved these changes

Assignees
No one assigned
Labels
area: output Related to issue output bug Something isn't working
Projects
None yet
Milestone
v1.59
Development

Successfully merging this pull request may close these issues.
2 participants
@Zxilly @ldez