New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dev: avoid string conversion by passing byte slice #5304

Merged

ldez merged 2 commits into golangci:master from alexandear:refactor/pass-byte-slice

Jan 8, 2025

Member

alexandear commented Jan 8, 2025

The PR refactors code:

Change patch string to patch []byte in ExtractDiagnosticFromPatch.
Rename theDiff to patch in the goformatters.NewAnalyzer.
Use patch instead of string(patch) as %q will correctly output byte slice as string.

alexandear and others added 2 commits

January 8, 2025 16:24


          dev: avoid string convertion by passing byte slice

45bcaeb


          chore: minor changes

3b91c63

ldez added the topic: cleanup label

ldez added this to the next milestone

ldez approved these changes

View reviewed changes

Member

ldez left a comment

LGTM

ldez merged commit fb1674e into golangci:master

15 checks passed

alexandear deleted the refactor/pass-byte-slice branch

January 8, 2025 16:25

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels