dev: new processor order #5322
Merged
dev: new processor order #5322
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ldez
added
enhancement
ldez
force-pushed
the
feat/processors-godoc-order
branch
from
eacffc5 to
88d9ade
Compare
alexandear
reviewed
Jan 15, 2025
alexandear
approved these changes
Jan 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes processor inconsistencies, and provides a better output as limits are applied after the
Fixer.Some details:
UniqByLine: this processor was skipped when--fixwas used.MaxPerFileFromLinter: this processor was inconsistent with the other processors. It doesn't make sense to limit the issues for the Fixer by linter for a file: if golangci-lint fixes a file, all changes of one linter must be applied.MaxSameIssues: this processor was skipped when--fixwas used.MaxFromLinter: this processor was skipped when--fixwas used.SourceCode: related to user output, the fixer doesn't need it.PathShortener: related to user output, the fixer doesn't need it.Severity: related to user output, the fixer doesn't need it.PathPrefixer: related to user output, the fixer doesn't need it.SortResults: related to user output, the fixer doesn't need it.More explanation here: #5297 (comment)