BUGFIX: add error variable to handle context not updated #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rodericusifo
requested review from
isogram,
dimassantoso and
agungdwiprasetyo
agungdwiprasetyo
approved these changes
Dec 24, 2023
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #35 +/- ##
=======================================
Coverage 18.66% 18.66%
=======================================
Files 41 41
Lines 2454 2454
=======================================
Hits 458 458
Misses 1981 1981
Partials 15 15 ☔ View full report in Codecov by Sentry. |
|
You're welcome, Mas,
But i wonder how do you can test it on postman? If the grpc server
reflection not enabled? Can you give me a short tutorial maybe?
About grpc server reflection:
https://github.com/grpc/grpc-go/blob/master/Documentation/server-reflection-tutorial.md#enable-server-reflection
…On Mon, Dec 25, 2023, 6:12 AM Agung Dwi Prasetyo ***@***.***> wrote:
***@***.**** approved this pull request.
LGTM! Great! Thank you for your contribution 🙇♂️
btw I also usually use postman to test grpc server
image.png (view on web)
<https://github.com/golangid/candi/assets/11459449/334c7118-1333-4ecb-a139-3cbf47d10cda>
—
Reply to this email directly, view it on GitHub
<#35 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AOXOBSKGXSW533TCYJNHKKDYLCZHDAVCNFSM6AAAAABBBISCM2VHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTOOJVGYZDSNJVGY>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
|
Oh okay Mas, Now i know how to test the gprc without server reflection, it
turn out, can be tested via import proto file on postman
On Mon, Dec 25, 2023, 9:20 AM Rodericus Ifo Krista ***@***.***>
wrote:
… You're welcome, Mas,
But i wonder how do you can test it on postman? If the grpc server
reflection not enabled? Can you give me a short tutorial maybe?
About grpc server reflection:
https://github.com/grpc/grpc-go/blob/master/Documentation/server-reflection-tutorial.md#enable-server-reflection
On Mon, Dec 25, 2023, 6:12 AM Agung Dwi Prasetyo ***@***.***>
wrote:
> ***@***.**** approved this pull request.
>
> LGTM! Great! Thank you for your contribution 🙇♂️
>
> btw I also usually use postman to test grpc server
> image.png (view on web)
> <https://github.com/golangid/candi/assets/11459449/334c7118-1333-4ecb-a139-3cbf47d10cda>
>
> —
> Reply to this email directly, view it on GitHub
> <#35 (review)>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/AOXOBSKGXSW533TCYJNHKKDYLCZHDAVCNFSM6AAAAABBBISCM2VHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTOOJVGYZDSNJVGY>
> .
> You are receiving this because you authored the thread.Message ID:
> ***@***.***>
>
|
|
that's right, just import proto in postman and all methods in that proto will appear |
|
okay thank you Mas, for the info 🙏
Best regards
Rodericus Ifo Krista
…On Tue, Dec 26, 2023 at 9:36 AM Agung Dwi Prasetyo ***@***.***> wrote:
that's right, just import proto in postman and all methods in that proto
will appear
—
Reply to this email directly, view it on GitHub
<#35 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AOXOBSNVUHECYP3PFPVIL23YLIZ4LAVCNFSM6AAAAABBBISCM2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQNRZGIYDOMZTGM>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello Team Dev Golang Candi,
I want to raise a bug in the middleware interceptor, in the previous code, the context was not updated because it was newly initiated using ( := ), so when in the looping process the context value was not passed to the next middleware. I hope this bug can be fixed soon. Because I like using this framework.
And Also I'd like to suggest new feature, which is grpc server reflection, so the grpc can be tested in postman. Thank You
Best Regards
Rodericus Ifo Krista