-
-
Notifications
You must be signed in to change notification settings - Fork 274
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(graphql-request): update graphql and graphql-request packages #664
feat(graphql-request): update graphql and graphql-request packages #664
Conversation
We have to update these packages because there are issues with Node LTS(20.9.0) if we do not update packages
@GauthierD- Can you confirm that within the version range there are no breaking changes? |
hello @underfisk Here you can find the breaking changes for these 2 packages Graphql-request
graphql-js
if my PR is accepted, I think the package |
Hi, thanks for listing it. |
@underfisk thx for your answer Do you know when the next major release is scheduled? I assume we're not the only team experiencing issues with this package when used with [email protected] (the current LTS) |
@WonderPanda may be able to answer you on that one, as i mentioned earlier i do not have control over releases |
I think its fine for us to just ship a new major for this. The packages are super out of date. Thanks for the contribution |
@GauthierD- Since we haven't hit a 1.x release before this is a minor update:
Please try out 0.2.0 and let us know if everything is in working order for you |
@WonderPanda We still have an error, we don't know why.... Because when we downlaod the package from Github + local build + npm link we have 0 issues but with the package from npm, we have the same error. We'll try to reproduce our error with a small stack and I'll come back here if I find something |
What's new?
graphql@^16.8.1
(latest)graphql-request@^6.1.0
(latest)Why ?