location: twister+pytest test for native_sim and playback data #730
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Visit the preview URL for this PR (updated for commit d6dbd0c): https://golioth-firmware-sdk-doxygen-dev--pr730-location-twist-i5zp8gfh.web.app (expires Wed, 29 Jan 2025 11:29:31 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: a9993e61697a3983f3479e468bcb0b616f9a0578 |
mniestroj
force-pushed
the
location-cellular-combined
branch
3 times, most recently
from
c394b4a to
0463d0f
Compare
mniestroj
force-pushed
the
location-twister-combined
branch
from
b96c6c7 to
e3addef
Compare
sam-golioth
reviewed
Jan 16, 2025
examples/zephyr/location/sample.yaml
Outdated
| - CONFIG_GOLIOTH_WIFI_PLAYBACK=n | ||
| - CONFIG_GOLIOTH_SAMPLE_TWISTER_TEST=y | ||
| - arch:posix:CONFIG_NATIVE_UART_0_ON_STDINOUT=y | ||
| - CONFIG_GOLIOTH_CELLULAR_PLAYBACK=n |
There was a problem hiding this comment.
Suggested change
| - CONFIG_GOLIOTH_CELLULAR_PLAYBACK=n | |
| - CONFIG_GOLIOTH_WIFI_PLAYBACK=n |
There was a problem hiding this comment.
Good catch. Updated and retested locally with dev:
INFO - 1/4 native_sim/native/64 sample.golioth.location NOT RUN (build)
INFO - sample.golioth.location NOT RUN Test was built only
INFO - 2/4 native_sim/native/64 sample.golioth.location.playback.wifi PASSED (native 12.779s)
INFO - sample.golioth.location.playback.wifi.test_location PASSED
INFO - 3/4 native_sim/native/64 sample.golioth.location.playback.cellular PASSED (native 27.618s)
INFO - sample.golioth.location.playback.cellular.test_location PASSED
INFO - 4/4 native_sim/native/64 sample.golioth.location.playback PASSED (native 37.775s)
INFO - sample.golioth.location.playback.test_location PASSED
INFO - 4 test scenarios (4 configurations) selected, 0 configurations filtered (0 by static filter, 0 at runtime).
0463d0f to
3b33bd3
Compare
mniestroj
force-pushed
the
location-twister-combined
branch
from
e3addef to
4ecc5ac
Compare
sam-golioth
approved these changes
Jan 21, 2025
Rely on playback data to result in accurate location data. Wait for first 3 locations and match logged data with expected position. Signed-off-by: Marcin Niestroj <[email protected]>
mniestroj
force-pushed
the
location-twister-combined
branch
from
4ecc5ac to
d6dbd0c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are 3 runtime tests:
all executed using
native_simplatform and playback data.Supersedes: #725