Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix SSH Git Servers secret #54

Merged
merged 2 commits into from
Jan 22, 2024
Merged

Fix SSH Git Servers secret #54

merged 2 commits into from
Jan 22, 2024

Conversation

hilariocoelho
Copy link
Contributor

Fixes #53 by removing the dash that trims the prefix.

Manifest generated using version 0.9.1:

kind: Secret
apiVersion: v1
metadata:
  name: athens-athens-proxy-ssh-git-servers
  labels:
    
    app: athens-athens-proxy
    chart: athens-proxy-0.9.1
    release: "athens"
    heritage: "Helm"
    app.kubernetes.io/name: athens-athens-proxy
    helm.sh/chart: athens-proxy-0.9.1
    app.kubernetes.io/managed-by: "Helm"
    app.kubernetes.io/instance: "athens"
    app.kubernetes.io/version: "v0.13.1"
type: Opaque
data:id_rsa-sample.server.com: "LS0tLS1CRUdJTiBPUEVOU1NIIFBSSVZBVEUgS0VZLS0tLS0KUkVEQUNURUQKLS0tLS1FTkQgT1BFTlNTSCBQUklWQVRFIEtFWS0tLS0tCg=="

Manifest generated after the fix:

kind: Secret
apiVersion: v1
metadata:
  name: athens-athens-proxy-ssh-git-servers
  labels:
    
    app: athens-athens-proxy
    chart: athens-proxy-0.9.1
    release: "athens"
    heritage: "Helm"
    app.kubernetes.io/name: athens-athens-proxy
    helm.sh/chart: athens-proxy-0.9.1
    app.kubernetes.io/managed-by: "Helm"
    app.kubernetes.io/instance: "athens"
    app.kubernetes.io/version: "v0.13.1"
type: Opaque
data:
  id_rsa-sample.server.com: "LS0tLS1CRUdJTiBPUEVOU1NIIFBSSVZBVEUgS0VZLS0tLS0KUkVEQUNURUQKLS0tLS1FTkQgT1BFTlNTSCBQUklWQVRFIEtFWS0tLS0tCg=="

@hilariocoelho hilariocoelho requested a review from a team as a code owner January 11, 2024 01:28
Copy link
Member

@DrPsychick DrPsychick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To release this, please bump the Chart.yaml version (patch)

@DrPsychick DrPsychick merged commit 969185d into gomods:main Jan 22, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Invalid SSH Git Server secret manifest
2 participants