Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor colorize/colorizef functions #210

Merged
merged 1 commit into from
Jan 7, 2025
Merged

Refactor colorize/colorizef functions #210

merged 1 commit into from
Jan 7, 2025

Conversation

HeavyWombat
Copy link
Collaborator

@HeavyWombat HeavyWombat commented Jan 7, 2025

Introduce constants for color names.

Simplify setup of colorize and colorizef.

Copy link

codecov bot commented Jan 7, 2025

Codecov Report

Attention: Patch coverage is 74.35897% with 20 lines in your changes missing coverage. Please review.

Project coverage is 75.81%. Comparing base (2a19f16) to head (6f25fc9).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
output.go 45.45% 12 Missing ⚠️
output_json.go 64.70% 6 Missing ⚠️
output_yaml.go 94.87% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #210      +/-   ##
==========================================
- Coverage   76.08%   75.81%   -0.28%     
==========================================
  Files           7        7              
  Lines         895      885      -10     
==========================================
- Hits          681      671      -10     
  Misses        173      173              
  Partials       41       41              
Flag Coverage Δ
unittests 75.81% <74.35%> (-0.28%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@HeavyWombat HeavyWombat force-pushed the develop branch 2 times, most recently from c23448e to c4439b9 Compare January 7, 2025 21:10
Introduce constants for color names.

Simplify setup of `colorize` and `colorizef`.

Signed-off-by: Rachel Sheikh <[email protected]>
Co-authored-by: Matthias Diester <[email protected]>
@HeavyWombat HeavyWombat merged commit d7220bf into main Jan 7, 2025
4 of 6 checks passed
@HeavyWombat HeavyWombat deleted the develop branch January 7, 2025 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants